On tablet, camera light is still on when app is not focus |
|||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) Open Camera app - the camera light will turn on (2) Open another app (3) What is the expected result? The camera and camera light should turn off. What happens instead? Not sure if it's intended, but the camera light is still on when user is using a different app. I find it concerning that the camera could still be on when I'm out of the camera app. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 15
,
Aug 20
,
Aug 20
Yuli - do you think we can stop the stream when CCA is out of focus or minimized?
,
Aug 20
It might be feasible, but it might be good to be consistent with other apps. It seems Chrome doesn't stop WebRTC streams when out of focus? By the way, suddenly stopping video recording when users opened another app might not be good user experience?
,
Aug 20
It seems reasonable to stop stream when an app is minimized. Maybe CCA could do that and urge other apps to do the same?
,
Aug 20
We have use cases where we need to camera to keep streaming when minimized. For example, ppl often put the Hangouts chat window to the background during video calls. But for camera apps, it's reasonable to close the camera when the app is out of focus. We had similar discussion before. See the discussion on b/74323561.
,
Sep 3
,
Sep 3
,
Sep 3
Hi Yuli, can we have this feature for M-70?
,
Sep 3
shenghao@ and I have discussed: we will make CCA disconnected during minimized but stay connected when out of focus. Thanks.
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/9231f5391ccce17a86cb4dbd0865a80e34caa9ec commit 9231f5391ccce17a86cb4dbd0865a80e34caa9ec Author: Yuli Huang <yuli@chromium.org> Date: Thu Sep 06 14:38:54 2018 Disconnect camera when locked or minimized. BUG= chromium:874298 ,b:74323561 TEST=Tested by minimizing window and locking screen. Change-Id: I3512d25368b61d9ae44a084184a78cb360a51bbe Reviewed-on: https://chromium-review.googlesource.com/1203475 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/9231f5391ccce17a86cb4dbd0865a80e34caa9ec/src/js/views/camera.js [modify] https://crrev.com/9231f5391ccce17a86cb4dbd0865a80e34caa9ec/src/css/main.css [modify] https://crrev.com/9231f5391ccce17a86cb4dbd0865a80e34caa9ec/src/js/background.js
,
Sep 6
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/5f6b7c586f2d9e4a8e72d8f606dbe90b8173a894 commit 5f6b7c586f2d9e4a8e72d8f606dbe90b8173a894 Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 07:21:09 2018 Disconnect camera when locked or minimized. BUG= chromium:874298 ,b:74323561 TEST=Tested by minimizing window and locking screen. Change-Id: I3512d25368b61d9ae44a084184a78cb360a51bbe Reviewed-on: https://chromium-review.googlesource.com/1203475 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> (cherry picked from commit 31f9124d1b853a9f143c625d2d698929bc9f2be3) Reviewed-on: https://chromium-review.googlesource.com/1210283 [modify] https://crrev.com/5f6b7c586f2d9e4a8e72d8f606dbe90b8173a894/src/js/views/camera.js [modify] https://crrev.com/5f6b7c586f2d9e4a8e72d8f606dbe90b8173a894/src/css/main.css [modify] https://crrev.com/5f6b7c586f2d9e4a8e72d8f606dbe90b8173a894/src/js/background.js
,
Sep 9
Found a regression and will submit another fix.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/22b93df3fb2c818fda9c3b40b538f82fc69c9911 commit 22b93df3fb2c818fda9c3b40b538f82fc69c9911 Author: Yuli Huang <yuli@chromium.org> Date: Mon Sep 17 08:56:53 2018 Fix regression that disconnects camera and revise on-stop call. 1. Fix camera disconnected unexpectedly during idling. 2. on-stop should wait for async end-take before starting a new stream. BUG= chromium:874298 TEST=Tested by minimizing window/locking screen/idling/recording. Change-Id: I7733cab1bb05d0a25a5280990fcd12ea77f1dd59 Reviewed-on: https://chromium-review.googlesource.com/1215263 Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/22b93df3fb2c818fda9c3b40b538f82fc69c9911/src/js/views/camera.js
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/b56d7f44b040829a629ab6c6610109d3c969385f commit b56d7f44b040829a629ab6c6610109d3c969385f Author: Yuli Huang <yuli@chromium.org> Date: Mon Sep 17 08:59:18 2018 Fix regression that disconnects camera and revise on-stop call. 1. Fix camera disconnected unexpectedly during idling. 2. on-stop should wait for async end-take before starting a new stream. BUG= chromium:874298 TEST=Tested by minimizing window/locking screen/idling/recording. Change-Id: I7733cab1bb05d0a25a5280990fcd12ea77f1dd59 Reviewed-on: https://chromium-review.googlesource.com/1215263 Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> Tested-by: yuli <yuli@chromium.org> (cherry picked from commit 22b93df3fb2c818fda9c3b40b538f82fc69c9911) Reviewed-on: https://chromium-review.googlesource.com/1226955 Reviewed-by: yuli <yuli@chromium.org> [modify] https://crrev.com/b56d7f44b040829a629ab6c6610109d3c969385f/src/js/views/camera.js
,
Sep 17
,
Sep 25
Verified on CCA 5.2.1
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9231f5391ccce17a86cb4dbd0865a80e34caa9ec commit 9231f5391ccce17a86cb4dbd0865a80e34caa9ec Author: Yuli Huang <yuli@chromium.org> Date: Thu Sep 06 14:38:54 2018 Disconnect camera when locked or minimized. BUG= chromium:874298 ,b:74323561 TEST=Tested by minimizing window and locking screen. Change-Id: I3512d25368b61d9ae44a084184a78cb360a51bbe Reviewed-on: https://chromium-review.googlesource.com/1203475 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/9231f5391ccce17a86cb4dbd0865a80e34caa9ec/src/css/main.css [modify] https://crrev.com/9231f5391ccce17a86cb4dbd0865a80e34caa9ec/src/js/background.js [modify] https://crrev.com/9231f5391ccce17a86cb4dbd0865a80e34caa9ec/src/js/views/camera.js
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b93df3fb2c818fda9c3b40b538f82fc69c9911 commit 22b93df3fb2c818fda9c3b40b538f82fc69c9911 Author: Yuli Huang <yuli@chromium.org> Date: Mon Sep 17 08:56:53 2018 Fix regression that disconnects camera and revise on-stop call. 1. Fix camera disconnected unexpectedly during idling. 2. on-stop should wait for async end-take before starting a new stream. BUG= chromium:874298 TEST=Tested by minimizing window/locking screen/idling/recording. Change-Id: I7733cab1bb05d0a25a5280990fcd12ea77f1dd59 Reviewed-on: https://chromium-review.googlesource.com/1215263 Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/22b93df3fb2c818fda9c3b40b538f82fc69c9911/src/js/views/camera.js |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kejiashao@chromium.org
, Aug 15