New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Started
Owner:
Last visit 17 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature

Blocked on:
issue 874300

Blocking:
issue 868068



Sign in to add a comment
link

Issue 874296: Implement standalone RTCQuicTransport API

Reported by shampson@chromium.org, Aug 15 Project Member

Issue description

Tracking bug for CLs, so that launch bug is not bloated by landing CLs.

Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/iRJ3as8AYy4/97rywT_2CAAJ

Launch bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=868068

Specification:
https://w3c.github.io/webrtc-quic
 

Comment 1 by shampson@chromium.org, Aug 15

Blocking: 868068

Comment 2 by shampson@chromium.org, Aug 15

Blockedon: 874300

Comment 3 by bugdroid1@chromium.org, Sep 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b96caf1688e35b8ea35440e26d3c00b7d192b865

commit b96caf1688e35b8ea35440e26d3c00b7d192b865
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Sep 27 20:40:23 2018

QUIC core library shim for RTCQuicTransport.

The RTCQuicTransport web API needs to use the underlying core QUIC
library. In order to use this API we need to create a shim of the
library that subclasses the QuicSession and QuicStream. This change
subclasses the QuicSession and has some basic implementation for
establishing a connection.

Bug: 874296
Change-Id: I63acd4913abc23733521157bd1aca4a3d1301c65
Reviewed-on: https://chromium-review.googlesource.com/1170125
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594845}
[modify] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/DEPS
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_packet_transport.h
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport.h
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.h
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[add] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/b96caf1688e35b8ea35440e26d3c00b7d192b865/third_party/blink/tools/audit_non_blink_usage.py

Comment 4 by bugdroid1@chromium.org, Sep 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84500e35f9d9723f5d2f447e34abec94f4e66b6b

commit 84500e35f9d9723f5d2f447e34abec94f4e66b6b
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Sep 27 22:15:00 2018

QUIC core library shim for streams.

This includes subclassing the QuicStream to be used by the RTCQuicStream
web API. It is a very basic implementation for the stream, and does not
include the functionality that will be needed for reaading and writing.

Bug: 874296
Change-Id: I25b69c06986cd68728b966ec28b67684ace5a87b
Reviewed-on: https://chromium-review.googlesource.com/1199765
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594894}
[modify] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream.h
[add] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.cc
[add] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.h
[modify] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport.h
[modify] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
[modify] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[modify] https://crrev.com/84500e35f9d9723f5d2f447e34abec94f4e66b6b/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc

Comment 5 by bugdroid1@chromium.org, Sep 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9003d89c3b423e96556dfaba58ce62a596bc3fe0

commit 9003d89c3b423e96556dfaba58ce62a596bc3fe0
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Sep 28 19:57:54 2018

RTCQuicTransport: start() implementation

This change implements the RTCQuicTransport.start() method and
associated events: onstatechange, onerror.

Bug: 874296
Change-Id: I8cb5d525ff5dd9d7d0a07a306f72297febc9aaaa
Reviewed-on: https://chromium-review.googlesource.com/1171904
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595191}
[add] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension-helper.js
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-extension.https.html
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream.https.html
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicTransport-helper.js
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicTransport.https.html
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
[add] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[add] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
[add] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[add] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_ice_transport_adapter.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
[modify] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl

Comment 6 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea28756ce3995ccc5d0b973b6e8affcb604fac4

commit 4ea28756ce3995ccc5d0b973b6e8affcb604fac4
Author: Steve Anton <steveanton@chromium.org>
Date: Wed Oct 03 00:28:52 2018

Implement RTCQuicTransport.onquicstream and stream reset/finish

This CL implements the RTCQuicTransport createStream method and the
corresponding quicstream event hooked up to the QUIC adapters. It
also implements RTCQuicStream.reset/finish and statechange event to
allow end-to-end testing.

Bug: 874296
Change-Id: I331d37f3e21c606697b8768bf9eea59c90487163
Reviewed-on: https://chromium-review.googlesource.com/c/1217846
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596068}
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream.https.html
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicTransport-helper.js
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicTransport.https.html
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/bindings/modules/BUILD.gn
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.cc
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_host.h
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.h
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.cc
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.h
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_event.cc
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_event.h
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_event.idl
[add] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_event_init.idl
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/4ea28756ce3995ccc5d0b973b6e8affcb604fac4/third_party/blink/tools/audit_non_blink_usage.py

Comment 7 by bugdroid1@chromium.org, Oct 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9207a0170196bc362208406e74189bc1ba4e1694

commit 9207a0170196bc362208406e74189bc1ba4e1694
Author: Steve Anton <steveanton@chromium.org>
Date: Thu Oct 11 21:47:54 2018

C++ unit tests for RTCQuicTransport

This CL adds tests for the RTCQuicTransport Blink bindings against a
mock P2PQuicTransport.

Bug: 874296
Change-Id: I3d41ab19a359948d47e57bbc76fe767a20300ebc
Reviewed-on: https://chromium-review.googlesource.com/c/1260382
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598963}
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_ice_transport_adapter.h
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_ice_transport_adapter_cross_thread_factory.h
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_packet_transport.h
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_transport.h
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_transport_factory.h
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.cc
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.h
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc
[add] https://crrev.com/9207a0170196bc362208406e74189bc1ba4e1694/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.h

Comment 8 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59140bf780f77ebb53c655decda234d5ede6d782

commit 59140bf780f77ebb53c655decda234d5ede6d782
Author: Steve Anton <steveanton@chromium.org>
Date: Tue Oct 16 17:00:39 2018

C++ unit tests for RTCQuicStream

Bug: 874296
Change-Id: I8c0d22bf4d688accf30ea1fef0109723c319234b
Reviewed-on: https://chromium-review.googlesource.com/c/1278385
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600018}
[modify] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream.h
[add] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream.h
[modify] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_event.h
[add] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_test.cc
[modify] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc
[modify] https://crrev.com/59140bf780f77ebb53c655decda234d5ede6d782/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.h

Comment 9 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/332a7ca9a312f6b5345aba130fee2a4f9d0c7424

commit 332a7ca9a312f6b5345aba130fee2a4f9d0c7424
Author: Seth Hampson <shampson@chromium.org>
Date: Tue Nov 06 18:32:06 2018

Updates to P2PQuicTransport tests.

As part of the effort to add read/write to the P2PQuicTransportStream,
some of the stream level tests need to be moved into their own more
isolated testing environment. This includes using a MockQuicSession.
This change moves the stream unit tests to this new environment, and
also updates the p2p_quic_transport_test.cc to use Mock objects instead
of the fake objects for the delegates.

Bug: 874296
Change-Id: Ifdfd30f753a2b6090c8f73330978c5feed2b9cf6
Reviewed-on: https://chromium-review.googlesource.com/c/1312971
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605753}
[modify] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.cc
[modify] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.h
[add] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_unittest.cc
[modify] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[add] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream_delegate.h
[add] https://crrev.com/332a7ca9a312f6b5345aba130fee2a4f9d0c7424/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_transport_delegate.h

Comment 10 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350f7d4b2c76950c8e7271284de84a9756b796e1

commit 350f7d4b2c76950c8e7271284de84a9756b796e1
Author: Seth Hampson <shampson@chromium.org>
Date: Tue Nov 06 19:01:36 2018

P2PQuicStream write functionality.

This adds the P2PQuicStream::WriteData function and adds tests. It also
adds the concept of a write buffered amount, enforcing this at the
P2PQuicStreamImpl.

Bug: 874296
Change-Id: Id02c8aa8d5368a87bb24a2e50dab5ef94bcae131
Reviewed-on: https://chromium-review.googlesource.com/c/1315534
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605766}
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream.h
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.cc
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.h
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_unittest.cc
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream.h
[modify] https://crrev.com/350f7d4b2c76950c8e7271284de84a9756b796e1/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream_delegate.h

Comment 11 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd2efc13427db48d7ffc9457e38e06ca1dc55257

commit fd2efc13427db48d7ffc9457e38e06ca1dc55257
Author: Seth Hampson <shampson@chromium.org>
Date: Tue Nov 06 19:22:52 2018

P2PQuicStream read functionality.

This adds the P2PQuicStream::Delegate::OnDataReceived and adds tests. It
also adds the concept of marking data as consumed by the application and
keeping track of the application's read buffered size and amount. This
ensures that the P2PQuicStream does not give the application more data
than it can buffer, and if its buffer is full it will apply backpressure
to the send side.

Bug: 874296
Change-Id: I85f677778631a04a5eb1ccd71457485c9444824e
Reviewed-on: https://chromium-review.googlesource.com/c/1316836
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605783}
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream.h
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.cc
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.h
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_unittest.cc
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.h
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream.h
[modify] https://crrev.com/fd2efc13427db48d7ffc9457e38e06ca1dc55257/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream_delegate.h

Comment 12 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91

commit cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91
Author: Steve Anton <steveanton@chromium.org>
Date: Tue Nov 06 22:43:12 2018

Reflect P2PQuicStream changes in Blink bindings

Bug: 874296
Change-Id: Ic86b9420c7cbfc190a79fef13dfe4494bf039c3c
Reviewed-on: https://chromium-review.googlesource.com/c/1318392
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605859}
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.h
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.cc
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.h
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/cb0454d59b07d26d9d7ebf5aa2860adb8f0faa91/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h

Comment 13 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3c0eae982d97e0e6035a4600e35624546715a00

commit a3c0eae982d97e0e6035a4600e35624546715a00
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Nov 07 09:49:54 2018

Jumbo build fix: Rename some test constants in peerconnection

In jumbo builds many cc files compile in the same translation
unit. That means that they also share the same anonymous namespace
(which is per translation unit, not per file which would have
been better). In https://chromium-review.googlesource.com/c/1316836
and https://chromium-review.googlesource.com/c/1315534 two
peerconnection tests each added a kWriteBufferSize and a
kDelegateReadBufferSize with different values which broke
some jumbo build configurations (unluckily not the one in CQ but
some in fyi builders).

This renames the variables to have more unique names.

TBR=shampson@chromium.org,hbos@chromium.org

Bug: 874296
Change-Id: Ifc8af2be440f7a959b948c05e18deaf55aeefad2
Reviewed-on: https://chromium-review.googlesource.com/c/1322709
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#606002}
[modify] https://crrev.com/a3c0eae982d97e0e6035a4600e35624546715a00/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_unittest.cc
[modify] https://crrev.com/a3c0eae982d97e0e6035a4600e35624546715a00/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc

Comment 14 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f56cb6871a547bd00cdf1630f55d22c59d633495

commit f56cb6871a547bd00cdf1630f55d22c59d633495
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Nov 09 00:44:04 2018

Replace std::vector with WTF::Vector in P2PQuicStream

Bug: 874296
Change-Id: I233cda30e59b696bc6960f1e7366cbee62849bed
Reviewed-on: https://chromium-review.googlesource.com/c/1325011
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606675}
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.cc
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_impl.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_unittest.cc
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_host.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.cc
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/quic_stream_proxy.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream_delegate.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
[modify] https://crrev.com/f56cb6871a547bd00cdf1630f55d22c59d633495/third_party/blink/renderer/platform/cross_thread_copier.h

Comment 15 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/547edc4d5a10947d85546d3cb11c04f56be71490

commit 547edc4d5a10947d85546d3cb11c04f56be71490
Author: Steve Anton <steveanton@chromium.org>
Date: Mon Nov 12 21:29:12 2018

Refactor P2PQuicTransportConfig to only contain values

This allows P2PQuicTransportConfig to be constructed on the main
thread and passed to the WebRTC worker thread where the
P2PQuicTransport is constructed.

This reduces the amount of boilerplate code needed to construct the
object in a cross-threaded manner as more parameters are added to
the config.

Bug: 874296
Change-Id: I3ae2f09b1c53e7b12f804c2c526d3dad29b323ff
Reviewed-on: https://chromium-review.googlesource.com/c/1330845
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607335}
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_transport_factory.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/547edc4d5a10947d85546d3cb11c04f56be71490/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc

Comment 17 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61720441ceae8e19ba59d32e651b7c9354ac45f0

commit 61720441ceae8e19ba59d32e651b7c9354ac45f0
Author: Steve Anton <steveanton@chromium.org>
Date: Tue Nov 13 19:45:23 2018

Implement RTCQuicStream.write()

Bug: 874296
Change-Id: I1786acb3b64fa0450e76fe27300c178081d1e191
Reviewed-on: https://chromium-review.googlesource.com/c/1285528
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607708}
[add] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream-helper.js
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream.https.html
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream.h
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
[modify] https://crrev.com/61720441ceae8e19ba59d32e651b7c9354ac45f0/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_test.cc

Comment 18 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c01a0825031ea1c73022707c936130c10650763a

commit c01a0825031ea1c73022707c936130c10650763a
Author: Steve Anton <steveanton@chromium.org>
Date: Thu Nov 15 23:47:13 2018

Add CloseReason to RTCIceTransport, RTCQuicTransport and RTCQuicStream

RTCQuicStream needs to know if it is being closed by
ContextDestroyed (which is only known from RTCIceTransport) to
avoid rejected promises.

Adding a CloseReason additionally moves all closing code to one
method which makes it easier to reason about.

Bug: 874296
Tbr: hbos@chromium.org
Change-Id: I58afc7b56412c836b8d178868297c4fbf76320c1
Reviewed-on: https://chromium-review.googlesource.com/c/1334935
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608581}
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.cc
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.h
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_ice_transport_test.cc
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
[modify] https://crrev.com/c01a0825031ea1c73022707c936130c10650763a/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc

Comment 19 by bugdroid1@chromium.org, Nov 16

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d52dc48a1e12cde04b77225379d3ac10f320a86

commit 9d52dc48a1e12cde04b77225379d3ac10f320a86
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Nov 16 19:02:10 2018

Implement RTCQuicStream.readInto()

Bug: 874296
Tbr: hbos@chromium.org
Change-Id: Id2905574237fe9221d49a1e772c9ba0f3e7957e1
Reviewed-on: https://chromium-review.googlesource.com/c/1289436
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608878}
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream.https.html
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
[add] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_read_result.idl
[modify] https://crrev.com/9d52dc48a1e12cde04b77225379d3ac10f320a86/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_test.cc

Comment 21 by bugdroid1@chromium.org, Nov 16

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc231cc0d8cbcba4caf0ebe15fda975a576f664

commit efc231cc0d8cbcba4caf0ebe15fda975a576f664
Author: Steve Anton <steveanton@chromium.org>
Date: Fri Nov 16 23:35:40 2018

Fix the P2PQuicTransport getting wedged under load

When the P2PQuicTransport's packet writer gets an error from the
underlying P2PTransportChannel, it will signal write blocked to the
QUIC library. In order to resume sending, the P2PTransportChannel
should indicate when it can start sending again.

This CL fixes two problems:
1) Changes the writable signal from SignalWriteState to
   SignalReadyToSend. SignalReadyToSend is signaled by the
   underlying IPC socket when a Send would no longer cause an
   EAGAIN.
2) Changes the IPC socket to fire SignalReadyToSend only at the
   very end of the IPC handler so that the listener can back in to
   the P2PPacketSocket safely.

Bug: 874296
Change-Id: I8276f60165928f77ca62243f3e5865897aa2cf6f
Reviewed-on: https://chromium-review.googlesource.com/c/1330299
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609024}
[modify] https://crrev.com/efc231cc0d8cbcba4caf0ebe15fda975a576f664/content/renderer/p2p/ipc_socket_factory.cc
[modify] https://crrev.com/efc231cc0d8cbcba4caf0ebe15fda975a576f664/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc

Comment 24 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e604c7d717bf59632db21cc0cc095b983874978f

commit e604c7d717bf59632db21cc0cc095b983874978f
Author: Seth Hampson <shampson@chromium.org>
Date: Sat Dec 15 03:37:53 2018

Update for RTCQuicStream.write() function.

Combines functionality of finish() into write() by adding a new
QuicStreamWriteParameters input parameter that includes a finish
boolean. This is consistent with the latest spec draft and also adds
symmetry between readInto() and write().

Bug: 874296
Change-Id: I0def0ca25587ebf00a4b179ce8e9e7a124c818f6
Reviewed-on: https://chromium-review.googlesource.com/c/1376720
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616941}
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_test.cc
[add] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_write_parameters.idl
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicStream-helper.js
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicStream.https.html
[modify] https://crrev.com/e604c7d717bf59632db21cc0cc095b983874978f/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Comment 25 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94f10850fc5d7d9b9dfe7a06d4f08370e4bef9b3

commit 94f10850fc5d7d9b9dfe7a06d4f08370e4bef9b3
Author: Seth Hampson <shampson@chromium.org>
Date: Wed Dec 19 15:14:45 2018

Increasing max count for incoming dynamic streams.

Currently the RTCTransport uses the default value for a maximum of 100
QUIC streams. This can be a problem in the case that an application
wants to create a large number of RTCQuicStreams for small chunks of
data.

Bug: 874296
Change-Id: Ic8063ad06a930d6c1ff23c3afa58d7c49b69be05
Reviewed-on: https://chromium-review.googlesource.com/c/1383295
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617836}
[modify] https://crrev.com/94f10850fc5d7d9b9dfe7a06d4f08370e4bef9b3/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc

Comment 26 by bugdroid1@chromium.org, Jan 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd

commit 3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd
Author: Seth Hampson <shampson@chromium.org>
Date: Mon Jan 07 18:00:45 2019

RTCQuicTransport bug fix OnConnectionFailure.

Currently when the QUIC connection fails, a DCHECK is hit because the
"failed" state is not interpreted as a closed state. This change fixes
this and also fixes a use after free bug in the QuicTransportProxy.

Bug: 874296
Change-Id: I1982ab9268c22e411f9da11d89b17b4b31a279f9
Reviewed-on: https://chromium-review.googlesource.com/c/1395568
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620373}
[modify] https://crrev.com/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[modify] https://crrev.com/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
[modify] https://crrev.com/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc

Comment 27 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d66718b4f59598d625abdaf5b739ec3d501151

commit 99d66718b4f59598d625abdaf5b739ec3d501151
Author: Seth Hampson <shampson@chromium.org>
Date: Tue Jan 08 21:19:06 2019

Updating handshake timeouts for P2PQuicTransport.

Bug: 874296
Change-Id: I4a168869b3dd5a66fd79de49bdb0d7cfb8964fdb
Reviewed-on: https://chromium-review.googlesource.com/c/1400960
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620880}
[modify] https://crrev.com/99d66718b4f59598d625abdaf5b739ec3d501151/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc

Comment 28 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9c9e105a63e4500b02053928abb6a33faebd649

commit b9c9e105a63e4500b02053928abb6a33faebd649
Author: Seth Hampson <shampson@chromium.org>
Date: Sat Jan 12 04:02:59 2019

Optimization for RTCQuicTransport- buffering CHLO.

If signaling arrives late on the server side of the RTCQuicTransport it
can be started after a CHLO has been received. This optimization buffers
the CHLO packet, so that the server doesn't need to wait another half
RTT + timeout for QUIC to retransmit the CHLO.

Bug: 874296
Change-Id: Iab35c1f5dba29cd2deaf5446a2d06d6990fe57f6
Reviewed-on: https://chromium-review.googlesource.com/c/1404433
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622287}
[modify] https://crrev.com/b9c9e105a63e4500b02053928abb6a33faebd649/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/b9c9e105a63e4500b02053928abb6a33faebd649/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/b9c9e105a63e4500b02053928abb6a33faebd649/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[add] https://crrev.com/b9c9e105a63e4500b02053928abb6a33faebd649/third_party/blink/renderer/modules/peerconnection/adapters/quic_packet_transport_adapter.cc
[add] https://crrev.com/b9c9e105a63e4500b02053928abb6a33faebd649/third_party/blink/renderer/modules/peerconnection/adapters/quic_packet_transport_adapter.h
[add] https://crrev.com/b9c9e105a63e4500b02053928abb6a33faebd649/third_party/blink/renderer/modules/peerconnection/adapters/quic_packet_transport_adapter_test.cc

Comment 29 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f2364b28101ebb442a3330669116963d373b7d8

commit 1f2364b28101ebb442a3330669116963d373b7d8
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Jan 17 16:48:15 2019

Refactor of P2PTransportImpl for crypto config.

This change refactors the P2PTransportImpl to take in a factory that can
create a QUIC client or server crypto configuration. This allows a
cleaner interface for injecting the crypto configurations, and removes
the hacky interface that was used for testing to inject a failing crypto
configuration.

Bug: 874296
Change-Id: I3268b258b38fe8ff1d57717bd8185b4a9701dd09
Reviewed-on: https://chromium-review.googlesource.com/c/1407924
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623717}
[modify] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory.h
[add] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.cc
[add] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.h
[modify] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
[modify] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
[modify] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[modify] https://crrev.com/1f2364b28101ebb442a3330669116963d373b7d8/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc

Comment 30 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5

commit b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Jan 17 19:22:24 2019

Implements pre shared key in P2PQuicTransport.

A few small changes to implement the pre shared key with the
P2PQuicTransportImpl. This includes updating so that the crypto streams
aren't created at construction time, adding a setter and removing the
splitting out the default setter for the remote fingerprints.

Bug: 874296
Change-Id: I76be13eb90365b6f75edf4c3951c49fe4cce2ef3
Reviewed-on: https://chromium-review.googlesource.com/c/1408033
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623788}
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport.h
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_transport.h
[modify] https://crrev.com/b05fe8ec0debeeecfdb7d0903996e0c4c11f69a5/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc

Comment 31 by bugdroid1@chromium.org, Jan 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfadd29f493aa4dc77a9f93ddd4c78db02e01317

commit bfadd29f493aa4dc77a9f93ddd4c78db02e01317
Author: Seth Hampson <shampson@chromium.org>
Date: Sat Jan 19 02:00:27 2019

Adds pre shared key support to RTCQuicTransport.

This change adds the PSK APIs to the RTCQuicTransport object. This is
done with a readonly key, connect() and listen() methods. This change
keeps the C++ objects certificate support with the current APIs, but
removes these from being exposed in the web idl file. Tests are updated
by moving web platform tests that involve certificates into C++
tests.

Bug: 874296
Change-Id: I58500dca36bfdb6fdb605d540ccbfc49ed6ec878
Reviewed-on: https://chromium-review.googlesource.com/c/1415839
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624411}
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.h
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicTransport-helper.js
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicTransport.https.html
[modify] https://crrev.com/bfadd29f493aa4dc77a9f93ddd4c78db02e01317/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Comment 32 by bugdroid, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71474e5d964c983b23517685c2a8005cd0986cd

commit e71474e5d964c983b23517685c2a8005cd0986cd
Author: Seth Hampson <shampson@chromium.org>
Date: Tue Jan 22 22:27:52 2019

Exposes P2PQuicTransport level stats.

Takes stats from quic::QuicConnection and exposes them in a
P2PQuicTransportStats struct. These stats will be exposed for the
JavaScript API.

Bug: 874296
Change-Id: Iacfe362346d828d319368af23c49fa54862b7057
Reviewed-on: https://chromium-review.googlesource.com/c/1423670
Commit-Queue: Seth Hampson <shampson@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624966}
[modify] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[modify] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport.h
[modify] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
[modify] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
[add] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_stats.cc
[add] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_stats.h
[modify] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
[modify] https://crrev.com/e71474e5d964c983b23517685c2a8005cd0986cd/third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_transport.h

Comment 33 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a70719973246f3ac5c388a7be2b9a571f2da313

commit 1a70719973246f3ac5c388a7be2b9a571f2da313
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Jan 24 01:29:20 2019

RTCQuicTransport & RTCIceTransport - SecureContext

Updates the RTCQuicTransport and RTCIceTransport idl files to restrict
the APIs to secure contexts only.

Bug: 874296
Change-Id: Ib669480ea323df8e8856e38ff3f3798afb78c606
Reviewed-on: https://chromium-review.googlesource.com/c/1430432
Commit-Queue: Seth Hampson <shampson@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625472}

Comment 34 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bc24b649c8d060cd7d41e406571c662db1638cf

commit 0bc24b649c8d060cd7d41e406571c662db1638cf
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Jan 24 06:01:25 2019

Adds getStats() method to RTCQuicTransport.

getStats() returns a promise that resolves with a dictionary of stats
defined in the RTCQuicTransportStats dictionary.

Bug: 874296
Change-Id: I907e529ebf074842c6702df7d90349515c48a5ba
Reviewed-on: https://chromium-review.googlesource.com/c/1430599
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625524}

Comment 35 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c91aee8268699ae58e391c9f520d6a8b98007643

commit c91aee8268699ae58e391c9f520d6a8b98007643
Author: Seth Hampson <shampson@chromium.org>
Date: Thu Jan 24 07:34:07 2019

Configures origin trial for RTCQuicTransport.

Updates to include the RTCQuicTransport and RTCIceTransport in the
origin trial. Intent to experiment:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/xXf23VY_8uM/lDBcbf8KAgAJ

Bug: 874296
Change-Id: I8b1c41f59a32c37ef1a1dc95ca1e74cfa7c17acb
Reviewed-on: https://chromium-review.googlesource.com/c/1430745
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625547}

Comment 36 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35aaf51aa2fe66020b110711ae52a3884446af36

commit 35aaf51aa2fe66020b110711ae52a3884446af36
Author: Seth Hampson <shampson@chromium.org>
Date: Fri Jan 25 02:00:06 2019

RTCQuicTransport uses proper buffer size constants.

This updates the RTCQuicTransport to use the proper read and write
buffer sizes that are defined in RTCQuicStream.

Bug: 874296
Change-Id: I38fb97cc19c1ed21338b8c0d6ecd03177eb602d8
Reviewed-on: https://chromium-review.googlesource.com/c/1435137
Commit-Queue: Seth Hampson <shampson@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625942}

Comment 37 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbc927810bc92693e285e79a1653cdd8a87b9469

commit bbc927810bc92693e285e79a1653cdd8a87b9469
Author: Seth Hampson <shampson@chromium.org>
Date: Fri Jan 25 03:11:15 2019

Adds metrics for RTCQuicTransport origin trial.

The metrics inludes usage counters for the RTCQuicTransport,
RTCIceTransport and RTCQuicStream APIs. This also includes histogram
metrics for the readInto() and write() RTCQuicStream methods, recording
the amount of bytes as well as an enum for how bytes are read/written.

Bug: 874296
Change-Id: I53036a9e0c477b98ab52e32484b1fb472140c305
Reviewed-on: https://chromium-review.googlesource.com/c/1435074
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625970}

Comment 38 by shampson@chromium.org, Jan 26

Labels: -Pri-3 Merge-Request-73 Pri-2
Requesting a merge into M73 for the following changes that just missed the branch cut:
https://chromium-review.googlesource.com/c/chromium/src/+/1437322
 -Adds metrics to track in the origin trial.
https://chromium-review.googlesource.com/c/chromium/src/+/1437581
 -Fixes a constant value

They are safe changes and important for the origin trial we are beginning for M73.

Thanks!

Comment 39 by sheriffbot@chromium.org, Jan 26

Project Member
Labels: -Merge-Request-73 Merge-Review-73 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), cindyb@(ChromeOS), srinivassista@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 40 by abdulsyed@google.com, Jan 28

Labels: -Merge-Review-73 Merge-Approved-73

Comment 41 by bugdroid, Jan 28

Project Member
Labels: -merge-approved-73 merge-merged-3683
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44530b672521d41338a2198340468226125f1868

commit 44530b672521d41338a2198340468226125f1868
Author: Seth Hampson <shampson@chromium.org>
Date: Mon Jan 28 18:26:16 2019

Adds metrics for RTCQuicTransport origin trial.

The metrics inludes usage counters for the RTCQuicTransport,
RTCIceTransport and RTCQuicStream APIs. This also includes histogram
metrics for the readInto() and write() RTCQuicStream methods, recording
the amount of bytes as well as an enum for how bytes are read/written.

Bug: 874296
Change-Id: I53036a9e0c477b98ab52e32484b1fb472140c305
Reviewed-on: https://chromium-review.googlesource.com/c/1435074
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#625970}(cherry picked from commit bbc927810bc92693e285e79a1653cdd8a87b9469)
Reviewed-on: https://chromium-review.googlesource.com/c/1437322
Cr-Commit-Position: refs/branch-heads/3683@{#21}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

Comment 42 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40e6f95e39a8b4c105521054548488ed1baaaed9

commit 40e6f95e39a8b4c105521054548488ed1baaaed9
Author: Seth Hampson <shampson@chromium.org>
Date: Wed Jan 30 23:47:45 2019

RTCQuicTransport uses proper buffer size constants.

This updates the RTCQuicTransport to use the proper read and write
buffer sizes that are defined in RTCQuicStream.

Bug: 874296
Change-Id: I38fb97cc19c1ed21338b8c0d6ecd03177eb602d8
Reviewed-on: https://chromium-review.googlesource.com/c/1435137
Commit-Queue: Seth Hampson <shampson@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#625942}(cherry picked from commit 35aaf51aa2fe66020b110711ae52a3884446af36)
Reviewed-on: https://chromium-review.googlesource.com/c/1437581
Cr-Commit-Position: refs/branch-heads/3683@{#80}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
[modify] https://crrev.com/40e6f95e39a8b4c105521054548488ed1baaaed9/third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
[modify] https://crrev.com/40e6f95e39a8b4c105521054548488ed1baaaed9/third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc

Comment 43 by cr-audit...@appspot.gserviceaccount.com, Feb 7

Project Member
Labels: Merge-Merged-73-3683
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/40e6f95e39a8b4c105521054548488ed1baaaed9

Commit: 40e6f95e39a8b4c105521054548488ed1baaaed9
Author: shampson@chromium.org
Commiter: shampson@chromium.org
Date: 2019-01-30 23:47:45 +0000 UTC

RTCQuicTransport uses proper buffer size constants.

This updates the RTCQuicTransport to use the proper read and write
buffer sizes that are defined in RTCQuicStream.

Bug: 874296
Change-Id: I38fb97cc19c1ed21338b8c0d6ecd03177eb602d8
Reviewed-on: https://chromium-review.googlesource.com/c/1435137
Commit-Queue: Seth Hampson <shampson@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#625942}(cherry picked from commit 35aaf51aa2fe66020b110711ae52a3884446af36)
Reviewed-on: https://chromium-review.googlesource.com/c/1437581
Cr-Commit-Position: refs/branch-heads/3683@{#80}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

Comment 44 by cr-audit...@appspot.gserviceaccount.com, Feb 7

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/44530b672521d41338a2198340468226125f1868

Commit: 44530b672521d41338a2198340468226125f1868
Author: shampson@chromium.org
Commiter: steveanton@chromium.org
Date: 2019-01-28 18:26:16 +0000 UTC

Adds metrics for RTCQuicTransport origin trial.

The metrics inludes usage counters for the RTCQuicTransport,
RTCIceTransport and RTCQuicStream APIs. This also includes histogram
metrics for the readInto() and write() RTCQuicStream methods, recording
the amount of bytes as well as an enum for how bytes are read/written.

Bug: 874296
Change-Id: I53036a9e0c477b98ab52e32484b1fb472140c305
Reviewed-on: https://chromium-review.googlesource.com/c/1435074
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#625970}(cherry picked from commit bbc927810bc92693e285e79a1653cdd8a87b9469)
Reviewed-on: https://chromium-review.googlesource.com/c/1437322
Cr-Commit-Position: refs/branch-heads/3683@{#21}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

Sign in to add a comment