New issue
Advanced search Search tips

Issue 874295 link

Starred by 1 user
Status: Fixed
Owner:
katie@chromium.org
Closed: Sep 25
Cc:
dtseng@chromium.org
dmazz...@chromium.org
msw@chromium.org
katie@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocked on:
issue 881509
Blocking:
issue 826529



Sign in to add a comment

Port SelectToSpeakEventHandler to mash

Project Member Reported by jamescook@chromium.org, Aug 15 
chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h

It calls aura::Env::GetInstance()->AddPreTargetHandler(this). Under mash that won't see all events, since the browser process won't get all events. Under SingleProcessMash it will likely be wrong also, since there are two aura::Envs.

From another bug msw said: The rewriter tracking bug is Issue 647781; pre-target handlers are similar. See my doc:
https://docs.google.com/document/d/1BR5_AlF9oK-XnC7ATWiMMEYtu1HouHA6xtWp90LXwFo

Probably this class needs to be split into ash and non-ash parts.

In the very short term I wonder if it should call ash::Shell::Get()->AddPreTargetHandler() just to make the dependency clearer.

Comment 1 by katie@chromium.org, Aug 15

Components: UI>Accessibility>SelectToSpeak

Comment 2 by katie@chromium.org, Sep 6

Status: Started (was: Available)
Giving this a shot...

Comment 3 by katie@chromium.org, Sep 6

Owner: katie@chromium.org

Comment 4 by katie@chromium.org, Sep 6

Blockedon: 881509

Comment 5 by katie@chromium.org, Sep 6

Blocking: 826529
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c2c79c8339b6cc211a00f93bab2833901ca2b7c

commit 3c2c79c8339b6cc211a00f93bab2833901ca2b7c
Author: Katie D <katie@chromium.org>
Date: Tue Sep 25 07:46:49 2018

Split SelectToSpeakEventHandler into ash / chrome parts.

This will allow the SelectToSpeakEventHandler to work under mash.

Bug:  874295 
Change-Id: I81795f6a665de925405b15f40210338ba0634c76
Reviewed-on: https://chromium-review.googlesource.com/1212095
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593852}
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/BUILD.gn
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/events/OWNERS
[rename] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/events/select_to_speak_event_handler.cc
[rename] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/events/select_to_speak_event_handler.h
[rename] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/events/select_to_speak_event_handler_unittest.cc
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/chrome/browser/chromeos/accessibility/accessibility_manager.h
[add] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_delegate.cc
[add] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_delegate.h
[modify] https://crrev.com/3c2c79c8339b6cc211a00f93bab2833901ca2b7c/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc

Comment 7 by katie@chromium.org, Sep 25

Status: Fixed (was: Started)
►

Sign in to add a comment