MultiDeviceSetupImpl accepts SecureChannelClient as a constructor argument, but never uses it. https://cs.chromium.org/chromium/src/chromeos/services/multidevice_setup/multidevice_setup_impl.cc?q=MultiDeviceSetupImpl&sq=package:chromium&dr=CSs&l=55 When implementing this, ensure that SecureChannelClient is actually used by whatever injects the client into MultiDeviceSetupImpl.
TetherHostFetcher also does not need a DeviceSyncClient.
i will take this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae commit e38daaea87dfcd7a408fc00b14e7862df4c8b7ae Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Fri Sep 21 19:12:17 2018 Remove SecureChannelClient from MultiDeviceSetupImpl MultiDeviceSetupImpl accepts SecureChannelClient as a constructor argument, but never uses it. Bug: 874283 Change-Id: Ie748eee5ed0852ff57f80144376038f7f51f1860 Reviewed-on: https://chromium-review.googlesource.com/1238294 Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#593287} [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_impl.cc [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_impl.h [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_initializer.cc [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_initializer.h [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_service.cc [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_service.h [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/multidevice_setup_service_unittest.cc [modify] https://crrev.com/e38daaea87dfcd7a408fc00b14e7862df4c8b7ae/chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client_impl_unittest.cc
Comment 1 by khorimoto@chromium.org
, Aug 30