New issue
Advanced search Search tips

Issue 874275 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Dark border around the selected tab

Reported by another....@gmail.com, Aug 14

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3521.2 Safari/537.36

Steps to reproduce the problem:
Try a light color theme or choose a light color from windows color settings for the title bar.

Please note:
There isn't any ugly dark border in Version 70.0.3514.0
This is a regression if not was intended.

What is the expected behavior?
There isn't any dark border around the selected tab.

What went wrong?
Ugly dark border around the selected tab.

Did this work before? Yes 70.0.3514.0

Chrome version: 70.0.3521.2  Channel: dev
OS Version: 10.0
Flash Version:
 
Comparison_Actual_Expected.jpg
130 KB View Download
Actual.png
35.8 KB View Download
Expected.png
35.3 KB View Download
Labels: Needs-Triage-M70 Needs-Bisect
Cc: viswa.karala@chromium.org
Labels: Needs-Feedback Triaged-ET
Tried testing the issue on chrome reported version on 70.0.3521.2 and on 70.0.3514.0 using Windows-10 with steps mentioned below:
1) Launched chrome reported version and installed light coloured theme and checked the UI of tab strips
2) Seen a dark border as shown in comment# 0 Actual.png, but the colour of the tab strips remain same(light colour) find the attached screenshot for the same
Observations: Also tested the issue by changing the title bar colour from the window colour settings, didn't seen dark border around the tab strip

Theme URL: https://chrome.google.com/webstore/detail/light-theme-for-google-ch/macolkedjdbklefnogmlebabkakpcacg?utm_source=chrome-ntp-icon

@Reporter: Please find the attached screenshots and above information and provide your feedback on it. could you please provide sample extension/ URL that reproduces the issue which help in further triaging it.

Thanks!
874275 - With theme.PNG
146 KB View Download
874275 - Without theme.PNG
143 KB View Download
Perhaps it is limited to some PC screens.
On my laptop I can see the dark border around the selected tab.

Please, this is a serious issue and maybe it should someone from the dev team take look at this issue.

Please try the attached theme which I'm using right now.
Install From:
Extension > Load unpacked > Theme folder
Flat Theme.zip
448 bytes Download
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 16

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision RegressedIn-70 ReleaseBlock-Stable Target-70 M-70 FoundIn-70 OS-Linux OS-Mac Pri-1
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 70.0.3521.2 and on latest chrome# 70.0.3524.0 using Windows-10, Mac 10.12.6 & Ubuntu 14.04, hence providing Bisect Info
Bisect Info:
================
Good build: 70.0.3514.0
Bad build: 70.0.3515.0

You are probably looking for a change made after 581060 (known good), but no later than 581061 (first known bad).  https://chromium.googlesource.com/chromium/src/+log/581330a9f8fa0cd9b3b83def1611740a186a4881..7af9ca12fe8c5e6060c9d0e5617ed824f67d9026
Change-Id: Iac25d17618487e03aac7bfa6f54e98848ce47c24
Reviewed-on: https://chromium-review.googlesource.com/1159385

@Tom Anderson: Please confirm the issue and help in re-assigning if it is not related to your change.
Adding ReleaseBlock-Stable as it is seems a recent break, feel free to remove it if not applicable.

Thanks!
Cc: pkasting@chromium.org
Labels: -ReleaseBlock-Stable
Status: WontFix (was: Assigned)
This is expected behavior.  The border is drawn when there's low contrast between tabs and the frame.

the contrast ratio in OP's theme is 1.29, which is just barely below our 1.3 cutoff to draw the border.

The tabs and frame are the same color in c#3, so a border should obviously be drawn in that case.

Sign in to add a comment