New issue
Advanced search Search tips

Issue 874266 link

Starred by 2 users
Status: Fixed
Owner:
x...@chromium.org
Closed: Aug 22
Cc:
omrilio@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Gesture-polish


Sign in to add a comment

Background behind parent Chrome window should be overview background

Project Member Reported by mccanny@chromium.org, Aug 14 
When dragging a tab out of a fullscreen Chrome browser window in tablet mode, the window scales down. When it does, the background behind the window should be the same blurred and scrimmed wallpaper from Overview.

Screenshot showing current behavior with another app (Files app) visible behind the parent:
https://drive.google.com/open?id=112mnckZ__-w_WVcKxNqIh3XpQXHWLyX_
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3033516b6092540f77f70e9d74edd6c8e5f400ea

commit 3033516b6092540f77f70e9d74edd6c8e5f400ea
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Aug 22 23:06:41 2018

Tab dragging: background behind the dragged tab's source window.

When dragging a tab out of a browser window (source window), the source
window scales down. The background behind the source window should be
the same blurred and darkened wallpaper as in overview.

See recorded video:
https://drive.google.com/open?id=1I_tXdQzUsiCwAqFikmZi9EywnUG1-wKl

Bug:  874266 
Change-Id: Ie25dd3594fbcef37cda5c427e4daebf0ecffb1fd
Reviewed-on: https://chromium-review.googlesource.com/1185521
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585295}
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/overview/window_grid.h
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/overview/window_selector_controller.h
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/tablet_mode/tablet_mode_browser_window_drag_delegate.cc
[modify] https://crrev.com/3033516b6092540f77f70e9d74edd6c8e5f400ea/ash/wm/tablet_mode/tablet_mode_browser_window_drag_delegate.h

Comment 2 by x...@chromium.org, Aug 22

Status: Fixed (was: Untriaged)

Comment 3 by x...@chromium.org, Aug 24 

Issue 877665 has been merged into this issue.
►

Sign in to add a comment