New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874265 link

Starred by 1 user
Status: Fixed
Owner:
█ medinaan...@chromium.org
Last visit > 30 days ago
Closed: Aug 27
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Enable move constructor in protos.

Project Member Reported by medinaan...@chromium.org, Aug 14 
Feature description: Current protoc does not generate move constructors for protos. Request is to uprev to newer protobuf to be able to take advantage of move constructors.

Eng owner:medinaandres
Product owner:

Design doc: 

Update should ensure all tests continue to pass.

Comment 1 by medinaan...@chromium.org, Aug 14

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e684cf418f04a776b3ffe3074dd635cce18e1870

commit e684cf418f04a776b3ffe3074dd635cce18e1870
Author: Andres Medina <medinaandres@google.com>
Date: Mon Aug 27 18:48:23 2018

third_party/protobuf: Update to cf242503

Followed steps on README.chromium to update protobuf. Added
BUILD.gn.template and gen_extra_chromium_files to automated
generation of extra files and BUILD.gn file.

removed unnecesary patches, updated patches and added new patch for
a missing override

Bug:  874265 
Change-Id: Icfc221ef47dab7191403c73791509b79383ac6b7
Reviewed-on: https://chromium-review.googlesource.com/1081411
Commit-Queue: Andres Medina <medinaandres@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586339}
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/PRESUBMIT.py
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/event_model_impl.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/event_model_impl_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/event_store.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/feature_config_condition_validator.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/feature_config_condition_validator_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/feature_config_event_storage_validator_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/init_aware_event_model_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/never_condition_validator_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/once_condition_validator_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/persistent_event_store.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/persistent_event_store_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/proto/BUILD.gn
[rename] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/proto/feature_event.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/stats.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/feature_engagement/internal/test/event_util.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/leveldb_proto/proto_database_impl_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/leveldb_proto/proto_database_perftest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/leveldb_proto/testing/proto/BUILD.gn
[rename] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/components/leveldb_proto/testing/proto/test_db.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/BUILD.gn
[rename] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/media_remoting_rpc.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/proto_enum_utils.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/proto_utils.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/proto_utils_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/rpc_broker.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/media/remoting/rpc_broker_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/remoting/proto/BUILD.gn
[rename] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/remoting/proto/test_data_channel_manager.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/remoting/protocol/data_channel_manager_unittest.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/.gitignore
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/.gitmodules
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/.travis.yml
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/BUILD
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/BUILD.gn
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/CHANGES.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/LICENSE
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/Makefile.am
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/Protobuf.podspec
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/README.chromium
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/README.md
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/WORKSPACE
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/appveyor.bat
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/appveyor.yml
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/autogen.sh
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/Makefile.am
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/ProtoBench.java
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/README.md
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/__init__.py
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/benchmark_messages_proto2.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/cpp/cpp_benchmark.cc
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/cpp_benchmark.cc
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message1/proto2/benchmark_message1_proto2.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message1/proto2/dataset.google_message1_proto2.pb
[rename] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message1/proto3/benchmark_message1_proto3.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message1/proto3/dataset.google_message1_proto3.pb
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message2/benchmark_message2.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message2/dataset.google_message2.pb
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_1.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_2.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_3.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_4.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_5.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_6.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_7.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message3/benchmark_message3_8.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message4/benchmark_message4.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message4/benchmark_message4_1.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message4/benchmark_message4_2.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/datasets/google_message4/benchmark_message4_3.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/download_data.sh
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/generate_datasets.cc
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/go/go_benchmark_test.go
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/google_message1.dat
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/google_message2.dat
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/java/pom.xml
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/java/src/main/java/com/google/protobuf/ProtoCaliperBenchmark.java
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/python/__init__.py
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/python/py_benchmark.py
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/python/python_benchmark_messages.cc
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/benchmarks/readme.txt
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/util/__init__.py
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/util/big_query_utils.py
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/util/gogo_data_scrubber.cc
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/util/protoc-gen-gogoproto.cc
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/util/run_and_upload.py
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/benchmarks/util/schema_proto2_to_proto3_util.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/CMakeLists.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/README.md
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/extract_includes.bat.in
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/install.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/libprotobuf-lite.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/libprotobuf.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/libprotoc.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/protobuf-config-version.cmake.in
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/protobuf-config.cmake.in
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/protobuf-lite.pc.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/protobuf-module.cmake.in
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/protobuf.pc.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/protoc.cmake
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/tests.cmake
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/cmake/version.rc.in
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/composer.json
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/configure.ac
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/ConformanceJava.java
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/Makefile.am
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/autoload.php
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_cpp.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_nodejs.js
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_objc.m
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_php.php
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_python.py
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_ruby.rb
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_test.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_test.h
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/conformance_test_runner.cc
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_cpp.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_csharp.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_java.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_js.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_php.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_php_c.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_python.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_python_cpp.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/failure_list_ruby.txt
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/conformance/update_failure_list.py
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/Google.Protobuf.Tools.nuspec
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/README.md
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/build_packages.bat
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/buildall.sh
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/compatibility_tests/v3.0.0/src/Google.Protobuf.Test/GeneratedMessageTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/generate_protos.sh
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/global.json
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/protos/README.md
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/protos/map_unittest_proto3.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/protos/unittest_import_proto3.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/protos/unittest_import_public_proto3.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/protos/unittest_issues.proto
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/protos/unittest_proto3.proto
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/AddressBook/Addressbook.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Conformance.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Program.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/CodedInputStreamTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/Collections/MapFieldTest.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/Collections/ProtobufEqualityComparersTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/Collections/RepeatedFieldTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/Google.Protobuf.Test.csproj
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/IssuesTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonFormatterTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonParserTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonTokenizerTest.cs
[delete] https://crrev.com/a648ed8345adc49563301bde7071ae0f16b128e0/third_party/protobuf/csharp/src/Google.Protobuf.Test/Program.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/Reflection/DescriptorsTest.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/SampleNaNs.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/MapUnittestProto3.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/TestMessagesProto3.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestCustomOptionsProto3.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestImportProto3.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestImportPublicProto3.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestIssues.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestProto3.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestWellKnownTypes.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/UnknownFieldSetTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/AnyTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/WrappersTest.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/CodedInputStream.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Collections/Lists.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Collections/MapField.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Collections/ProtobufEqualityComparers.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Collections/RepeatedField.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Compatibility/MethodInfoExtensions.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/FieldCodec.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Google.Protobuf.csproj
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/JsonParser.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/JsonTokenizer.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/MessageExtensions.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/MessageParser.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/Descriptor.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FileDescriptor.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/OneofAccessor.cs
[modify] https://crrev.com/e684cf418f04a776b3ffe3074dd635cce18e1870/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs
[add] https://crrev.com/e684cf418f04a776b3ffe3074

Comment 3 by medinaan...@chromium.org, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment