New issue
Advanced search Search tips

Issue 874261 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Gesture-polish


Sign in to add a comment

Dragged tab window should have active window shadow

Project Member Reported by mccanny@chromium.org, Aug 14

Issue description

A pulled out tab window should have standard active window shadow:

x: 0dp, y: 24dp, blur/softness: 24dp

Spec reference:
https://drive.google.com/corp/drive/folders/1FbkROGIYgoE_s2ckOK3AgwuVcVPALZR3

 
Cc: minch@chromium.org zork@chromium.org
 Issue 846889  has been merged into this issue.
Im not to familiar with tab dragging but it looks like its still in maximized state, but transformed?

If so we can change [1] and add a ShouldIgnoreShowState to our delegate or something and that might work.

[1] https://cs.chromium.org/chromium/src/ui/wm/core/shadow_controller.cc?rcl=54738d34a08ba7be6a0bef44b2e53150396e22f9&l=260
It may be in maximized state or fullscreen state, but either transfromed (if dragging window) or resized (if dragging tabs). But I think your proposal should work. Thanks for the suggestion!
Ben, besides enable the active window shadow for a pulled out tab window, do we want the active window shadow for the following cases:
1) If a browser window only has one tab, and drag this tab around (the browser window might not be the current active window)
2) If drag on the non-tab caption area to drag the window (same as 1), the browser window might not be the current active window)

Good question. Does the dragged window or tab become the active window on release in these scenarios?
Currently not necessarily. But we may be able to set it as the active window for these 2 scenarios (If the window was not snapped in splitview or merged into overview)
Yeah, I've been thinking about it. I think dragging a window or tab should always give it focus / make it the active window. Whether or not it goes to overview, it becomes the last window the user interacted with.
Status: Started (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21

Status: Fixed (was: Started)

Sign in to add a comment