Issue metadata
Sign in to add a comment
|
PDFTestFiles/PDFExtensionLoadTest.Load/4 fails in Windows official builds when network services are enabled |
||||||||||||||||||||||||
Issue descriptionI think this is different from the bug I previously filed, https://crbug.com/855221 , which got duped against https://crbug.com/856161 , which is marked fixed. The test appears to fail consistently when run as part of the network_service_browser_tests test suite: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/ https://ci.chromium.org/buildbot/chromium.clang/ToTWin/2017 The relevant gtest logs are: ../../chrome/browser/pdf/pdf_extension_test.cc(258): error: Expected equality of these values: PdfIsExpectedToLoad(pdf_file) Which is: true success Which is: false pdf_private/cfuzz5.pdf Google Test trace: ../../chrome/browser/pdf/pdf_extension_test.cc(254): pdf_private/cfuzz5.pdf So, somehow the network services feature interacts badly with which PDF files are expected to load. The official buildbots do not run this test suite, so they do not see this failure.
,
Aug 14
> The symptoms sound fairly similar to issue 856161 to me. Right, it's the same failure mode, but I think this is a different issue specific to the network service feature.
,
Aug 14
That bug was about network_service_browser_tests. network_service_browser_tests is browser_tests with --enable-features=NetworkService.
,
Aug 20
Just to update: PDFTestFiles/PDFExtensionLoadTest.Load/8 Still seeing the same issue on Official desktop builder & continuous builder as below. Link to the builder: ------------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/4551 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/4926 Link to error log: ----------------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_beta%2F4551%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_beta%2F4926%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Could someone from cc'ed dev please take a look and update the thread. Thanks..!
,
Aug 20
(Imho we should reopen issue 856161 and dupe this to there, but *shrug*)
,
Aug 23
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cb49a6d7e02bf91d6c0ed71cb6b47555e699aad commit 5cb49a6d7e02bf91d6c0ed71cb6b47555e699aad Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Aug 24 19:43:15 2018 Fix PDF browsertest with network service. One file, which normally fails loading, sometimes loads depending on timing of network data. Bug: 874259 Change-Id: Ieeccd75c79f19499887fb72b99affedac89a560d Reviewed-on: https://chromium-review.googlesource.com/1187889 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585945} [modify] https://crrev.com/5cb49a6d7e02bf91d6c0ed71cb6b47555e699aad/chrome/browser/pdf/pdf_extension_test.cc
,
Aug 24
,
Aug 27
Now cfuzz5.pdf is failing in the regular browser_tests suite in official builds: https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/2033 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/91350
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35e9b88a6fbde47c6d1736c8b2de72c8119c6b9b commit 35e9b88a6fbde47c6d1736c8b2de72c8119c6b9b Author: John Abd-El-Malek <jam@chromium.org> Date: Tue Aug 28 06:29:17 2018 Restore cfuzz5.pdf as failing when NS is disabled. Bug: 874259 Change-Id: I63329aaab21843fc6d6f626ce581420a55a6931a Reviewed-on: https://chromium-review.googlesource.com/1192591 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586600} [modify] https://crrev.com/35e9b88a6fbde47c6d1736c8b2de72c8119c6b9b/chrome/browser/pdf/pdf_extension_test.cc
,
Aug 28
Just to update: PDFTestFiles/PDFExtensionLoadTest.Load/8 Still seeing the same issue on Official desktop builder & continuous builder as below. Link to the builder: ------------------- https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/1763 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/1080 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/1394 https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/1390 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/4632 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/5008 Link to error log: ----------------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Flinux64%2F1763%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin-asan%2F1080%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin-clang%2F1394%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin64-clang%2F1390%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_beta%2F4632%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_beta%2F5008%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Thanks!
,
Aug 28
The links above don't have the fix. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by thakis@chromium.org
, Aug 14