CSSAnimationsTest RetargetedTransition tests fail with blink gen property trees |
|||||
Issue description
These unit tests fail with BGPT force-enabled:
out/Debug/webkit_unit_tests --gtest_filter=*RetargetedTransition*
2 tests crashed:
CSSAnimationsTest.IncompatibleRetargetedTransition (../../third_party/blink/renderer/core/animation/css/css_animations_test.cc:95)
CSSAnimationsTest.RetargetedTransition (../../third_party/blink/renderer/core/animation/css/css_animations_test.cc:59)
../../third_party/blink/renderer/core/animation/css/css_animations_test.cc:48: Failure
Expected equality of these values:
1u
Which is: 1
element->GetComputedStyle()->Filter().size()
Which is: 0
To force-enable BGPT we need to both set the BlinkGenPropertyTreesEnabled flag, and set the use_layer_lists setting. This can be done by patching in https://chromium-review.googlesource.com/c/chromium/src/+/1058604 but we'll need to make a version of this test that runs in BGPT mode.
,
Sep 14
This is still occurring. Can you look at this Peter?
,
Sep 14
,
Sep 18
,
Sep 18
Looks like there are multiple causes for the BGPT failure: - Invisible element - BGPT Renderer unit tests not creating a LayerTreeHost skips a lot of BGPT compositing - SPv2 stub chrome client doesn't use layer lists - PaintPropertyTreeBuilder doesn't check for filter animations. I have fixes for all of these up at: https://chromium-review.googlesource.com/c/chromium/src/+/1230438
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96b11126f0b5a8401debfee1d10e0d40c1838aa8 commit 96b11126f0b5a8401debfee1d10e0d40c1838aa8 Author: Robert Flack <flackr@chromium.org> Date: Tue Sep 18 19:30:49 2018 Fix CSSAnimationsTest unit tests when running with BGPT A few changes were needed to get this to work in BGPT: - Create a StubChromeClientForSPv2 so that we have a LayerTreeHost, without which BGPT does not create composited animations. - Change StubChromeClientForSPv2 to tell the LayerTreeHostEmbedder to use layer lists when running with BGPT - Check for filter animations as well as current filters when deciding if we need a filter on a given object. Bug: 874253 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e057d8a225ead67728d68070e62ac62f7a33f19 Reviewed-on: https://chromium-review.googlesource.com/1230438 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592144} [modify] https://crrev.com/96b11126f0b5a8401debfee1d10e0d40c1838aa8/third_party/blink/renderer/core/animation/css/css_animations_test.cc [modify] https://crrev.com/96b11126f0b5a8401debfee1d10e0d40c1838aa8/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc [modify] https://crrev.com/96b11126f0b5a8401debfee1d10e0d40c1838aa8/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc [modify] https://crrev.com/96b11126f0b5a8401debfee1d10e0d40c1838aa8/third_party/blink/renderer/platform/testing/DEPS [modify] https://crrev.com/96b11126f0b5a8401debfee1d10e0d40c1838aa8/third_party/blink/renderer/platform/testing/layer_tree_host_embedder.cc [modify] https://crrev.com/96b11126f0b5a8401debfee1d10e0d40c1838aa8/third_party/blink/renderer/platform/testing/layer_tree_host_embedder.h
,
Sep 18
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sunyunjia@chromium.org
, Aug 15