Request ID reuse checks are not being done for network service |
||
Issue descriptionResourceDispatcherHostImpl does not allow duplicate request IDs: https://cs.chromium.org/chromium/src/content/browser/loader/resource_dispatcher_host_impl.cc?l=696&rcl=a2c773e3be2a4e4dad773cc60d245125530e5e6a This check is not being done for network service.
,
Aug 14
This is an implementation detail of ResourceDispatcherHostImpl, we shouldn't need to do these checks for network service.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae10116cc36d6b44868ccd4ae50589ff77b127e2 commit ae10116cc36d6b44868ccd4ae50589ff77b127e2 Author: Clark DuVall <cduvall@chromium.org> Date: Wed Aug 15 01:26:46 2018 Fix SecurityExploitBrowserTest to use network service path These tests were accessing ResourceMessageFilter directly, instead of using the network service path when it is enabled. Bug: 862176 , 874227 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3add3b588ad40c3bca265ad68adccca293ddae0d Reviewed-on: https://chromium-review.googlesource.com/1175105 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583117} [modify] https://crrev.com/ae10116cc36d6b44868ccd4ae50589ff77b127e2/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/ae10116cc36d6b44868ccd4ae50589ff77b127e2/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/ae10116cc36d6b44868ccd4ae50589ff77b127e2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/ae10116cc36d6b44868ccd4ae50589ff77b127e2/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter |
||
►
Sign in to add a comment |
||
Comment 1 by cduvall@chromium.org
, Aug 14