New issue
Advanced search Search tips

Issue 874226 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Print Preview: Fit to page displays error for mixed orientation PDF

Project Member Reported by thestig@chromium.org, Aug 14

Issue description

Chrome Version: 69.x / 70.x with "Enable new Print Preview UI" flag turned on.
OS: Desktop platforms

What steps will reproduce the problem?
(1) Open portrait_landscape.pdf
(2) Print
(3) Check the "Fit to page" checkbox. (The left pane may need to be expanded)

What is the expected result?

Scaling text box underneath the checkbox is blank.

What happens instead?

Scaling text box underneath the checkbox has the value 0. There is a warning that the amount must be between 10 and 200.
 
portrait_landscape.pdf
13.6 KB Download
Cc: nyerramilli@chromium.org rbasuvula@chromium.org rbpotter@chromium.org
 Issue 885142  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401094d9d99a8404a9fde5791fc61ded27e03bbd

commit 401094d9d99a8404a9fde5791fc61ded27e03bbd
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Sep 21 17:53:25 2018

Print Preview refresh: Fix some scaling bugs

2 bugs in the scaling section:
(1) Fix a pre-existing bug where the scaling input incorrectly displayed
0 and an error when fit to page was checked for a non-uniform page
size PDF
(2) Prevent cr-input from expanding to the full row to try
to fix a bug with touch on Windows.

Bug:  874226 ,  886854 
Change-Id: I8cb8785129f125a17a2ea8715ec85af3b467cad8
Reviewed-on: https://chromium-review.googlesource.com/1237516
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593249}
[modify] https://crrev.com/401094d9d99a8404a9fde5791fc61ded27e03bbd/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/401094d9d99a8404a9fde5791fc61ded27e03bbd/chrome/browser/resources/print_preview/new/scaling_settings.js

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-71.0.3559.0 TE-Verified-M71
Able to reproduce the issue on chrome version 70.0.3521.0 (build without fix) as per the comment #0.
Verified the fix on Mac 10.13.6, Windows 10 and Ubuntu 14.04 using Chrome version # 71.0.3559.0 
Attaching screen-cast for reference.
Observed that  " Scaling text box underneath the checkbox is blank " 
The fix is working as expected, adding Verified labels

Thanks...!
874226.mp4
2.7 MB View Download
Status: Verified (was: Assigned)

Sign in to add a comment