New issue
Advanced search Search tips

Issue 874218 link

Starred by 4 users
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Nov 17
Cc:
iclell...@chromium.org
cha...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-08-21
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Implement Feature Policy: animations

Project Member Reported by ekaramad@chromium.org, Aug 14 
This is the tracking bug for the implementation of 'animations' policy. This policy will be used to enable/disable use of certain animations on a page. The expected use case is to disable use of non-composited CSS animations in pages with loading and painting constraints.


Link to explainer:
https://github.com/WICG/feature-policy/blob/master/policies/animations.md

Link to chromestatus report:
https://www.chromestatus.com/feature/5209780754841600

Comment 1 by ekaramad@chromium.org, Aug 14

Summary: Implement Feature Policy: animations (was: mplement Feature Policy: animations)
Add link to a first implementation by iclelland@ (Thanks!):

https://chromium-review.googlesource.com/c/chromium/src/+/976390

The current implementation is behind productivity featuresflag and is non-parametric (only allows GPU accelerated animations).

Comment 2 by ekaramad@chromium.org, Aug 15

Description: Show this description

Comment 3 by monor...@bugs.chromium.org, Aug 21 

The NextAction date has arrived: 2018-08-21
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9024e95af4b609ab5ef86b9baca2a25449f3907c

commit 9024e95af4b609ab5ef86b9baca2a25449f3907c
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Sun Oct 21 03:49:12 2018

Implement feature-policy: 'layout-animations'

This CL converts the current "animations" feature policy to
"layout-animations" feature policy: the former policy is about blocking
non-composited animations whereas the new policy only blocks a handful
of CSS animations which are known to (potentially) cause re-layout and
are also widely used. The current set of CSS properties considered in
the new policy is: {bottom, height, left, right,top, width}.

Bug:  874218 
Change-Id: I97f08ce6b2b902c7057ea821416a9c145d26f068
Reviewed-on: https://chromium-review.googlesource.com/c/1235055
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601412}
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/WebKit/LayoutTests/external/wpt/css/motion/animation/resources/interpolation-testcommon.js
[add] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-disabled-tentative.html
[add] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-disabled-tentative.html.headers
[add] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-enabled-tentative.html
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/WebKit/LayoutTests/http/tests/feature-policy/composited-animations-allowed.php
[rename] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/WebKit/LayoutTests/http/tests/feature-policy/layout-animations-disabled-by-policy.php
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/blink/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/blink/public/mojom/feature_policy/feature_policy.mojom
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/blink/renderer/core/animation/css_interpolation_types_map.cc
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/third_party/blink/renderer/core/feature_policy/feature_policy.cc
[modify] https://crrev.com/9024e95af4b609ab5ef86b9baca2a25449f3907c/tools/metrics/histograms/enums.xml

Comment 5 by ekaramad@chromium.org, Nov 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment