Corners of the launcher are rounded, but the blur layer is not rounded. |
||||||||||
Issue descriptionThe corners of the launcher are rounded, but the blur does not have rounded corners. This means the corners of the launcher show up blurry even though the launcher body does not cover that area. The reason for this is that the corner radius is animated, and in order to mask the blur layer accurately we would also have to animate the mask layer. Mask layer animation is expensive, so we should avoid this. The solution for this is to make the launcher n pixels taller (where n is corner radius). Then instead of animating the corner radius, allow those top n pixels to go off screen as the launcher grows.
,
Aug 16
,
Aug 24
,
Aug 28
Design Document: https://docs.google.com/document/d/10g2T8Ybc7B-yRFA9S2lbWN5bx-yST_EcNbDLlzrlicU/edit?usp=sharing
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d17c61cd40a46d78a8a1a09404d707aafcf74dc commit 7d17c61cd40a46d78a8a1a09404d707aafcf74dc Author: Daniel Zhang <oxyflush@google.com> Date: Fri Aug 31 23:39:10 2018 cros: Change AppList corner behavior 1. Change behavior of AppList corners from animating from round to angular to no longer animating and disappearing offscreen at the top of the screen. 2. Fixed broken unit tests. Bug: 874200 Change-Id: I0983794bc58542a790b42bc3fcc17b64cc11e1b5 Reviewed-on: https://chromium-review.googlesource.com/1194862 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#588213} [modify] https://crrev.com/7d17c61cd40a46d78a8a1a09404d707aafcf74dc/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/7d17c61cd40a46d78a8a1a09404d707aafcf74dc/ash/app_list/views/app_list_view.h [modify] https://crrev.com/7d17c61cd40a46d78a8a1a09404d707aafcf74dc/ash/app_list/views/contents_view.cc
,
Sep 4
,
Sep 4
,
Sep 4
Bug with current implementation: Inset causes launcher to be 28 pixels too tall. Fix landing soon.
,
Sep 5
Fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1205497
,
Sep 5
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2971ab7789a2ac5e8fa5a8d012cd96727cb95619 commit 2971ab7789a2ac5e8fa5a8d012cd96727cb95619 Author: Daniel Zhang <oxyflush@google.com> Date: Wed Sep 05 20:48:32 2018 cros: Fix AppList bounds issue Fix bug where AppList bounds were 28 px too tall in peeking and closed states. Bug: 874200 Change-Id: I9b449c9310d946b405bb3b8f0610e5e1018c6872 Reviewed-on: https://chromium-review.googlesource.com/1205497 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#588995} [modify] https://crrev.com/2971ab7789a2ac5e8fa5a8d012cd96727cb95619/ash/app_list/views/app_list_view.cc
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c189d8ea5ee7f51ceef7321055715c6fda3ce1a commit 2c189d8ea5ee7f51ceef7321055715c6fda3ce1a Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Sep 07 17:40:09 2018 cros: Change AppList corner behavior 1. Change behavior of AppList corners from animating from round to angular to no longer animating and disappearing offscreen at the top of the screen. 2. Fixed broken unit tests. TBR=oxyflush@google.com (cherry picked from commit 7d17c61cd40a46d78a8a1a09404d707aafcf74dc) Bug: 874200 Change-Id: I0983794bc58542a790b42bc3fcc17b64cc11e1b5 Reviewed-on: https://chromium-review.googlesource.com/1194862 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Original-Commit-Position: refs/heads/master@{#588213} Reviewed-on: https://chromium-review.googlesource.com/1213310 Cr-Commit-Position: refs/branch-heads/3538@{#147} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/2c189d8ea5ee7f51ceef7321055715c6fda3ce1a/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/2c189d8ea5ee7f51ceef7321055715c6fda3ce1a/ash/app_list/views/app_list_view.h [modify] https://crrev.com/2c189d8ea5ee7f51ceef7321055715c6fda3ce1a/ash/app_list/views/contents_view.cc
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d422d00e075d0821483883989e789df4cfd6384f commit d422d00e075d0821483883989e789df4cfd6384f Author: Alex Newcomer <newcomer@chromium.org> Date: Tue Sep 11 17:34:39 2018 cros: Fix AppList bounds issue Fix bug where AppList bounds were 28 px too tall in peeking and closed states. TBR=oxyflush@google.com (cherry picked from commit 2971ab7789a2ac5e8fa5a8d012cd96727cb95619) Bug: 874200 Change-Id: I9b449c9310d946b405bb3b8f0610e5e1018c6872 Reviewed-on: https://chromium-review.googlesource.com/1205497 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Original-Commit-Position: refs/heads/master@{#588995} Reviewed-on: https://chromium-review.googlesource.com/1219898 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#277} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/d422d00e075d0821483883989e789df4cfd6384f/ash/app_list/views/app_list_view.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sgabr...@chromium.org
, Aug 146.5 KB
6.5 KB View Download