New issue
Advanced search Search tips

Issue 874195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Delete the package mask from arm64

Project Member Reported by zentaro@chromium.org, Aug 14

Issue description

Remove the mask in arm64 package.use.mask once it gets removed from the arm one.
 
Labels: -M-70 M-71
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1628ee7bca2d63c29fc4f1313f9bcee5f38dbfcb

commit 1628ee7bca2d63c29fc4f1313f9bcee5f38dbfcb
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Oct 04 07:36:59 2018

Remove package masks for SMB on ARM

- Removes the temporary version based mask from ARM
- Remove the entry from ARM64 so if someone continues working on
  this arch it is in sync with ARM

BUG= chromium:874195 
TEST=emerges

Change-Id: If1064246320f6465483a4d3cd05d902794077c89
Reviewed-on: https://chromium-review.googlesource.com/1259602
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1628ee7bca2d63c29fc4f1313f9bcee5f38dbfcb/profiles/arch/arm/package.use.mask
[modify] https://crrev.com/1628ee7bca2d63c29fc4f1313f9bcee5f38dbfcb/profiles/arch/arm64/package.use.mask

Hi Zentaro,

Curretly I've been maintaining kevin64 overlay, after this change samba's dependencies talloc, tdb started to building and they are failed (arm64 not supported).
As I see Samba still not supports arm64 yet. Shouldn't this be disabled on arm64?
Cc: vapier@chromium.org
As far as I was aware arm64 was not building regardless. Are you saying that prior to this change arm64 built successfully on Kevin?

This was to ensure that when the rest of arm64 is ported that this gets included in that porting process.
Components: OS>Packages
arm64 doesn't have builders yet.  it's "OK" to break it until it does.  people working on getting an active arm64 builder are on the hook for following up.

there is an experimental "kevin64" overlay for building an aarch64 userland.

how you want to prioritize arm64 support is up to you.  if you've got other pressing matters, you can backburner it.
OK - well I can try and build kevin64 at some point. But for reference it's essentially going to be a very similar change as this.

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1042498
Thanks for the comments. Yes, kevin64 overlay is an experimental but we would like to keep it up-to-date.

I was not sure about the proper fix. Maybe if you don't have enough time to look at this, I can pick up this issue and continue it based on your change what you linked.
Status: Fixed (was: Started)

Sign in to add a comment