New issue
Advanced search Search tips

Issue 874189 link

Starred by 1 user
Status: Fixed
Owner:
mcnee@chromium.org
Closed: Aug 15
Cc:
wjmaclean@chromium.org
lfg@chromium.org
mcnee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Guest views should not apply control wheel zoom changes if their embedders wouldn't

Project Member Reported by mcnee@chromium.org, Aug 14 
Chrome Version: 70.0.3522.0

Consider an app window containing a webview. Control wheel zooming has no effect on the content of the window when done outside the webview, but it does when performed inside the webview.

Guest views should not zoom their embedders if their embedders would not respond to zoom changes themselves.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031f9b9b9e2f91fa6798d9766ce0078b423a97a7

commit 031f9b9b9e2f91fa6798d9766ce0078b423a97a7
Author: Kevin McNee <mcnee@chromium.org>
Date: Tue Aug 14 21:04:46 2018

Have a guest view's embedder handle control wheel zoom changes

Currently, a guest view responds to control wheel zoom changes by
zooming the embedder. However, the embedder itself may not respond
to control wheel zoom changes. So a user could zoom an otherwise
non-zoomable embedder by control wheel zooming inside a guest.

We now have the guest view inform the embedder that a control wheel
zoom change has occurred so that the embedder can decide how to handle
it.

Bug:  874189 
Change-Id: Icd49a2590e502bb60b7e3d6d372de3a133e2277f
Reviewed-on: https://chromium-review.googlesource.com/1175006
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583031}
[modify] https://crrev.com/031f9b9b9e2f91fa6798d9766ce0078b423a97a7/components/guest_view/browser/guest_view_base.cc

Comment 2 by mcnee@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment