Bulk moving all M-71 <P-1's to M-72.

Bulk moving <p-1's to the next milestone because we branched to M-73.

This is about the window selector, not the shelf, right? Switching component. Xiaoqian are you the right owner? Thank you! :-)

Err wait, the title says "window selector" but then the description says "overflow menu". And the pieces of spec attached aren't about the shelf's overflow menu at all. Sebastien can you clarify?

See #2, it was a mistake, I wrote the bug too fast while working on overflow as well and called this bug overflow, I modified the title to be accurate but I couldn't modify the description in #0.We are talking about Window selector here, as shown by the spec images.

sgabriel@, can you explain a bit more? What is window selector menu? Which part should be themed like the shelf?

The window selector appears on hover or tap on an app with multiple windows opened.
Currently it shows a simple menu, this is what is suppose to replace that menu.

The part being consistent with the shelf is the dark layer holding all the previews.

FYI, as of version 73.0.3640.0, she window selector is not accessible due to a shelf bug which is tracked in  bug 916261 

I see, it's the window previews that shows up when hovering on a shelf icon. In this case it still belongs to shelf.
(btw: I was originally confused as in the codebase, WindowSelector stands for overview mode, which is quite different here )

Ah ok, thanks for the clarification.

I think we need a better common language ("window selector" could also describe what appears when you hit alt-tab, I think something like "live window previews" or "hover previews" would be clearer?). Screenshots of the bug also help ;-)

Let's call them hover previews. I'll modify the specs to reflect that.
I didn't attach a screenshot at the time because you were in the process of working on it and this was a direct reaction to the implementation under the "show previews of running apps when hovering over the shelf" flag. Current state attached.

Deleted: current state.png 221 KB

	current state.png 221 KB View Download

Moving P3 bugs about hover previews to P2 since this feature is now on the roadmap for the short-medium term.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6187efed3c0fbcdd427a6632d33e34642e005065

commit 6187efed3c0fbcdd427a6632d33e34642e005065
Author: Manu Cornet <manucornet@chromium.org>
Date: Wed Jan 16 17:11:23 2019

CrOS Shelf: Some hover preview fixes

* Give the hover preview the same background color as the shelf (this
  requires a little bit of plumbing to get the value from where it is).
* Set rounded corners for the hover preview as written in the spec.
* Reduce spacing between window previews within the bubble.

Bug: 874186, 874220, 834392
Change-Id: I400e62392482a11092379aa1c2d7e941763c803e
Reviewed-on: https://chromium-review.googlesource.com/c/1411339
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623269}
[modify] https://crrev.com/6187efed3c0fbcdd427a6632d33e34642e005065/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/6187efed3c0fbcdd427a6632d33e34642e005065/ash/shelf/shelf_tooltip_preview_bubble.cc
[modify] https://crrev.com/6187efed3c0fbcdd427a6632d33e34642e005065/ash/shelf/shelf_tooltip_preview_bubble.h
[modify] https://crrev.com/6187efed3c0fbcdd427a6632d33e34642e005065/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/6187efed3c0fbcdd427a6632d33e34642e005065/ash/shelf/shelf_widget.h

Background should now look the same, I still need to make the blur the same, so keeping this open.