New issue
Advanced search Search tips

Issue 874155 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug


Sign in to add a comment

Fuchsia: Implement net.oldhttp and net.http FIDL services in chromium

Project Member Reported by fdegans@chromium.org, Aug 14

Issue description

This is a tracking bug to implement the net.oldhttp and net.http interfaces using the Chromium //net API.
 
Labels: M-70
Blockedon: 875532
Blockedon: 875533
Blockedon: 875534
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7

commit d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed Aug 29 22:48:58 2018

Implement fuchsia net.oldhttp

This adds a service implementing the Fuchsia net.oldhttp FIDL
interface as a discoverable service. This is achieved by making
use of the Chromium //net API, in particular net::URLRequest.

Change-Id: I7f548fff6bcaeb9f039e6d01afa32fe5bb3b552a
Bug: 874155
Test: Coming soon!
Reviewed-on: https://chromium-review.googlesource.com/1152542
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587346}
[modify] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/BUILD.gn
[modify] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/third_party/fuchsia-sdk/BUILD.gn
[add] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/webrunner/net_http/BUILD.gn
[add] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/webrunner/net_http/service/http_service_impl.cc
[add] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/webrunner/net_http/service/http_service_impl.h
[add] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/webrunner/net_http/service/http_service_main.cc
[add] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/webrunner/net_http/service/url_loader_impl.cc
[add] https://crrev.com/d85eb8ed1c068520a6eeae66dd4d2fefe0ea88f7/webrunner/net_http/service/url_loader_impl.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc1c729f31a8758c3335ef9794c9f587d6a7b4ff

commit cc1c729f31a8758c3335ef9794c9f587d6a7b4ff
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Sep 21 18:40:38 2018

Remove Buffer mode from the oldhttp service.

The Buffer mode is being removed from the FIDL definition.

Bug: 874155
Change-Id: If308f2074a35b071f4fa50d087944ece89574142
Reviewed-on: https://chromium-review.googlesource.com/1237135
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593273}
[modify] https://crrev.com/cc1c729f31a8758c3335ef9794c9f587d6a7b4ff/webrunner/net_http/service/url_loader_impl.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2064ef6e278024b363a284e7e497421977d9ea8

commit e2064ef6e278024b363a284e7e497421977d9ea8
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Sep 25 18:06:37 2018

Replace sized_buffer with buffer in the http service.

The sized_buffer mode was renamed to buffer in Garnet. This change
keeps the service implementation in sync. See:
https://fuchsia-review.googlesource.com/c/garnet/+/201201
https://fuchsia-review.googlesource.com/c/garnet/+/201203

Bug: 874155
Change-Id: I74061afd6e92d0397c286391efbd36f02373008c
Reviewed-on: https://chromium-review.googlesource.com/1243569
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594004}
[modify] https://crrev.com/e2064ef6e278024b363a284e7e497421977d9ea8/webrunner/net_http/service/url_loader_impl.cc

Blockedon: 889195
Blockedon: 896884
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3e5b17726b0b78a98c69adc8e55d49939ea8963

commit d3e5b17726b0b78a98c69adc8e55d49939ea8963
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Thu Oct 18 22:17:14 2018

Add tests for the fuchsia.oldhttp service.

This CL adds tests for the fuchsia.oldhttp service Chromium
implementation. These tests ensure the service is capable of sending
URL requests, receiving a response and/or an error code as expected.
The service implementation files have been moved around under a single
directory for consistency.

Bug: 874155
Change-Id: Iae843adc62db054a17125cea10b17771c127b801
Reviewed-on: https://chromium-review.googlesource.com/c/1239627
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600938}
[modify] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/BUILD.gn
[modify] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/net/proxy_resolution/proxy_resolution_service.cc
[modify] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/BUILD.gn
[rename] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/http_service_impl.cc
[rename] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/http_service_impl.h
[rename] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/http_service_main.cc
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/http_service_test_main.cc
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/http_service_unittest.cc
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/redirect-test.html
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/redirect-test.html.mock-http-headers
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/simple.html
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/simple.html.mock-http-headers
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/with-duplicate-headers.html
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/with-duplicate-headers.html.mock-http-headers
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/with-headers.html
[add] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/testdata/with-headers.html.mock-http-headers
[rename] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/url_loader_impl.cc
[rename] https://crrev.com/d3e5b17726b0b78a98c69adc8e55d49939ea8963/webrunner/net_http/url_loader_impl.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/180000818924ebaa0cfabeeddacd04e4187891ba

commit 180000818924ebaa0cfabeeddacd04e4187891ba
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Oct 19 02:55:12 2018

Fix the Fuchsia component build.

The 'http_lib' target was erroneously configured as a component rather
than a source set, which broke the component build.

Bug: 874155
Change-Id: I968b2418891d5a702f408791cd88b3077090f47d
Reviewed-on: https://chromium-review.googlesource.com/c/1290512
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601033}
[modify] https://crrev.com/180000818924ebaa0cfabeeddacd04e4187891ba/webrunner/net_http/BUILD.gn

Blockedon: 898938
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9a52dc6df65902a0364c266f642fef053f061d6

commit c9a52dc6df65902a0364c266f642fef053f061d6
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon Oct 29 20:58:41 2018

[Fuchsia] Package the http service into a CIPD archive.

This adds the http service package to a new CIPD archive.

Bug: 874155
Test: Locally, build still works.
Change-Id: I44937c496a1af342d0bf7f67581cef4c0fb83cb9
Reviewed-on: https://chromium-review.googlesource.com/c/1300674
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603615}
[modify] https://crrev.com/c9a52dc6df65902a0364c266f642fef053f061d6/webrunner/BUILD.gn
[add] https://crrev.com/c9a52dc6df65902a0364c266f642fef053f061d6/webrunner/cipd/http.yaml

Labels: -Pri-1 Pri-2
Status: Assigned (was: Started)
Switching back to Assigned and lowering priority.
The old_http service has been implemented. The new http service implementation is on the backlog.

Sign in to add a comment