cyflee@ could you create a concrete list of metrics we would like to collect throughout the flow (match it with mocks step-by-step)?

reposting list of metrics requests for reference here: https://docs.google.com/presentation/d/1Y_eUXfeexMLQnQQzF5_2IlroxrJm27Qek9-iaG4Y7Po/edit

Updated list of metrics based on new email/google apps default state: https://docs.google.com/presentation/d/1Y_eUXfeexMLQnQQzF5_2IlroxrJm27Qek9-iaG4Y7Po/edit#slide=id.g3fb524a237_0_330

I'm looking into updating our metrics

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/777e77ef67f47da9cdc1f043eb948ef14d7b53d0

commit 777e77ef67f47da9cdc1f043eb948ef14d7b53d0
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Dec 07 19:28:57 2018

Navi: Update email metrics gathering.

This CL adds the missing metric combination as well as factoring out to
make metrics gathering code shareable with the google apps module.

Bug:  874154 
Change-Id: Iba2a10264630185b5de236b58cee7b204f2f3054
Reviewed-on: https://chromium-review.googlesource.com/c/1344998
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614782}
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.html
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/shared/BUILD.gn
[add] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.html
[add] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.js
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/test/data/webui/welcome/email_chooser_test.js
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/chrome/test/data/webui/welcome/test_nux_email_proxy.js
[modify] https://crrev.com/777e77ef67f47da9cdc1f043eb948ef14d7b53d0/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a43806421efcc79e82f0f10babccdd21efdee6

commit c1a43806421efcc79e82f0f10babccdd21efdee6
Author: Hector Carmona <hcarmona@chromium.org>
Date: Sat Dec 08 02:40:40 2018

Navi: Add metrics to Google Apps and make more like Email section.

Bug:  874154 
Change-Id: I8d854e96214eb10fb385870c7cd1259b52e62a63
Reviewed-on: https://chromium-review.googlesource.com/c/1364229
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614927}
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/test/data/webui/welcome/email_chooser_test.js
[add] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/test/data/webui/welcome/module_metrics_test.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
[add] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/chrome/test/data/webui/welcome/test_metrics_proxy.js
[modify] https://crrev.com/c1a43806421efcc79e82f0f10babccdd21efdee6/tools/metrics/histograms/enums.xml

Requesting merge for these 2 CLs that add metrics for the email + google apps modules in navi

This bug requires manual review: There is .grd file changes and we are only 49 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

pls apply appropriate OSs label.

Windows only for M72

hcarmona@ I see this CL requires translation to be done. What is the criticality of this change to go out in M72? Can this wait until 73.0? How safe is this change? 

This CL should not require translation because we're launching in EN-US only
It's critical that we have metrics to determine the success of the launch.
Change is very safe, JS only, and is behind a flag.

Approving for 72.0 per comment 16. 

Branch: 3626 FYI

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce36c4993fd47222005b6cfc1df9620adace06d3

commit ce36c4993fd47222005b6cfc1df9620adace06d3
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon Dec 10 23:55:33 2018

Navi: Update email metrics gathering.

This CL adds the missing metric combination as well as factoring out to
make metrics gathering code shareable with the google apps module.

Bug:  874154 
Change-Id: Iba2a10264630185b5de236b58cee7b204f2f3054
Reviewed-on: https://chromium-review.googlesource.com/c/1344998
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614782}(cherry picked from commit 777e77ef67f47da9cdc1f043eb948ef14d7b53d0)
Reviewed-on: https://chromium-review.googlesource.com/c/1371023
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#243}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.html
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/shared/BUILD.gn
[add] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.html
[add] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.js
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/test/data/webui/welcome/email_chooser_test.js
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/chrome/test/data/webui/welcome/test_nux_email_proxy.js
[modify] https://crrev.com/ce36c4993fd47222005b6cfc1df9620adace06d3/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/174dd8467376c95dccae945eddea39611ac1c4c6

commit 174dd8467376c95dccae945eddea39611ac1c4c6
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon Dec 10 23:57:52 2018

Navi: Add metrics to Google Apps and make more like Email section.

Bug:  874154 
Change-Id: I8d854e96214eb10fb385870c7cd1259b52e62a63
Reviewed-on: https://chromium-review.googlesource.com/c/1364229
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614927}(cherry picked from commit c1a43806421efcc79e82f0f10babccdd21efdee6)
Reviewed-on: https://chromium-review.googlesource.com/c/1371070
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#244}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/test/data/webui/welcome/email_chooser_test.js
[add] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/test/data/webui/welcome/module_metrics_test.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
[add] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/chrome/test/data/webui/welcome/test_metrics_proxy.js
[modify] https://crrev.com/174dd8467376c95dccae945eddea39611ac1c4c6/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b4e11ccbd75e0341413d8ebae3e58298e79128b

commit 2b4e11ccbd75e0341413d8ebae3e58298e79128b
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Dec 13 02:55:38 2018

[Navi] Add missing metrics for remaining pages in onboarding workflow.

Metrics added for:
  - Landing Page
  - Set Default Browser Page
  - Sign In Page
  - Email Interstitial Page

Bug:  874154 
Change-Id: I8c9098a343ec8be9dad3b20ec3b7cdc96660d51e
Reviewed-on: https://chromium-review.googlesource.com/c/1371245
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616181}
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.html
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.js
[add] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial_proxy.html
[add] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial_proxy.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/landing_view.js
[add] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/landing_view_proxy.html
[add] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/landing_view_proxy.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/signin_view.js
[add] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/signin_view_proxy.html
[add] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/browser/resources/welcome/onboarding_welcome/signin_view_proxy.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/test/data/webui/welcome/email_chooser_test.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/chrome/test/data/webui/welcome/test_nux_set_as_default_proxy.js
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2b4e11ccbd75e0341413d8ebae3e58298e79128b/tools/metrics/histograms/histograms.xml

Requesting merge for last CL. This is critical to analyze the success of our feature. Merge is low risk as it's localized to just our feature, changes are only JavaScript so risk of crash is minimal. Entire feature can be disabled via a flag which prevents any of this code from running at all.

approved for M72 branch: 3626 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08

commit c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Dec 13 22:22:26 2018

[Navi] Add missing metrics for remaining pages in onboarding workflow.

Metrics added for:
  - Landing Page
  - Set Default Browser Page
  - Sign In Page
  - Email Interstitial Page

Bug:  874154 
Change-Id: I8c9098a343ec8be9dad3b20ec3b7cdc96660d51e
Reviewed-on: https://chromium-review.googlesource.com/c/1371245
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616181}(cherry picked from commit 2b4e11ccbd75e0341413d8ebae3e58298e79128b)
Reviewed-on: https://chromium-review.googlesource.com/c/1377146
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#344}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.html
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.js
[add] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial_proxy.html
[add] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial_proxy.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/landing_view.js
[add] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/landing_view_proxy.html
[add] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/landing_view_proxy.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/signin_view.js
[add] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/signin_view_proxy.html
[add] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/browser/resources/welcome/onboarding_welcome/signin_view_proxy.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/test/data/webui/welcome/email_chooser_test.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/chrome/test/data/webui/welcome/test_nux_set_as_default_proxy.js
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08/tools/metrics/histograms/histograms.xml

👍

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf0a0749eb3eeaa06f58cbd80341828e46b15003

commit bf0a0749eb3eeaa06f58cbd80341828e46b15003
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Dec 14 01:30:50 2018

Navi: Add field trial entry for NaviOnboarding for variations testing.

Bug:  874154 
Change-Id: Ie3ba33e9cef640b6ef6917b7a475c3ad3636d40a
Reviewed-on: https://chromium-review.googlesource.com/c/1375371
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616548}
[modify] https://crrev.com/bf0a0749eb3eeaa06f58cbd80341828e46b15003/testing/variations/fieldtrial_testing_config.json

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 174dd8467376c95dccae945eddea39611ac1c4c6 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/174dd8467376c95dccae945eddea39611ac1c4c6

Commit: 174dd8467376c95dccae945eddea39611ac1c4c6
Author: hcarmona@chromium.org
Commiter: hcarmona@chromium.org
Date: 2018-12-10 23:57:52 +0000 UTC

Navi: Add metrics to Google Apps and make more like Email section.

Bug:  874154 
Change-Id: I8d854e96214eb10fb385870c7cd1259b52e62a63
Reviewed-on: https://chromium-review.googlesource.com/c/1364229
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614927}(cherry picked from commit c1a43806421efcc79e82f0f10babccdd21efdee6)
Reviewed-on: https://chromium-review.googlesource.com/c/1371070
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#244}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08

Commit: c0a3cfb6e08944259bebbdc30b01ef7a47ec8c08
Author: hcarmona@chromium.org
Commiter: hcarmona@chromium.org
Date: 2018-12-13 22:22:26 +0000 UTC

[Navi] Add missing metrics for remaining pages in onboarding workflow.

Metrics added for:
  - Landing Page
  - Set Default Browser Page
  - Sign In Page
  - Email Interstitial Page

Bug:  874154 
Change-Id: I8c9098a343ec8be9dad3b20ec3b7cdc96660d51e
Reviewed-on: https://chromium-review.googlesource.com/c/1371245
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616181}(cherry picked from commit 2b4e11ccbd75e0341413d8ebae3e58298e79128b)
Reviewed-on: https://chromium-review.googlesource.com/c/1377146
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#344}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision ce36c4993fd47222005b6cfc1df9620adace06d3 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ce36c4993fd47222005b6cfc1df9620adace06d3

Commit: ce36c4993fd47222005b6cfc1df9620adace06d3
Author: hcarmona@chromium.org
Commiter: hcarmona@chromium.org
Date: 2018-12-10 23:55:33 +0000 UTC

Navi: Update email metrics gathering.

This CL adds the missing metric combination as well as factoring out to
make metrics gathering code shareable with the google apps module.

Bug:  874154 
Change-Id: Iba2a10264630185b5de236b58cee7b204f2f3054
Reviewed-on: https://chromium-review.googlesource.com/c/1344998
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614782}(cherry picked from commit 777e77ef67f47da9cdc1f043eb948ef14d7b53d0)
Reviewed-on: https://chromium-review.googlesource.com/c/1371023
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#243}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}