New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment
link

Issue 874153: [Navi] Set up experiment flags structure

Reported by scottchen@chromium.org, Aug 14 Project Member

Issue description

1) figure out what is the best way to set up the finch experiments required for the whole onboarding flow
2) make the onboarding manager actually consume values passed from the flags (instead of using hard-coded values used during development)
3) actually make the finch experiments CLs.
 

Comment 1 by scottchen@chromium.org, Sep 19

Components: UI>Browser>FirstRun

Comment 2 by scottchen@chromium.org, Sep 19

Components: -UI>Browser>WebUI

Comment 3 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ad50af377742356d0a99a3005553f87620661e8

commit 4ad50af377742356d0a99a3005553f87620661e8
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Oct 03 23:57:28 2018

NUX Onboarding: clean up build process.

This CL cleans up the remnants of the NUX Experiments bulid configs. Including:
- removing os_win and google_chrome_branded build flag.
- removing prefs that tracks if the one-off NUX experiments were seen.
- fixing closure compile errors now that it needs to build on non-official bots.

Bug:  874153 
Change-Id: I03c1ed09c54f5ba91944bcb31837e80a0ee1fc74
Reviewed-on: https://chromium-review.googlesource.com/c/1252906
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596432}
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/BUILD.gn
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/webui/welcome/welcome_ui.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/browser/ui/webui/welcome/welcome_ui.h
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/common/pref_names.cc
[modify] https://crrev.com/4ad50af377742356d0a99a3005553f87620661e8/chrome/common/pref_names.h

Comment 4 by bugdroid1@chromium.org, Oct 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05b75d0318f3105ccde3bbce70001a71cd0ea2d

commit f05b75d0318f3105ccde3bbce70001a71cd0ea2d
Author: Greg Thompson <grt@chromium.org>
Date: Thu Oct 04 07:36:23 2018

Revert "NUX Onboarding: clean up build process."

This reverts commit 4ad50af377742356d0a99a3005553f87620661e8.

Reason for revert: Breaks is_chrome_branded builds -- startup_tab_provider_unittest.cc is still referencing members of StandardOnboardingTabsParams that were removed.

Original change's description:
> NUX Onboarding: clean up build process.
> 
> This CL cleans up the remnants of the NUX Experiments bulid configs. Including:
> - removing os_win and google_chrome_branded build flag.
> - removing prefs that tracks if the one-off NUX experiments were seen.
> - fixing closure compile errors now that it needs to build on non-official bots.
> 
> Bug:  874153 
> Change-Id: I03c1ed09c54f5ba91944bcb31837e80a0ee1fc74
> Reviewed-on: https://chromium-review.googlesource.com/c/1252906
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596432}

TBR=sky@chromium.org,scottchen@chromium.org

Change-Id: I643cfa84bb9da07b4e1ebf8a9481d0ac32aeea90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  874153 
Reviewed-on: https://chromium-review.googlesource.com/c/1260128
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596535}
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/BUILD.gn
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/b0a5a4987c1169a46c492e8373f4dbb871482737/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/webui/welcome/welcome_ui.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/browser/ui/webui/welcome/welcome_ui.h
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/common/pref_names.cc
[modify] https://crrev.com/f05b75d0318f3105ccde3bbce70001a71cd0ea2d/chrome/common/pref_names.h

Comment 5 by bugdroid1@chromium.org, Oct 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f68c9b2548a5f1a2462146e1efc36165571c055c

commit f68c9b2548a5f1a2462146e1efc36165571c055c
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Oct 12 02:15:25 2018

Reland "NUX Onboarding: clean up build process."

The original CL 1252906 was reverted due to breaking unit tests for
branded window builds.

This CL fixes that by removing obsolete unit tests. It was testing the
mechanism that conditionally directs users to the chrome://welcome/email
and chrome://welcome/apps experiment URLs, which will no longer be used.

Bug:  874153 
Change-Id: I3b92b53e191606a6f5889cf17b15a570ce566994
Reviewed-on: https://chromium-review.googlesource.com/c/1275294
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599070}
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/BUILD.gn
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/webui/welcome/welcome_ui.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/browser/ui/webui/welcome/welcome_ui.h
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/common/pref_names.cc
[modify] https://crrev.com/f68c9b2548a5f1a2462146e1efc36165571c055c/chrome/common/pref_names.h

Comment 6 by scottchen@chromium.org, Oct 31

Status: Started (was: Available)

Comment 7 by scottchen@chromium.org, Nov 1

Owner: scottchen@chromium.org

Comment 8 by bugdroid1@chromium.org, Nov 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0085824634b4239b6776521f9f4156b25aae6cc9

commit 0085824634b4239b6776521f9f4156b25aae6cc9
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Nov 01 23:40:47 2018

Nux Onboarding: get hard-coded module list from feature params instead.

In this CL, four FeatureParams were added.

These 2 are added for "os_win && google_chrome_build" when
kNuxOnboardingFeature is enabled:

kNuxOnboardingNewUserModules
kNuxOnboardingReturningUserModules

And 2 more are added for when the feature is force-enabled with
kNuxOnboardingForceEnabled on other platforms/non-branded build:

kNuxOnboardingForceEnabledNewUserModules
kNuxOnboardingForceEnabledReturningUserModules

Sample command line to test the changes:

./out/gn/chrome --user-data-dir=/tmp/debug_chrome_1 \
    --enable-features="NuxOnboardingForceEnabled<study" \
    --force-fieldtrials=study/g1 \
    --force-fieldtrial-params=study.g1:new-user-modules/nux-google-apps/returning-user-modules/nux-email

TBR=mpearson@chromium.org

Bug:  874153 
Change-Id: I495e6492ee66ce20ec8bfad8743d20c9c55acf53
Reviewed-on: https://chromium-review.googlesource.com/c/1311659
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604748}
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/ui/webui/welcome/nux/constants.cc
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/ui/webui/welcome/nux/constants.h
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/0085824634b4239b6776521f9f4156b25aae6cc9/chrome/browser/ui/webui/welcome/welcome_ui.cc

Comment 9 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7243c1a8a7400d753aa9dbfd91b8c65f88440414

commit 7243c1a8a7400d753aa9dbfd91b8c65f88440414
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Nov 06 01:33:41 2018

Nux Onboarding: make showing of email-interstitial configurable

Bug:  874153 
Change-Id: Ib83df9d655ed113084d058e846101b8ddb548b52
Reviewed-on: https://chromium-review.googlesource.com/c/1313283
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605560}
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/resources/welcome/onboarding_welcome/signin_view.js
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/ui/webui/welcome/nux/constants.cc
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/ui/webui/welcome/nux/constants.h
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/7243c1a8a7400d753aa9dbfd91b8c65f88440414/chrome/browser/ui/webui/welcome/welcome_ui.cc

Comment 10 by scottchen@google.com, Nov 19

Owner: hcarmona@chromium.org

Comment 11 by hcarmona@chromium.org, Nov 19

Working on getting finch config enabled for canary

Comment 12 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ced80ec7d7cb53f21392f719dbb4cab1ade0785

commit 2ced80ec7d7cb53f21392f719dbb4cab1ade0785
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Nov 29 21:35:01 2018

Navi: populate synthetic trials.

Once a local profile enters a synthetic trial for on-boarding, it will
remain in it forever. This is not a problem because local profiles
should not be running the on-boarding process more than once. If a user
creates a new profile, it will be assigned into a synthetic trial based
on the experiment at the time of onboarding.

Bug:  874153 
Change-Id: I4f3b9aea39e75fd01ae7dabd7895ea8aa00e633a
Reviewed-on: https://chromium-review.googlesource.com/c/1344990
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612364}
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/browser/ui/webui/welcome/nux_helper.cc
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/common/pref_names.cc
[modify] https://crrev.com/2ced80ec7d7cb53f21392f719dbb4cab1ade0785/chrome/common/pref_names.h

Comment 13 by hcarmona@chromium.org, Dec 11

Status: Fixed (was: Started)
We are enabled on canary and have appropriate flags to track experiment results as well as the option to re-arrange modules.

Comment 14 by hcarmona@chromium.org, Dec 14

Status: Started (was: Fixed)
Re-opening, since there was a bug in the experiment config.

The email/app order was flipped in finch. Have CL to fix

Comment 15 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0246530a275302dd5ed3b49ecba02e7cfe7add17

commit 0246530a275302dd5ed3b49ecba02e7cfe7add17
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Dec 14 03:02:32 2018

Navi: Fix mismatch in field trial

Bug:  874153 
Change-Id: I4ce99a2d812bbd5ca30eb9431231470823e33636
Reviewed-on: https://chromium-review.googlesource.com/c/1377359
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616570}
[modify] https://crrev.com/0246530a275302dd5ed3b49ecba02e7cfe7add17/testing/variations/fieldtrial_testing_config.json

Comment 16 by hcarmona@chromium.org, Dec 14

Status: Fixed (was: Started)
We're good for beta ^_^

Sign in to add a comment