For each individual modules, we need to: 1) have a way to let manager specify the "dots" (i.e carousel-y page indicator) 2) fire events for navigation.
And style all steps and views to match mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZc25GfRhYa4H/files/MCHbtQVoQ2HCZVjdAwsp27Un
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec0c24cb6592e09290ee4f88b47dde0f6888e30f commit ec0c24cb6592e09290ee4f88b47dde0f6888e30f Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 02 03:06:33 2018 NUX Onboarding: fix closure annotations. This CL preemptively fixes closure annotations for all NUX-related JS files, there will be a follow-up CL to actually enable closure compiling on these files. Bug: 874151 Change-Id: I67d56d7b0cffc2c8fa8134c03bf748eaaf79c376 Reviewed-on: https://chromium-review.googlesource.com/1256362 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595707} [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.js [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.js [modify] https://crrev.com/ec0c24cb6592e09290ee4f88b47dde0f6888e30f/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/853f9cbb427418bb5192179874b611173264c89f commit 853f9cbb427418bb5192179874b611173264c89f Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Oct 09 03:41:56 2018 Navi: Refactor loadtime data and strings.js includes to i18n_setup.html. Bug: 874151 Change-Id: Ia090d34b96e4353d28c43ac7c7b34ec61e4d2946 Reviewed-on: https://chromium-review.googlesource.com/c/1270008 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#597793} [modify] https://crrev.com/853f9cbb427418bb5192179874b611173264c89f/chrome/browser/browser_resources.grd [modify] https://crrev.com/853f9cbb427418bb5192179874b611173264c89f/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/853f9cbb427418bb5192179874b611173264c89f/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.html [add] https://crrev.com/853f9cbb427418bb5192179874b611173264c89f/chrome/browser/resources/welcome/onboarding_welcome/shared/i18n_setup.html [modify] https://crrev.com/853f9cbb427418bb5192179874b611173264c89f/chrome/browser/ui/webui/welcome/welcome_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d86816262d9e0f674f73efdf4f5ef757cf240540 commit d86816262d9e0f674f73efdf4f5ef757cf240540 Author: Scott Chen <scottchen@chromium.org> Date: Sat Oct 13 01:11:48 2018 NUX Onboarding: rename module paths This CL renames each NUX module's paths so it would be more consistent when importing them (which will be in a follow-up CL). Bug: 874151 Change-Id: Icdd5a6d355d227fa816c0fc437bbc63153e34348 Reviewed-on: https://chromium-review.googlesource.com/c/1255892 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599458} [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.cc [modify] https://crrev.com/d86816262d9e0f674f73efdf4f5ef757cf240540/chrome/common/extensions/api/_api_features.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d8d2efb693c57ff7344384d01f0b29c6a190614 commit 5d8d2efb693c57ff7344384d01f0b29c6a190614 Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 16 20:18:19 2018 NUX Onboarding: use actual nux modules in the onboarding flow. This CL actually makes use of the NUX modules in the onboarding welcome page, instead of the placeholder pages. There will be follow-up CLs to style them to mock. Bug: 874151 Change-Id: Iac750fac5ec744e658770937adab69f0b81f8309 Reviewed-on: https://chromium-review.googlesource.com/c/1256010 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600098} [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/browser_resources.grd [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/landing_view.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/shared/i18n_setup.html [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js [modify] https://crrev.com/5d8d2efb693c57ff7344384d01f0b29c6a190614/chrome/browser/ui/webui/welcome/welcome_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e commit c157cd5e0a87707ba1eaf7571e02f6b109eacf3e Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 16 23:26:58 2018 NUX Onboarding: add signin-view in new-user flow. Bug: 874151 Change-Id: I676131211f7a59e324060d511c1ea462f6950331 Reviewed-on: https://chromium-review.googlesource.com/c/1256017 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#600184} [modify] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/browser_resources.grd [modify] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn [add] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html [add] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/resources/welcome/onboarding_welcome/signin_view.js [modify] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html [modify] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js [modify] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/resources/welcome/onboarding_welcome/welcome_browser_proxy.js [modify] https://crrev.com/c157cd5e0a87707ba1eaf7571e02f6b109eacf3e/chrome/browser/ui/webui/welcome/welcome_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/922247c43d7ad399fcf45bfabec0d83491d66000 commit 922247c43d7ad399fcf45bfabec0d83491d66000 Author: Scott Chen <scottchen@chromium.org> Date: Thu Oct 18 20:54:57 2018 Nux onboarding: fix precedence of styling Make css selectors more specific so that it works both in polymer 1 and 2. Bug: 874151 Change-Id: Ie39ea7a9a919b5d627491ba8b8d301720aa2cc32 Reviewed-on: https://chromium-review.googlesource.com/c/1287266 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600898} [modify] https://crrev.com/922247c43d7ad399fcf45bfabec0d83491d66000/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/922247c43d7ad399fcf45bfabec0d83491d66000/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/922247c43d7ad399fcf45bfabec0d83491d66000/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/922247c43d7ad399fcf45bfabec0d83491d66000/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
Screenshots after CL to style the full-bleed pages:
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/618035d526ad60f2e040ac72a86f5136d45f4796 commit 618035d526ad60f2e040ac72a86f5136d45f4796 Author: Scott Chen <scottchen@chromium.org> Date: Wed Oct 24 00:48:15 2018 Nux Onboarding: touch-up splash pages This CL touches up styling and strings for the full-bleed NUX views, including landing, sign-up, and email-interstitial. Bug: 874151 Change-Id: I29ee2ebea20136702aa0670eae54e5c486b32caa Reviewed-on: https://chromium-review.googlesource.com/c/1294306 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602194} [modify] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/app/onboarding_welcome_strings.grdp [modify] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/browser/resources/welcome/onboarding_welcome/email_interstitial.html [modify] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html [modify] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd [add] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/browser/resources/welcome/onboarding_welcome/shared/splash_pages_shared_css.html [modify] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html [modify] https://crrev.com/618035d526ad60f2e040ac72a86f5136d45f4796/chrome/browser/ui/webui/welcome/welcome_ui.cc
screenshots after asset updates:
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebfdce730067565174c6d1c92213f2a0cc0aca40 commit ebfdce730067565174c6d1c92213f2a0cc0aca40 Author: Scott Chen <scottchen@chromium.org> Date: Fri Oct 26 02:34:26 2018 Nux Onboarding: miscellaneous touch-ups for NUX module. This CL does the following: - optimize png - some styling + string updates to match mocks - fix an edge bug with which if the user reaches NTP and presses the back button, the page briefly flashes an invalid step and go back to NTP again. Bug: 874151 Change-Id: If4ff1b0d9d3bf9ae50e23172a1cee270efdab880 Reviewed-on: https://chromium-review.googlesource.com/c/1295183 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602974} [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/app/onboarding_welcome_strings.grdp [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/browser_resources.grd [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/aol_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/aol_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_2x.png [add] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/email_provider_1x.png [add] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/email_provider_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/google_apps_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/google_apps_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/icloud_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/icloud_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/news_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/news_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/outlook_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/outlook_2x.png [add] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/set_as_default_1x.png [add] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/set_as_default_2x.png [add] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/set_as_default_illustration_1x.png [add] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/set_as_default_illustration_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/yahoo_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/yahoo_2x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/images/youtube_1x.png [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/shared/step_indicator.js [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/resources/welcome/onboarding_welcome/welcome_browser_proxy.js [modify] https://crrev.com/ebfdce730067565174c6d1c92213f2a0cc0aca40/chrome/browser/ui/webui/welcome/welcome_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88c0927e5428d8a310a8f025d86cee6e18b380be commit 88c0927e5428d8a310a8f025d86cee6e18b380be Author: Scott Chen <scottchen@chromium.org> Date: Wed Oct 31 19:47:20 2018 Nux Onboarding: fix brief flash of landing view. Originally the landing page would be visible briefly until modules finished initializing. This CL makes it so the whole view-manager is hidden until steps are ready to be shown. The animation had also been changed to exit immediately, so 1) the users don't see remnant of fade-out of the landing view when they land on //welcome/new-user and //welcome/returning-user directly, 2) prepare the transition to match mock, which doesn't want a fade-out animation for the exiting view. Bug: 874151 Change-Id: Ie0d3853639686b51205bd37cd1dc4035bc96b94d Reviewed-on: https://chromium-review.googlesource.com/c/1306840 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#604367} [modify] https://crrev.com/88c0927e5428d8a310a8f025d86cee6e18b380be/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html [modify] https://crrev.com/88c0927e5428d8a310a8f025d86cee6e18b380be/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
Comment 1 by scottchen@chromium.org
, Aug 14