We need an element to manage the whole onboarding flow, including: 1) routing 2) retrieving finch experiment values 3) navigation interaction between modules 4) transition animations 5) data collection
started, see: https://chromium-review.googlesource.com/c/chromium/src/+/1159347
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a522b89574bec6a82f4c0b4c43043ed1a3bf43 commit 97a522b89574bec6a82f4c0b4c43043ed1a3bf43 Author: Scott Chen <scottchen@chromium.org> Date: Mon Sep 10 22:25:58 2018 WebUI: promote extensions-view-manager to cr-view-manager This CL moves the extension-view-manager to a shared location to be used by other WebUIs. The immediate use case is for a new welcome page; see linked bug for details. Bug: 874146 Change-Id: Ieb168e61cf6ae02e04d624c92a131e9ec38fcdae Reviewed-on: https://chromium-review.googlesource.com/1157241 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590091} [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/browser/resources/md_extensions/BUILD.gn [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/browser/resources/md_extensions/extensions_resources.grd [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/browser/resources/md_extensions/manager.js [delete] https://crrev.com/3fe22318a2be8cb2b058bc53f6896477db39a4fc/chrome/browser/resources/md_extensions/view_manager.html [delete] https://crrev.com/3fe22318a2be8cb2b058bc53f6896477db39a4fc/chrome/browser/resources/md_extensions/view_manager.js [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [rename] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/test/data/webui/cr_elements/cr_view_manager_test.js [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/chrome/test/data/webui/extensions/cr_extensions_browsertest.js [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/ui/webui/resources/cr_elements/BUILD.gn [add] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/ui/webui/resources/cr_elements/cr_view_manager/BUILD.gn [add] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/ui/webui/resources/cr_elements/cr_view_manager/cr_view_manager.html [add] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/ui/webui/resources/cr_elements/cr_view_manager/cr_view_manager.js [modify] https://crrev.com/97a522b89574bec6a82f4c0b4c43043ed1a3bf43/ui/webui/resources/cr_elements_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83748da3ba1de22276477d8b141e3ab2dadd0646 commit 83748da3ba1de22276477d8b141e3ab2dadd0646 Author: Scott Chen <scottchen@chromium.org> Date: Mon Sep 24 19:50:02 2018 NUX Onboarding: add navigation mechanism. Bug: 874146 Change-Id: I2582d5d87c3e8839bdbe1e7939cd656eb76bc4ac Reviewed-on: https://chromium-review.googlesource.com/1237520 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#593645} [modify] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/browser_resources.grd [modify] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html [modify] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/resources/welcome/onboarding_welcome/landing_view.js [add] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.html [add] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js [modify] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html [modify] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js [modify] https://crrev.com/83748da3ba1de22276477d8b141e3ab2dadd0646/chrome/browser/ui/webui/welcome_ui.cc
Screenshots for step-indicators (ignore the WIP set-default page)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6e27eb1610461f0f956e8d92a9502a66350769c commit b6e27eb1610461f0f956e8d92a9502a66350769c Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 23 21:07:08 2018 NUX Onboarding: add step-indicator dots. This CL adds the step-indicator element that would show dots of different colors. The welcome_app element is responsible for setting the total and active index for each module's step-indicator. Bug: 874146 Change-Id: I7813d6d64f57759ceab5ce4b60e59a45db2dc161 Reviewed-on: https://chromium-review.googlesource.com/c/1285309 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602092} [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/shared/BUILD.gn [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/shared/nux_types.js [add] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/shared/step_indicator.html [add] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/shared/step_indicator.js [modify] https://crrev.com/b6e27eb1610461f0f956e8d92a9502a66350769c/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
Comment 1 by scottchen@chromium.org
, Aug 14