New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Navi] Create onboarding "welcome" landing page

Project Member Reported by scottchen@chromium.org, Aug 14

Issue description

Status: Started (was: Available)
Components: UI>Browser>FirstRun
Components: -UI>Browser>WebUI
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c74ed76fe04cb11281b33283073736e23e022317

commit c74ed76fe04cb11281b33283073736e23e022317
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Sep 21 00:23:16 2018

NUX Onboarding: create landing page skeleton.

This CL also adds a helper function to check if the NUX onboarding feature
should be force-enabled on non-win/non-branded builds. This will make
testing and development for the feature much easier. There will be follow-up
CLs to transition all NUX contents to be behind this flag instead of the
build flags.

To test this, add --enable-features=NuxOnboardingForceEnabled

Bug:  874142 
Change-Id: I0c1ae6d396901b0a7cbb1c13fe158b488ff0e14c
Reviewed-on: https://chromium-review.googlesource.com/1229502
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593017}
[modify] https://crrev.com/c74ed76fe04cb11281b33283073736e23e022317/chrome/browser/browser_resources.grd
[add] https://crrev.com/c74ed76fe04cb11281b33283073736e23e022317/chrome/browser/resources/welcome/onboarding_welcome/welcome.html
[modify] https://crrev.com/c74ed76fe04cb11281b33283073736e23e022317/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/c74ed76fe04cb11281b33283073736e23e022317/chrome/browser/ui/webui/welcome/nux_helper.cc
[add] https://crrev.com/c74ed76fe04cb11281b33283073736e23e022317/chrome/browser/ui/webui/welcome/nux_helper.h
[modify] https://crrev.com/c74ed76fe04cb11281b33283073736e23e022317/chrome/browser/ui/webui/welcome_ui.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c55fd65221998d2e2076e28da74ddfa6cddb645

commit 7c55fd65221998d2e2076e28da74ddfa6cddb645
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Sep 21 02:44:49 2018

NUX Onboarding: add basic landing page.

This CL adds a very basic landing page for the NUX onboarding experience.
To test this CL, add --enable-features=NuxOnboardingForceEnabled.

Current progress screenshot: https://imgur.com/a/2OBLbyq

There will be follow-up CLs to make it look more like the mocks, as well as
add other views for NUX.

Bug:  874142 
Change-Id: Ie643def26d657fadfbbf556dd03df7cddf5976cc
Reviewed-on: https://chromium-review.googlesource.com/1235114
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593058}
[modify] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/browser_resources.grd
[add] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html
[add] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/resources/welcome/onboarding_welcome/landing_view.js
[add] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/resources/welcome/onboarding_welcome/welcome.css
[modify] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/resources/welcome/onboarding_welcome/welcome.html
[add] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
[add] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
[modify] https://crrev.com/7c55fd65221998d2e2076e28da74ddfa6cddb645/chrome/browser/ui/webui/welcome_ui.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d64c9fe464680af9b71300ebf4d470d9e0e948

commit d2d64c9fe464680af9b71300ebf4d470d9e0e948
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Sep 24 21:57:14 2018

NUX Onboarding: add sign-in function to landing page.

Bug:  874142 
Change-Id: Ibe260cf8d4f2c8a52808a207e25eb067206dc3ff
Reviewed-on: https://chromium-review.googlesource.com/1239167
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593701}
[modify] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/browser_resources.grd
[modify] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html
[modify] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/resources/welcome/onboarding_welcome/landing_view.js
[modify] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
[add] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/resources/welcome/onboarding_welcome/welcome_browser_proxy.html
[add] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/resources/welcome/onboarding_welcome/welcome_browser_proxy.js
[modify] https://crrev.com/d2d64c9fe464680af9b71300ebf4d470d9e0e948/chrome/browser/ui/webui/welcome_ui.cc

welcome page styling after CL:
Screenshot 2018-10-03 at 3.53.44 PM.png
312 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d92e6ff2ee3294fcfa882916d934664bac17ca1e

commit d92e6ff2ee3294fcfa882916d934664bac17ca1e
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Oct 16 23:54:39 2018

NUX Onboarding: Style welcome page.

Tweaked text and spacing, and added svgs as background.

See screenshot in bug.

Bug:  874142 , 837381 
Change-Id: I9910bc747d8f4e42ee22eaa97e28cdf837c2e36f
Reviewed-on: https://chromium-review.googlesource.com/c/1260303
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600194}
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/browser_resources.grd
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/blue_circle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/green_rectangle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/grey_oval.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/grey_rounded_rectangle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/red_triangle.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/yellow_dots.svg
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/images/background_svgs/yellow_semicircle.svg
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/landing_view.html
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/action_link_style.js
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/action_link_style_css.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/onboarding_background.html
[add] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/shared/onboarding_background.js
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
[modify] https://crrev.com/d92e6ff2ee3294fcfa882916d934664bac17ca1e/chrome/browser/ui/webui/welcome/welcome_ui.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e2352a5599f546a6e712a0d3936134477be44b0

commit 3e2352a5599f546a6e712a0d3936134477be44b0
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Oct 17 01:58:37 2018

Nux Onboarding: Animate landing page background.

This CL adds CSS animation to the background SVGs for the welcome page.

Bug:  874142 
Change-Id: I44dda1285c3118af24cd56d2febd79f87909f870
Reviewed-on: https://chromium-review.googlesource.com/c/1278288
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600239}
[modify] https://crrev.com/3e2352a5599f546a6e712a0d3936134477be44b0/chrome/browser/resources/welcome/onboarding_welcome/shared/onboarding_background.html

Status: Fixed (was: Started)

Sign in to add a comment