New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SurfaceLayer::SetFallbackSurfaceId should not longer force a commit

Project Member Reported by akaba@chromium.org, Aug 14

Issue description

We should remove Commit and Redraw In SurfaceLayer::SetFallbackSurfaceId since Fallback SurfaceIds are no longer needed for SurfaceReferences.
 
This is not true. Fallback should be committed. I guess you mean it a commit should not be forced if the fallback doesn't change?
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44621cb4dba172f1170f79c6e5fd7f0d86598e71

commit 44621cb4dba172f1170f79c6e5fd7f0d86598e71
Author: akaba <akaba@google.com>
Date: Fri Aug 17 01:16:27 2018

Remove Commit and Redraw In SurfaceLayer::SetFallbackSurfaceId

Fallback SurfaceIds are no longer needed for SurfaceReferences thus
this CL removes the fix for  https://crbug.com/827242 


Bug:  874138 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I400fb64a69d4395f7463634db87b957ff7005788
Reviewed-on: https://chromium-review.googlesource.com/1174916
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#583917}
[modify] https://crrev.com/44621cb4dba172f1170f79c6e5fd7f0d86598e71/cc/layers/surface_layer.cc

Description: Show this description
Status: Fixed (was: Assigned)

Sign in to add a comment