New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874133 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Put sbox autocomplete behind a flag

Project Member Reported by newcomer@chromium.org, Aug 14

Issue description

Disabled by default for now.
 
Cc: mmalpani@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01399075c66e171ed4698933f41445e85d311b20

commit 01399075c66e171ed4698933f41445e85d311b20
Author: Daniel Zhang <oxyflush@google.com>
Date: Thu Aug 16 22:28:20 2018

cros: Place AppList autocomplete behind a flag.

More testing of autocomplete behavior is needed.
Placing AppList autocomplete behind a flag and
updating tests to reflect this.

Bug:  874133 
Change-Id: I35f78089045efc65da3a4f524d7e0b613b854705
Reviewed-on: https://chromium-review.googlesource.com/1178577
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#583858}
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/ash/app_list/views/search_box_view.h
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/ash/app_list/views/search_box_view_unittest.cc
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/ash/public/cpp/app_list/app_list_features.cc
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/ash/public/cpp/app_list/app_list_features.h
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/chrome/browser/about_flags.cc
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/01399075c66e171ed4698933f41445e85d311b20/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment