New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874130 link

Starred by 1 user
Status: Fixed
Owner:
kylec...@chromium.org
Closed: Aug 16
Cc:
█ kbr@chromium.org
█ fsam...@chromium.org
jonr...@chromium.org
zmo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 787097



Sign in to add a comment

GpuProcessIntegrationTest.GpuProcess_disable_gpu_and_swiftshader failing with OOP-D

Project Member Reported by kylec...@chromium.org, Aug 14 
The test checks that with hardware acceleration and SwiftShader both disabled we don't launch a GPU process. This isn't true with OOP-D, depending on the platform, so the test fails on Linux and Mac.

- Linux and Mac always launch a GPU process to run the display compositor thread.
- Windows can launch display compositor thread in the browser process due to crbug.com/849639, so the test is still fine.
- Android and Chrome OS can't disable GPU compositing and they don't run the test already.

I'll add a check if 'viz_display_compositor' feature is enabled and if the platform isn't Windows skip the test.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c840686b6474a55b7dd98f01d115c27da867c203

commit c840686b6474a55b7dd98f01d115c27da867c203
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 16 03:41:15 2018

Fix GpuProcess_disable_gpu_and_swiftshader with OOP-D.

With OOP-D we will always launch the GPU process, even if hardware
acceleration and SwiftShader are disabled, in order to run the display
compositor thread. This is true on both Linux and Mac. Windows is
different, due to issues with starting a GPU process we launch the
display compostitor in the browser. Skip the test if we do expect to
launch a GPU process.

Bug:  874130 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0b74011c3cfd04a3c6132943a06d7dc79e9b1d90
Reviewed-on: https://chromium-review.googlesource.com/1174914
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583527}
[modify] https://crrev.com/c840686b6474a55b7dd98f01d115c27da867c203/content/test/gpu/gpu_tests/gpu_process_integration_test.py

Comment 2 by kylec...@chromium.org, Aug 16

Status: Fixed (was: Started)
►

Sign in to add a comment