Link to mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZc25GfRhYa4H/files/MCHtA7U1iMGr62OXhvY2mwqiXvUx16xgHhc This bug is tracking only the win-10 version which has instructions and an outlink to the Win-10 set default dialog.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/532ec2cc34c4dfcec50a15495b5e1b1c872cb765 commit 532ec2cc34c4dfcec50a15495b5e1b1c872cb765 Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 26 21:50:05 2018 WebUI: move existing welcome backend code to a dedicated folder. This is to prepare for a following CL to move all the components/nux/ backend code to chrome/browser/ui/webui/welcome/. The decision to move components/nux/ to chrome/browser/ui/webui/welcome/ is based on the fact that nux is only ever going to be used in webui and exclusively within the welcome flow. Bug: 874122 Change-Id: I873047c06dc76f14c4d9affb5c3829dc0f4b5e18 Reviewed-on: https://chromium-review.googlesource.com/1229333 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594486} [modify] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_handler.cc [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_handler.h [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_ui.cc [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_ui.h [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_win10_handler.cc [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_win10_handler.h [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_win10_ui.cc [rename] https://crrev.com/532ec2cc34c4dfcec50a15495b5e1b1c872cb765/chrome/browser/ui/webui/welcome/welcome_win10_ui.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea61398177d8de61681325395011610acfd3ad57 commit ea61398177d8de61681325395011610acfd3ad57 Author: Scott Chen <scottchen@chromium.org> Date: Thu Sep 27 05:27:49 2018 NUX: Move NUX backend code to chrome/browser/ui/webui/welcome Move NUX backend handlers and string resources to a chrome/ directory. There will be a follow-up CL to move the frontend resources to the same directory. This is to make it possible to reuse chrome/ code for NUX handlers. Bug: 874122 Change-Id: Id9a5fdd0a1ea88c4027139b66aaade0b120b4904 Reviewed-on: https://chromium-review.googlesource.com/1232399 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594599} [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/app/OWNERS [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/app/generated_resources.grd [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/app/nux_strings.grdp [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/startup/startup_tab_provider.cc [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/startup/startup_tab_provider_unittest.cc [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_bubble_view.h [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_dialog_browsertest.cc [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/BUILD.gn [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/DEPS [add] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/OWNERS [add] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/README [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/constants.cc [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/constants.h [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/email_handler.cc [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/email_handler.h [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.cc [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.h [rename] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/nux/show_promo_delegate.h [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/chrome/browser/ui/webui/welcome/welcome_ui.cc [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/components/OWNERS [modify] https://crrev.com/ea61398177d8de61681325395011610acfd3ad57/components/components_strings.grd [delete] https://crrev.com/97d07c076a486eff7701a2d0aa866f454f9a76dc/components/nux/README [delete] https://crrev.com/97d07c076a486eff7701a2d0aa866f454f9a76dc/components/nux_google_apps_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b553ee7cf218e38f7b747b8344878b7a44f6fe7c commit b553ee7cf218e38f7b747b8344878b7a44f6fe7c Author: Keishi Hattori <keishi@chromium.org> Date: Thu Sep 27 06:25:23 2018 Revert "NUX: Move NUX backend code to chrome/browser/ui/webui/welcome" This reverts commit ea61398177d8de61681325395011610acfd3ad57. Reason for revert: Broke Google Chrome Win build https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/37835 Original change's description: > NUX: Move NUX backend code to chrome/browser/ui/webui/welcome > > Move NUX backend handlers and string resources to a chrome/ directory. There > will be a follow-up CL to move the frontend resources to the same directory. > > This is to make it possible to reuse chrome/ code for NUX handlers. > > Bug: 874122 > Change-Id: Id9a5fdd0a1ea88c4027139b66aaade0b120b4904 > Reviewed-on: https://chromium-review.googlesource.com/1232399 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594599} TBR=sky@chromium.org,dpapad@chromium.org,hcarmona@chromium.org,scottchen@chromium.org Change-Id: Ic7744af7c6de8a4508b45441cac030679e04cf26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874122 Reviewed-on: https://chromium-review.googlesource.com/1248142 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594608} [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/app/OWNERS [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/app/generated_resources.grd [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/browser/ui/startup/startup_tab_provider.cc [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/browser/ui/startup/startup_tab_provider_unittest.cc [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_bubble_view.h [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_dialog_browsertest.cc [delete] https://crrev.com/7a8eebd5b8eed8b459c5a82d0573e1ccf3ac87c1/chrome/browser/ui/webui/welcome/nux/OWNERS [delete] https://crrev.com/7a8eebd5b8eed8b459c5a82d0573e1ccf3ac87c1/chrome/browser/ui/webui/welcome/nux/README [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/chrome/browser/ui/webui/welcome/welcome_ui.cc [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/OWNERS [modify] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/components_strings.grd [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/BUILD.gn [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/DEPS [add] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/README [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/constants.cc [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/constants.h [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/email/email_handler.cc [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/email/email_handler.h [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/google_apps/google_apps_handler.cc [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/google_apps/google_apps_handler.h [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/set_as_default/set_as_default_handler.cc [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/set_as_default/set_as_default_handler.h [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux/show_promo_delegate.h [rename] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux_email_strings.grdp [add] https://crrev.com/b553ee7cf218e38f7b747b8344878b7a44f6fe7c/components/nux_google_apps_strings.grdp
Thanks for the revert, latest Win/Win-64 builds are now compiling on official.desktop.continuous builder as well. Link to the builder: Win: https://goto.google.com/qwrfv Win64: https://goto.google.com/knygr
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7 commit 97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7 Author: Scott Chen <scottchen@chromium.org> Date: Thu Sep 27 22:31:46 2018 Reland "NUX: Move NUX backend code to chrome/browser/ui/webui/welcome" Original CL got reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1248142 Bug: 874122 Change-Id: I547e4c209ec35c6a0a19c67d6194663c1bf3e604 Reviewed-on: https://chromium-review.googlesource.com/1249908 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594898} [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/app/OWNERS [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/app/generated_resources.grd [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/app/nux_strings.grdp [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/startup/startup_tab_provider.cc [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/startup/startup_tab_provider_unittest.cc [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_bubble_view.h [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_dialog_browsertest.cc [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/BUILD.gn [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/DEPS [add] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/OWNERS [add] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/README [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/constants.cc [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/constants.h [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/email_handler.cc [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/email_handler.h [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.cc [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.h [rename] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux/show_promo_delegate.h [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/nux_helper.cc [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/chrome/browser/ui/webui/welcome/welcome_ui.cc [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/components/OWNERS [modify] https://crrev.com/97a515a89b52e8e2d1344324b8ce8ccd7ca26ad7/components/components_strings.grd [delete] https://crrev.com/6bd3c0b7724dfdea4b2fd80f8b77b9cbc75c6191/components/nux/README [delete] https://crrev.com/6bd3c0b7724dfdea4b2fd80f8b77b9cbc75c6191/components/nux_google_apps_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b635aaa76fdca520581cee589d1fb635a550347 commit 8b635aaa76fdca520581cee589d1fb635a550347 Author: Scott Chen <scottchen@chromium.org> Date: Fri Sep 28 23:10:12 2018 NUX: Move NUX frontend code to chrome/browser/resources/welcome Bug: 874122 Change-Id: I99b1feb5cdbd6e7aa5b3ad640567cc54b93c66b3 Reviewed-on: https://chromium-review.googlesource.com/1232879 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595246} [modify] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/browser_resources.grd [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/OWNERS [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/aol_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/aol_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_24dp_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_24dp_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_24dp_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_24dp_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/icloud_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/icloud_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/maps_24dp_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/maps_24dp_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/news_24dp_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/news_24dp_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/outlook_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/outlook_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/translate_24dp_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/translate_24dp_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/yahoo_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/yahoo_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/youtube_24dp_1x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/images/youtube_24dp_2x.png [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.html [rename] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.js [modify] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/ui/webui/welcome/nux/BUILD.gn [modify] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.cc [modify] https://crrev.com/8b635aaa76fdca520581cee589d1fb635a550347/components/resources/components_resources.grd [delete] https://crrev.com/c450c3c9989054be1ec869db5955017e8d7a05bd/components/resources/nux_email.grdp [delete] https://crrev.com/c450c3c9989054be1ec869db5955017e8d7a05bd/components/resources/nux_google_apps.grdp [delete] https://crrev.com/c450c3c9989054be1ec869db5955017e8d7a05bd/components/resources/nux_set_as_default.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c commit 5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 02 01:53:10 2018 NUX Default: add set-as-default functionality This adds the back-end functionality of setting default for the NUX set-default module, by subclassing a very similar handler from Settings. There will be follow-up CLs to match front-end with mock. Bug: 874122 Change-Id: I2e54ed7846e036cf48f4d6b22f2a7b867d65baa6 Reviewed-on: https://chromium-review.googlesource.com/1222914 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595694} [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.js [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/webui/settings/settings_default_browser_handler.cc [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/webui/settings/settings_default_browser_handler.h [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/webui/welcome/nux/BUILD.gn [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.cc [modify] https://crrev.com/5b1d0a1fc8ebba98fe0f33470fedf0bc2fadcd4c/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.h
repurposing bug to track both win10 and non-win10. They'll be the same page except for win10 the button will have an outlink icon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/395516be219e7d31767e0ba47a5ac5c9f510c1ff commit 395516be219e7d31767e0ba47a5ac5c9f510c1ff Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 23 00:05:48 2018 NUX Onboarding: add some strings Replacing placeholder strings, and move all the add-string calls to under one function. also fixes a path bug for apps/ -> google_apps/ introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1285210 Bug: 874122 Change-Id: Ibd7940c6de71e3a3befc1c5342f6f6097e37de6e Reviewed-on: https://chromium-review.googlesource.com/c/1285325 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#601791} [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/app/OWNERS [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/app/generated_resources.grd [delete] https://crrev.com/b0f2b8367cee08dee6f6f7c62c56c7e462877ca1/chrome/app/nux_strings.grdp [add] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/app/onboarding_welcome_strings.grdp [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/resources/welcome/onboarding_welcome/signin_view.html [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/395516be219e7d31767e0ba47a5ac5c9f510c1ff/chrome/browser/ui/webui/welcome/welcome_ui.cc
screenshots after styling:
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55b998d61e32c2ceb1c0552c757d1471c9b54319 commit 55b998d61e32c2ceb1c0552c757d1471c9b54319 Author: Scott Chen <scottchen@chromium.org> Date: Thu Oct 25 22:18:58 2018 Nux Onboarding: don't show set-default step if already default or not allowed. This CL makes the welcome_app check if the browser can be set as default, and hold off on initializing modules until we find out. Bug: 874122 , 874255 Change-Id: I42e8427a200c717c2eacea04ad9932d15e65caba Reviewed-on: https://chromium-review.googlesource.com/c/1297283 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602896} [modify] https://crrev.com/55b998d61e32c2ceb1c0552c757d1471c9b54319/chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn [modify] https://crrev.com/55b998d61e32c2ceb1c0552c757d1471c9b54319/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js [modify] https://crrev.com/55b998d61e32c2ceb1c0552c757d1471c9b54319/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default_proxy.js [modify] https://crrev.com/55b998d61e32c2ceb1c0552c757d1471c9b54319/chrome/browser/resources/welcome/onboarding_welcome/shared/nux_types.js [modify] https://crrev.com/55b998d61e32c2ceb1c0552c757d1471c9b54319/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html [modify] https://crrev.com/55b998d61e32c2ceb1c0552c757d1471c9b54319/chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8414881fbb58c9734d4e351d8dcc33101879cfc commit e8414881fbb58c9734d4e351d8dcc33101879cfc Author: Scott Chen <scottchen@chromium.org> Date: Tue Oct 30 03:14:35 2018 Nux Onboarding: Add icon for set-default button for win-10 Bug: 874122 Change-Id: Ic25e7cf5b0c2d37af4d9ba2af311f9ce0c12e08b Reviewed-on: https://chromium-review.googlesource.com/c/1298616 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#603767} [modify] https://crrev.com/e8414881fbb58c9734d4e351d8dcc33101879cfc/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd [modify] https://crrev.com/e8414881fbb58c9734d4e351d8dcc33101879cfc/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn [modify] https://crrev.com/e8414881fbb58c9734d4e351d8dcc33101879cfc/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.html [modify] https://crrev.com/e8414881fbb58c9734d4e351d8dcc33101879cfc/chrome/browser/resources/welcome/onboarding_welcome/set_as_default/nux_set_as_default.js [modify] https://crrev.com/e8414881fbb58c9734d4e351d8dcc33101879cfc/chrome/browser/ui/webui/welcome/welcome_ui.cc
Comment 1 by scottchen@chromium.org
, Sep 19