New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874121 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

bugdroid should ignore suddenly discovered CLs which have been **merged** long time ago.

Project Member Reported by vapier@chromium.org, Aug 14

Issue description

suddenly seeing new posts on 5+ year old bugs like:
    https://crbug.com/212327#c41  
because is_private flag was unset, Bugdroid thinks that's a new CL that has just been merged. Instead, bugdroid should ignore CLs which have been merged more than say 1 month ago.
 
Cc: moragues@chromium.org jwer...@chromium.org dgarr...@chromium.org paulhsia@chromium.org jclinton@chromium.org
no idea who owns bugdroid, but adding a few CrOS people so they're aware
Status: Untriaged (was: Unconfirmed)
Marking "untriaged" for the DevX trooper to notice. IIRC, bugdroid is owned by DevX team.
It's NOT catching up on old missed annotations. These are CLs that were already posted to the bug.
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
There appears to be some sort of administrative update going on.

In particular, I noticed this CL:
    https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/233070

There's a brand new update on that CL that says "Unset private".
That change seems to have triggered an update to  bug 438004 .


Summary: bugdroid updates old bugs when merged CLs are updated (was: bugdroid is updating bugs from 5+ years ago)
ok, this is an old bug bugdroid has had but I think we've just lived with. if you post a comment or change private status on a CL that's already been merged, bugdroid will generate another email.

the current stream is because old merged CLs that were marked private have been made public. so the stream will die out again.
This is also causing all of the old CLs to show up under "Recently
closed", which is a nuisance.

Owner: ----
Status: Available (was: Assigned)
Summary: bugdroid should ignore suddenly discovered CLs which have been **merged** long time ago. (was: bugdroid updates old bugs when merged CLs are updated)
Sorry, neither I nor Mike realized bugdroid will spam everyone. Unfortunately, I was away for 2 hours while script ran on my machine, so I couldn't stop it in time. By now, all emails have been sent.

I'll re-purpose this bug to ask for budgroid to avoid sending emails if CL has been merged <<long time ago, regardless of new updates.
Description: Show this description
Cc: jparent@chromium.org
+jparent@ who's taking care of bugdroid instead of agable@ ?

Also, do you know the best component for this?
Cc: -paulhsia@chromium.org -jwer...@chromium.org -moragues@chromium.org
Labels: -Pri-1 -DevX-Troopers Pri-2
downgrading priority since we understand the source of the issue

also dropping troopers/sheriffs since they don't need to monitor this
Components: -Infra Infra>Codereview
Status: Untriaged (was: Available)
I'm not sure what component bugdroid bugs should be filed under, so my wild guess is Infra>Codereview . Please re-triage appropriately.
Status: Available (was: Untriaged)
I think this is a reasonable component. The issue has reached the right team at least. Long term we should fix this by replacing bugdroid, which we already want to do. TBD on when that can happen.

For now just leaving this available for future prioritization but if it becomes a larger issue we can look at addressing before bugdroid replacement.

Sign in to add a comment