Link to mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZc25GfRhYa4H/files/MCHtA7U1iMGr62OXhvY2mwqiXZK4jKbHVIU
Link to mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZc25GfRhYa4H/files/MCHtA7U1iMGr62OXhvY2mwqi46HlmQZPg8w
Updated mock/redlines: http://gallery/projects/MCHbtQVoQ2HCZc25GfRhYa4H/files/MCHtA7U1iMGr67fEYjQDLJzVH2mOz-hghdM
After chat w/ namratakannan@ we'll be matching the mocks for email
Screenshot for https://crrev.com/c/1226464 This does not match mocks everywhere, but matches the styling of the list
Screenshot for https://crrev.com/c/1246153 This adds higher resolution icons.
Screenshot for https://crrev.com/c/1247422 This aligns content outside the chooser and adds correct icon for google apps.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff commit 10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Oct 02 23:58:40 2018 Navi: Update Google Apps chooser to more closely match mocks. Followup CLs will address other visual issues to avoid over-complicating this CL Bug: 874118 Change-Id: I709fa1165e11444899f1efa5cf23270a1fb2ae6b Reviewed-on: https://chromium-review.googlesource.com/c/1226464 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596053} [modify] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/browser_resources.grd [modify] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [modify] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [modify] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [add] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html [modify] https://crrev.com/10cc2033a7afeaf0b384dc4c5a7e81bbaa8edbff/chrome/browser/ui/webui/welcome/welcome_ui.cc
Screenshot for changes in https://crrev.com/c/1258606
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6 commit dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6 Author: Hector Carmona <hcarmona@chromium.org> Date: Wed Oct 03 17:26:56 2018 Navi: Update NUX Google Apps Icons to be higher resolution. Bug: 874118 Change-Id: Id5e57c2667e1b7c1b8f11a132a51c1ecc377a444 Reviewed-on: https://chromium-review.googlesource.com/1246153 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#596268} [modify] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/browser_resources.grd [rename] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_24dp_1x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_2x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_24dp_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/gmail_24dp_2x.png [rename] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/maps_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/maps_24dp_1x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/maps_2x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/news_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/news_24dp_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/news_24dp_2x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/news_2x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/translate_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/translate_24dp_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/translate_24dp_2x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/translate_2x.png [rename] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/youtube_1x.png [delete] https://crrev.com/f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf/chrome/browser/resources/welcome/onboarding_welcome/images/youtube_24dp_1x.png [add] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/resources/welcome/onboarding_welcome/images/youtube_2x.png [modify] https://crrev.com/dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d385e20f394c56a28715b7720401d3172cab4d04 commit d385e20f394c56a28715b7720401d3172cab4d04 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Oct 04 18:46:57 2018 Navi: Update Google Apps Experiment to match mocks. Changes in this CL: - Update strings to match - Add main icon to match - Center text instead of align left See screenshot in bug. Remaining work: - Get list of apps from loadtime data - Update skip/next labels Bug: 874118 Change-Id: I11aa47ca4b819ba77b50eef994983ddc72a7028e Reviewed-on: https://chromium-review.googlesource.com/c/1247422 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#596781} [modify] https://crrev.com/d385e20f394c56a28715b7720401d3172cab4d04/chrome/app/nux_strings.grdp [modify] https://crrev.com/d385e20f394c56a28715b7720401d3172cab4d04/chrome/browser/browser_resources.grd [modify] https://crrev.com/d385e20f394c56a28715b7720401d3172cab4d04/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [add] https://crrev.com/d385e20f394c56a28715b7720401d3172cab4d04/chrome/browser/resources/welcome/onboarding_welcome/images/google_apps_1x.png [add] https://crrev.com/d385e20f394c56a28715b7720401d3172cab4d04/chrome/browser/resources/welcome/onboarding_welcome/images/google_apps_2x.png [modify] https://crrev.com/d385e20f394c56a28715b7720401d3172cab4d04/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c2b696d8edd835d2562944b82cbabf163ba7be4 commit 9c2b696d8edd835d2562944b82cbabf163ba7be4 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Oct 04 21:28:24 2018 Navi: Update Google Apps + Email to match feedback from UX in person. Minor tweaks to font face, font weight and spacing. Bug: 874118 Change-Id: Ibe968ddcc5ac3ffc6462c0981286db695c5888f6 Reviewed-on: https://chromium-review.googlesource.com/c/1258606 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596859} [modify] https://crrev.com/9c2b696d8edd835d2562944b82cbabf163ba7be4/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html [modify] https://crrev.com/9c2b696d8edd835d2562944b82cbabf163ba7be4/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
Screenshots for https://crrev.com/c/1266212
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58ff41863cbc580305dfb803f01c36b2a9e0349d commit 58ff41863cbc580305dfb803f01c36b2a9e0349d Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Oct 09 19:12:14 2018 Navi: Match updated mocks by adding a background around icons. Bug: 874118 Change-Id: I1fe2dd50473e32a0d0f5839054ef9a7394eb90e0 Reviewed-on: https://chromium-review.googlesource.com/c/1266212 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#598028} [modify] https://crrev.com/58ff41863cbc580305dfb803f01c36b2a9e0349d/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/58ff41863cbc580305dfb803f01c36b2a9e0349d/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [modify] https://crrev.com/58ff41863cbc580305dfb803f01c36b2a9e0349d/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
Last CL should match mocks now. Closing this issue.
Comment 1 by scottchen@chromium.org
, Aug 14