New issue
Advanced search Search tips

Issue 874112 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 20
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Retire CFI-icall buildbot

Project Member Reported by vtsyrklevich@chromium.org, Aug 14

Issue description

It's no longer required because cfi-icall is now enabled on the normal Linux CFI bots.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/48ebe7c7e93d140e1746c034fbf39d2480bd34f0

commit 48ebe7c7e93d140e1746c034fbf39d2480bd34f0
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Tue Aug 14 20:38:04 2018

CFI: Delete icall buildbot

cfi-icall is now enabled on all of the CFI bots so a separate bot is no
longer required.

Bug:  874112 
Change-Id: Ic69447c6c5589988be2a8ef82ab9980aaf680ef1
Reviewed-on: https://chromium-review.googlesource.com/1174866
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>

[modify] https://crrev.com/48ebe7c7e93d140e1746c034fbf39d2480bd34f0/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py
[modify] https://crrev.com/48ebe7c7e93d140e1746c034fbf39d2480bd34f0/masters/master.chromium.clang/builders.pyl

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4c89d9749a25b77d61b1fd8c1088ee6d5450f1

commit bf4c89d9749a25b77d61b1fd8c1088ee6d5450f1
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Wed Aug 15 18:52:07 2018

CFI: Delete icall buildbot

cfi-icall is now enabled on all of the CFI bots so a separate bot is no
longer required.

Bug:  874112 
Change-Id: I4d3b066c8622e03f1085d06a3ea1c638e22c960e
Reviewed-on: https://chromium-review.googlesource.com/1174912
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583342}
[modify] https://crrev.com/bf4c89d9749a25b77d61b1fd8c1088ee6d5450f1/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/bf4c89d9749a25b77d61b1fd8c1088ee6d5450f1/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/bf4c89d9749a25b77d61b1fd8c1088ee6d5450f1/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/bf4c89d9749a25b77d61b1fd8c1088ee6d5450f1/tools/mb/mb_config.pyl

Status: Verified (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b68c0dd34fd25d213114960bcecbfaa6fb6448a

commit 1b68c0dd34fd25d213114960bcecbfaa6fb6448a
Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Date: Fri Aug 24 07:34:30 2018

Finish deleting cfi-icall bot configuration

I missed deleting these unnecessary entries in
https://crrev.com/c/1174912 The cfi-icall bot has been retired and we do
not need to specify cfi_icall anymore as it is now enabled by
is_cfi=true on Linux.

Bug:  874112 
Change-Id: I90b525714a2ce39eceb0c0d0bf06429b83721f4c
Reviewed-on: https://chromium-review.googlesource.com/1184166
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585743}
[modify] https://crrev.com/1b68c0dd34fd25d213114960bcecbfaa6fb6448a/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/1b68c0dd34fd25d213114960bcecbfaa6fb6448a/tools/mb/mb_config.pyl

Sign in to add a comment