New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874109 link

Starred by 3 users
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Aug 14
Cc:
█ kbr@chromium.org
kmarshall@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug



Sign in to add a comment

|git cl presubmit| failure: Unknown bot name "Android N5 Swarm" on waterfall "chromium.swarm"

Project Member Reported by lukasza@chromium.org, Aug 14 
|git cl presubmit| reports the following failure at ToT:

generate_buildbot_json (0.36s) failed
Traceback (most recent call last):
  File "generate_buildbot_json.py", line 886, in <module>
    sys.exit(generator.main(sys.argv[1:]))
  File "generate_buildbot_json.py", line 879, in main
    self.check_consistency()
  File "generate_buildbot_json.py", line 855, in check_consistency
    self.check_input_file_consistency() # pragma: no cover
  File "generate_buildbot_json.py", line 777, in check_input_file_consistency
    raise self.unknown_bot(bot_name, waterfall['name'])
__main__.BBGenErr: Unknown bot name "Android N5 Swarm" on waterfall "chromium.swarm"


This seems to be caused by r582807 by jbudorick@ which removed "Android N5 Swarm" and "Android N5X Swarm" from infra/config/global/luci-milo.cfg, but didn't touch testing/buildbot/waterfall.pyl which still references (no longer existing?) "Android N5 Swarm" and "Android N5X Swarm".

Comment 1 by lukasza@chromium.org, Aug 14

Cc: dpranke@chromium.org
Components: Infra

Comment 2 by lukasza@chromium.org, Aug 14

Summary: |git cl presubmit| failure: Unknown bot name "Android N5 Swarm" on waterfall "chromium.swarm" (was: |git cl presubmit| failure: )

Comment 3 by lukasza@chromium.org, Aug 14 

This issue is (softly?) blocking submitting of https://crrev.com/c/1174855 through CQ.

Comment 4 by kmarshall@chromium.org, Aug 14

Cc: kmarshall@chromium.org
also seeing this error

Comment 5 by jbudorick@chromium.org, Aug 14

Status: Started (was: Assigned)
fun with that presubmit.

Comment 6 by sergeybe...@chromium.org, Aug 14

Components: -Infra Infra>Client>Chrome
Labels: OS-Android

Comment 7 by mmenke@chromium.org, Aug 14

Labels: -Pri-1 Pri-0
Think this is more accurately a P-0 (Blocks uploading CLs [can be overridden], blocks submitting via CQ [presubmit can be bypassed, but doesn't seem like a good idea)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c12abd14b4753b1fdc97aa05b3dd83ce9c8ab99a

commit c12abd14b4753b1fdc97aa05b3dd83ce9c8ab99a
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Aug 14 19:37:43 2018

Read luci-milo-dev.cfg for //testing/buildbot presubmits.

Bug:  874109 
Change-Id: Id969b6a28a93e2aa595efcabf32666cae95fa46c
Reviewed-on: https://chromium-review.googlesource.com/1174964
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582997}
[modify] https://crrev.com/c12abd14b4753b1fdc97aa05b3dd83ce9c8ab99a/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/c12abd14b4753b1fdc97aa05b3dd83ce9c8ab99a/testing/buildbot/generate_buildbot_json_unittest.py

Comment 10 by cduvall@chromium.org, Aug 14 

Issue 874182 has been merged into this issue.

Comment 11 by jbudorick@chromium.org, Aug 14

Status: Fixed (was: Started)
►

Sign in to add a comment