New issue
Advanced search Search tips

Issue 874102 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Aug 14
Cc:
lpalmaro@chromium.org
dtseng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox sounds (earcons) should not pan when the internal speaker is active

Project Member Reported by dtseng@chromium.org, Aug 14 
ChromeVox has a feature wherein the sounds that give additional feedback to users shifts to some degree to the left or right speaker based on the location of the item on-screen.

This attenuates the volume overall (e.g. something far left will be a quiet sound coming from the left speaker).

This impacts the usefulness of the sounds themselves.

While on internal speakers especially, we want to be smarter and stop panning.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc

commit cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc
Author: David Tseng <dtseng@chromium.org>
Date: Tue Aug 14 22:32:50 2018

Do not pan when audio is through internal speakers

Bug:  874102 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I64ae721146a6ac631800bd0bbd1ca6cca9f522f8
Reviewed-on: https://chromium-review.googlesource.com/1172741
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583060}
[modify] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/earcon_engine.js
[modify] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js
[modify] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2
[modify] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py
[modify] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/extensions/browser/api/audio/audio_api.h
[modify] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/extensions/common/api/_permission_features.json
[add] https://crrev.com/cd715fd3f0075cc0df5f914ed8db7d8e173e9ddc/third_party/closure_compiler/externs/audio.js

Comment 2 by dtseng@chromium.org, Aug 14

Status: Fixed (was: Started)
►

Sign in to add a comment