mash: Ctrl-Shift-N opens 2 incognito windows |
|||
Issue descriptionToT on linux-chromeos and on device --enable-features=Mash or --enable-features=SingleProcessMash Hit Ctrl-Shift-N. Two incognito windows open. You might need to have a browser window already open. Maybe accelerators are not being consumed, so it's going through both the browser shortcut handler and the ash shortcut handler?
,
Aug 14
s/Verifying/Verified in comment above.
,
Aug 27
I see this with SingleProcessMash for Ctrl-Shift-N and for Ctrl-T.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7bb5dba03f7bd63986c20ce80dbd0f8d18ae7e7 commit e7bb5dba03f7bd63986c20ce80dbd0f8d18ae7e7 Author: James Cook <jamescook@chromium.org> Date: Fri Aug 31 21:41:56 2018 chromeos: Fix Ctrl-T and Ctrl-N on SingleProcessMash These keyboard shortcuts trigger focus changes that cause InputMethodMus to ack all in-flight keystrokes as unhandled. This causes ash to try to process the keystroke as an accelerator, resulting in the new-tab command running twice. Instead, ack the key events as handled during focus change. Bug: 874098 Test: updated aura_unittests Change-Id: Idda91cbcc7f5d9ad328f7bfb7d6dc0367d85817d Reviewed-on: https://chromium-review.googlesource.com/1195085 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#588178} [modify] https://crrev.com/e7bb5dba03f7bd63986c20ce80dbd0f8d18ae7e7/ui/aura/mus/input_method_mus.cc [modify] https://crrev.com/e7bb5dba03f7bd63986c20ce80dbd0f8d18ae7e7/ui/aura/mus/input_method_mus.h [modify] https://crrev.com/e7bb5dba03f7bd63986c20ce80dbd0f8d18ae7e7/ui/aura/mus/input_method_mus_unittest.cc
,
Aug 31
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rcui@chromium.org
, Aug 14