New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove feature flag for the OneGoogleBar on the Local NTP

Project Member Reported by kmilka@chromium.org, Aug 14

Issue description

Remove the flag as it is enabled by default and work is mostly complete.
 
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: -Type-Bug Type-Task
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/651a683190d2a06681c50f00da755819b4543bdf

commit 651a683190d2a06681c50f00da755819b4543bdf
Author: Kyle Milka <kmilka@chromium.org>
Date: Thu Aug 16 17:16:42 2018

[NTP] Remove flag for the OGB on the Local NTP

As the feature is enabled by default the flag is no longer
necessary. The api override url is now never used and is also
removed.

Bug:  874095 
Change-Id: I82a102ba9935b8ab25fa8a986aab9741c8ac8670
Reviewed-on: https://chromium-review.googlesource.com/1174911
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583706}
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/about_flags.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/search/one_google_bar/one_google_bar_loader_impl.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/search/one_google_bar/one_google_bar_loader_impl.h
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/search/one_google_bar/one_google_bar_service_factory.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/browser/ui/search/local_ntp_one_google_bar_browsertest.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/common/chrome_features.cc
[modify] https://crrev.com/651a683190d2a06681c50f00da755819b4543bdf/chrome/common/chrome_features.h

Sign in to add a comment