New issue
Advanced search Search tips

Issue 874092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement BackgroundFetchFailure for BackgroundFetchRegistration

Project Member Reported by na...@chromium.org, Aug 14

Issue description

Owner: na...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c002010f128fb82e0cf9f90332125129dcaa3d35

commit c002010f128fb82e0cf9f90332125129dcaa3d35
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Aug 23 14:00:40 2018

Background Fetch: Propagate BackgroundFetchRegistration
through various Background Fetch events.

This also makes adding FailureReason to BackgroundFetchRegistration easy,
since the plumbing to various service worker dispatcher classes won't have to
be done again.

Bug:  874092 ,  873630 

Change-Id: I1ae3b2115b1b1c357efa67e3e684423e5f4cd060
Reviewed-on: https://chromium-review.googlesource.com/1176085
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585474}
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_event_dispatcher.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/background_fetch_test_base.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_struct_traits_unittest.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/background_fetch/background_fetch_types.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom
[add] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_registration.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/c002010f128fb82e0cf9f90332125129dcaa3d35/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h

Status: Fixed (was: Started)

Sign in to add a comment