In the near term this should replace content_browsertests with --mash.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4898c0282df285c656144f37df6c8fd23667c99b commit 4898c0282df285c656144f37df6c8fd23667c99b Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Aug 20 15:17:38 2018 Fix test_ws crash when exiting fast test_ws could exit before |aura_test_helper_| is created. This CL handles such case. TBR=sky@chromium.org Bug: 874089 Change-Id: I65a29329fb079795f939a082dd60d4e680d282f5 Reviewed-on: https://chromium-review.googlesource.com/1180362 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584448} [modify] https://crrev.com/4898c0282df285c656144f37df6c8fd23667c99b/services/ui/test_ws/test_ws.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad commit ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Sep 07 21:04:34 2018 Move ContentGpuInterfaceProvider to content - Move ws::GpuInterfaceProvider into ws/public/cpp - Move ash::ContentGpuInterfaceProvider into content as content::GpuInterfaceProvider; This allows content_browsertests to use ContentGpuInterfaceProvider for test_ws in single process mash. Bug: 874089 Change-Id: Ia52f96c436c7d7cc2c034eaac8b20c5562a57f24 Reviewed-on: https://chromium-review.googlesource.com/1211973 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589636} [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/ash/BUILD.gn [delete] https://crrev.com/bbb925938fbed9b5bb4b54856ba0c728829fdb7f/ash/content/content_gpu_interface_provider.h [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/ash/shell.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/ash/shell/content/client/shell_browser_main_parts.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/ash/shell_init_params.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/ash/ws/ash_gpu_interface_provider.h [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/ash/ws/window_service_owner.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/chrome/browser/ui/ash/ash_shell_init.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/chrome/test/base/view_event_test_platform_part_chromeos.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/browser/BUILD.gn [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/browser/DEPS [rename] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/browser/gpu_interface_provider.cc [add] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/browser/gpu_interface_provider.h [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/public/browser/BUILD.gn [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/public/browser/DEPS [add] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/content/public/browser/gpu_interface_provider_factory.h [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/BUILD.gn [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/injected_event_handler_unittest.cc [add] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/public/cpp/host/BUILD.gn [rename] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/public/cpp/host/gpu_interface_provider.h [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/screen_provider_unittest.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/test_ws/BUILD.gn [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/test_ws/test_gpu_interface_provider.h [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/window_service.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/window_service_test_setup.cc [modify] https://crrev.com/ebf96b7c29b1cd0d5b1dce94fe0574006b1b60ad/services/ws/window_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa8260c463b9e3a760fed79f761733e90ecf861 commit ffa8260c463b9e3a760fed79f761733e90ecf861 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Sep 10 14:38:33 2018 test_ws: Move TestWindowService into its own h/cc Just moving code around w/o functionality change. This is to prepare to run TestWindowService from content_browsertests in a way similar to AshService to support both in-process and out-of-process mode. Standalone test_ws will be kept around since it is still used by some tests. Bug: 874089 Change-Id: I3324ffdab7126155f9355ee9b2b9aa6d8818da19 Reviewed-on: https://chromium-review.googlesource.com/1213560 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589906} [modify] https://crrev.com/ffa8260c463b9e3a760fed79f761733e90ecf861/services/ws/test_ws/BUILD.gn [add] https://crrev.com/ffa8260c463b9e3a760fed79f761733e90ecf861/services/ws/test_ws/test_window_service.cc [add] https://crrev.com/ffa8260c463b9e3a760fed79f761733e90ecf861/services/ws/test_ws/test_window_service.h [modify] https://crrev.com/ffa8260c463b9e3a760fed79f761733e90ecf861/services/ws/test_ws/test_ws.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82ceeefb5419c950453f00f87cdfb2f1b1919d93 commit 82ceeefb5419c950453f00f87cdfb2f1b1919d93 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Sep 14 20:50:50 2018 AuraTestHelper takes a given aura::Env Make AuraTestHelper take a given aura::Env and do the test setup for that Env. TestWs uses it to setup an aura::Env for WindowService when running in single process mode. Bug: 874089 Change-Id: I65914ed9942c6ce779cdde4a31ef04d727c8fb29 Reviewed-on: https://chromium-review.googlesource.com/1226365 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591466} [modify] https://crrev.com/82ceeefb5419c950453f00f87cdfb2f1b1919d93/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/82ceeefb5419c950453f00f87cdfb2f1b1919d93/ui/aura/test/aura_test_helper.h [modify] https://crrev.com/82ceeefb5419c950453f00f87cdfb2f1b1919d93/ui/aura/test/test_screen.cc [modify] https://crrev.com/82ceeefb5419c950453f00f87cdfb2f1b1919d93/ui/aura/test/test_screen.h [modify] https://crrev.com/82ceeefb5419c950453f00f87cdfb2f1b1919d93/ui/aura/window_tree_host.h [modify] https://crrev.com/82ceeefb5419c950453f00f87cdfb2f1b1919d93/ui/aura/window_tree_host_platform.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2397ff87955a23093a2dc00f7f9aa105f59816a3 commit 2397ff87955a23093a2dc00f7f9aa105f59816a3 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Sep 18 22:52:27 2018 Add testonly to service_manifest and grit GN template - Add testonly to service_manifest and grit GN template - Make test_ws service manifest testonly and update dependent targets; Bug: 874089 Change-Id: If9b46baf09e1b4457bdc05b252825d46b610d8ab Reviewed-on: https://chromium-review.googlesource.com/1231895 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592238} [modify] https://crrev.com/2397ff87955a23093a2dc00f7f9aa105f59816a3/content/shell/BUILD.gn [modify] https://crrev.com/2397ff87955a23093a2dc00f7f9aa105f59816a3/content/shell/android/BUILD.gn [modify] https://crrev.com/2397ff87955a23093a2dc00f7f9aa105f59816a3/extensions/BUILD.gn [modify] https://crrev.com/2397ff87955a23093a2dc00f7f9aa105f59816a3/services/service_manager/public/service_manifest.gni [modify] https://crrev.com/2397ff87955a23093a2dc00f7f9aa105f59816a3/services/ws/test_ws/BUILD.gn [modify] https://crrev.com/2397ff87955a23093a2dc00f7f9aa105f59816a3/tools/grit/grit_rule.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af075dbdea7c82077475586f2d6e4d68675517ce commit af075dbdea7c82077475586f2d6e4d68675517ce Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Sep 19 18:14:12 2018 Package test_ws in content_browsertests This allows content_browsertests run test_ws in process with single process mash and run it out of process for mash. Changes: - Make test_ws a packaged service in content_browsertests so that it could used in process for single process mash as well as out of process for mash; - Remove the code that launches standalone test_ws for mash; - Update TestWindowService so that it could be createe with content's ContextFactory/Private and CpuInterfaceProvider for single process mash and also works for mash; - Update WmTestHelper to support running in the same process of window service; Bug: 874089 Change-Id: Iece79fb9b96b48b8affb450cb44486c0b7ed00f0 Reviewed-on: https://chromium-review.googlesource.com/1228792 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592478} [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/shell/BUILD.gn [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/shell/DEPS [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/shell/browser/content_shell_browser_manifest_overlay.json [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/shell/utility/shell_content_utility_client.cc [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/test/BUILD.gn [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/content/test/content_test_launcher.cc [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/BUILD.gn [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/OWNERS [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/manifest.json [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/test_window_service.cc [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/test_window_service.h [add] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/test_window_service_factory.cc [add] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/test_window_service_factory.h [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/test_ws.cc [add] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/services/ws/test_ws/test_ws.mojom [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/ui/wm/BUILD.gn [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/ui/wm/test/DEPS [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/ui/wm/test/wm_test_helper.cc [modify] https://crrev.com/af075dbdea7c82077475586f2d6e4d68675517ce/ui/wm/test/wm_test_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc commit dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Sep 20 16:57:07 2018 Run content_browsertests in single process mash on bots - Add content_browsertests in single process mash mode to bots; - Add a filter file of the failed/flaky tests; Bug: 874089 Change-Id: I806556b0de0b4ee154d03395a566d0e6610eb5c3 Reviewed-on: https://chromium-review.googlesource.com/1234258 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592839} [modify] https://crrev.com/dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc/testing/buildbot/chromium.memory.json [modify] https://crrev.com/dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter [modify] https://crrev.com/dafe0e1d2ed43fe22feb8a4e5d59c0119dc61dbc/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37faad1f707b50079c237620cdb6078094709c97 commit 37faad1f707b50079c237620cdb6078094709c97 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Sep 20 22:47:35 2018 Disable a few more tests These seems to be flaky in content_browsertests in single process mash mode. Bug: 874089 , 887711 Change-Id: Iee0aeb5ed0c502c692eade56dfd4ae8f3248137d Reviewed-on: https://chromium-review.googlesource.com/1237377 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592981} [modify] https://crrev.com/37faad1f707b50079c237620cdb6078094709c97/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49da3db8af5c28429b3afc7c92a31df3eb531692 commit 49da3db8af5c28429b3afc7c92a31df3eb531692 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Sep 24 21:56:51 2018 Enable tests disabled for MemoryDumpManager DCHECK sky's crrev.com/c/1233174 resolved the destruction threading issue. Bug: 874089 , 884589 Change-Id: I35b2ffee918626b6d83e497ff0a0d3dae7f27024 Reviewed-on: https://chromium-review.googlesource.com/1241315 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593700} [modify] https://crrev.com/49da3db8af5c28429b3afc7c92a31df3eb531692/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter
There is only one remaining class of failures, and that isn't necessarily for single-process. I'm retargetting this to multi-process.
The test is added to waterfall. The only remaining issue is tracked in issue 877172. Closing.
Comment 1 by bugdroid1@chromium.org
, Aug 20