New issue
Advanced search Search tips

Issue 874077 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 896693



Sign in to add a comment

Autofill Dropdown Modernization on Android

Project Member Reported by tmartino@chromium.org, Aug 14

Issue description

This is a tracking bug for the eng efforts updating the Android Autofill dropdown and bringing it in line with the new specs (visually similar to the new Desktop implementation).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f6e9abc047b0332a81408bef39f9b00cf90887f

commit 9f6e9abc047b0332a81408bef39f9b00cf90887f
Author: Tommy Martino <tmartino@chromium.org>
Date: Tue Aug 21 15:20:45 2018

[AF Android] Creating Dropdown Refresh Impl

This CL:
* Adds a boolean parameter to AutofillDropdownAdapter to allow us to
  programmatically choose between two visual styles (the existing UI,
  and the WIP visual refresh).
* Removes dividers drawn between items in the refresh case.
* Wires up the existing feature and flag which will control which style
  is used.

Change-Id: Ia7cbb79b31e8ad9d086ef1a9a69cb6090b58d533
Bug: 874077
Reviewed-on: https://chromium-review.googlesource.com/1171558
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584749}
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/chrome/browser/about_flags.cc
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/components/autofill/android/java/res/values/dimens.xml
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/components/autofill/android/java/src/org/chromium/components/autofill/AutofillDropdownAdapter.java
[modify] https://crrev.com/9f6e9abc047b0332a81408bef39f9b00cf90887f/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/315e6592d6e0e21e193efbad1db8d4f86dfb983b

commit 315e6592d6e0e21e193efbad1db8d4f86dfb983b
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Wed Sep 05 03:35:49 2018

[AF Android] Use separate feature for UI refresh

Currently, the refresh on Android is controlled by the same flag as
on Desktop, which prevents us from enabling it by default.

Bug: 874077
Change-Id: Ifd13ae50e243e605ecdcb2742fefa555b9be2a35
Reviewed-on: https://chromium-review.googlesource.com/1204834
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588757}
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/chrome/browser/about_flags.cc
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/315e6592d6e0e21e193efbad1db8d4f86dfb983b/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281c443f547539769497c972498a1e9e48ddeffe

commit 281c443f547539769497c972498a1e9e48ddeffe
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed Sep 12 14:29:49 2018

[AF Android] Moving Divider Constants to //ui

Moving a few constants relating to dividers from //chrome to //ui, as
code in //components will be accessing them in a forthcoming CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1195894

Change-Id: Icc0e262e92d39353b6c35cb95a78d6f4e8ea10b5
Bug: 874077
Reviewed-on: https://chromium-review.googlesource.com/1219995
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590671}
[modify] https://crrev.com/281c443f547539769497c972498a1e9e48ddeffe/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/281c443f547539769497c972498a1e9e48ddeffe/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/281c443f547539769497c972498a1e9e48ddeffe/ui/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/281c443f547539769497c972498a1e9e48ddeffe/ui/android/java/res/values/dimens.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26009e457f56e8721c9ca57432b746e153e3b20

commit b26009e457f56e8721c9ca57432b746e153e3b20
Author: Tommy Martino <tmartino@chromium.org>
Date: Mon Sep 24 22:26:49 2018

[AF Android] Creating Structure for Footer

This CL lays out the scaffolding for adding a footer to the Android
Autofill dropdown. The general goal is to wrap the ListView used by the
existing dropdown in new XML, which will later be expanded to
contain the footer items.

This is accomplished by adding a new XML layout to define the
relationship between the existing list and its footer, and by adding a
new setFooterView method to the popup interface which injects a View
into the designated spot in the layout.


Change-Id: I144580c15be4b204b86b85b3d6e44d11fc9f9acf
Bug: 874077
Reviewed-on: https://chromium-review.googlesource.com/1195894
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593716}
[add] https://crrev.com/b26009e457f56e8721c9ca57432b746e153e3b20/ui/android/java/res/layout/dropdown_window.xml
[modify] https://crrev.com/b26009e457f56e8721c9ca57432b746e153e3b20/ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java
[modify] https://crrev.com/b26009e457f56e8721c9ca57432b746e153e3b20/ui/android/java/src/org/chromium/ui/DropdownPopupWindowImpl.java
[modify] https://crrev.com/b26009e457f56e8721c9ca57432b746e153e3b20/ui/android/java/src/org/chromium/ui/DropdownPopupWindowInterface.java
[modify] https://crrev.com/b26009e457f56e8721c9ca57432b746e153e3b20/ui/android/java/src/org/chromium/ui/DropdownPopupWindowJellyBean.java

Screenshots were requested for forthcoming CL which implements the footer view.

Link (accessible to Googlers only): https://docs.google.com/presentation/d/168Uk8_itrZTvf5RfsmCmpkFUebMJo2h61bBZBYQ70i8/edit?usp=sharing
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7

commit 3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7
Author: Tommy Martino <tmartino@chromium.org>
Date: Tue Oct 02 20:11:24 2018

[AF Android] Rendering footer

This CL introduces a new class, AutofillDropdownFooter, to represent the
footer in the UI Refresh of the Autofill dropdown. This class is backed
by a new XML layout.

In addition, the AutofillPopup receives new logic separating out the
footer items from the rest of the suggestions, and passing them along
to an instance of the new class, if and only if the UI refresh is in
use.

Bug: 874077
Change-Id: Ia6b28633afabc3c418908efcdde77a52af6fdb0a
Reviewed-on: https://chromium-review.googlesource.com/c/1255886
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595959}
[modify] https://crrev.com/3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7/components/autofill/android/BUILD.gn
[add] https://crrev.com/3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7/components/autofill/android/java/res/layout/autofill_dropdown_footer_item_refresh.xml
[modify] https://crrev.com/3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7/components/autofill/android/java/res/values/dimens.xml
[add] https://crrev.com/3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7/components/autofill/android/java/src/org/chromium/components/autofill/AutofillDropdownFooter.java
[modify] https://crrev.com/3c6126d9e23b882bbcf41c4cf2ba32ad9def07e7/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/771ef75072c4077cae83266cd8d6034812975055

commit 771ef75072c4077cae83266cd8d6034812975055
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed Oct 03 20:40:39 2018

[AF Android] Include footer when calculating width

When initially adding the footer functionality to the dropdown, the
possibility that the footer would have a greater width than the rest
of the dropdown was not considered. This CL updates the width
calculation in the base level dropdown class.

Screenshots:
https://docs.google.com/presentation/d/168Uk8_itrZTvf5RfsmCmpkFUebMJo2h61bBZBYQ70i8/edit?usp=sharing

Bug: 874077
Change-Id: I08051ac7302f476ee82ac5e077e49c4cdd00ef88
Reviewed-on: https://chromium-review.googlesource.com/c/1258051
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596348}
[modify] https://crrev.com/771ef75072c4077cae83266cd8d6034812975055/ui/android/java/src/org/chromium/ui/DropdownPopupWindowImpl.java

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ed847b46668ee8c426cf55b691abb47b59fa5c8

commit 8ed847b46668ee8c426cf55b691abb47b59fa5c8
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Oct 04 22:58:40 2018

[AF Android] Add vertical margin to dropdown

This CL adds a 4dp vertical margin on either side of the list inside a
Dropdown window. This is needed for the Autofill refresh.

Bug: 874077
Change-Id: If37016cafe886417cd4a82e9b59f75dd8ccbba7d
Reviewed-on: https://chromium-review.googlesource.com/c/1262962
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596901}
[modify] https://crrev.com/8ed847b46668ee8c426cf55b691abb47b59fa5c8/ui/android/java/res/layout/dropdown_window.xml
[modify] https://crrev.com/8ed847b46668ee8c426cf55b691abb47b59fa5c8/ui/android/java/res/values/dimens.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5e0551ab1a4146eb398b4df8019303533b71e5c

commit a5e0551ab1a4146eb398b4df8019303533b71e5c
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Oct 11 14:55:50 2018

[AF Android] Use rounded corners and elevation

This CL adds rounded corners and elevation to DropdownPopupWindowImpl.
It also adds a small util function to ApiCompatibilityUtils to
facilitate elevation.

Screenshots: https://docs.google.com/presentation/d/1cSW-l62jY_6HB3UA-KDg8JlguNrVJlncse9HL7xIhuU/edit?usp=sharing

BUG: 874077
Change-Id: Icd01731c2f7292d3ea1397e6790525af00bfa71d
Reviewed-on: https://chromium-review.googlesource.com/c/1265595
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598761}
[modify] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/content/public/android/java/src/org/chromium/content/browser/input/SuggestionsPopupWindow.java
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable-hdpi/dropdown_popup_background_down.9.png
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable-hdpi/dropdown_popup_background_up.9.png
[rename] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/drawable-hdpi/popup_bg.9.png
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable-mdpi/dropdown_popup_background_down.9.png
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable-mdpi/dropdown_popup_background_up.9.png
[rename] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/drawable-mdpi/popup_bg.9.png
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable-xhdpi/dropdown_popup_background_down.9.png
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable-xhdpi/dropdown_popup_background_up.9.png
[rename] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/drawable-xhdpi/popup_bg.9.png
[rename] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/drawable-xxhdpi/popup_bg.9.png
[rename] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/drawable-xxxhdpi/popup_bg.9.png
[delete] https://crrev.com/2be780e8d20eb35cde9eb426ede0f98465728f0e/ui/android/java/res/drawable/dropdown_popup_background.xml
[modify] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/res/values/dimens.xml
[modify] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/src/org/chromium/ui/DropdownPopupWindowImpl.java
[modify] https://crrev.com/a5e0551ab1a4146eb398b4df8019303533b71e5c/ui/android/java/src/org/chromium/ui/widget/AnchoredPopupWindow.java

Blockedon: 896693
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment