New issue
Advanced search Search tips

Issue 874059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 828317



Sign in to add a comment

Roundtrip test font src: local() matching

Project Member Reported by drott@chromium.org, Aug 14

Issue description

Once we have @font-face { src: local() } matching hooked up, we need a round trip test that also works on Android (so it can't be a layout test atm) testing whether fonts have been matched correctly.

 
Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a

commit ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a
Author: Dominik Röttsches <drott@chromium.org>
Date: Wed Aug 22 16:35:29 2018

Move DevToolsProtocolTest test harness to test support header

Preparation for  issue 874059  in which the DevToolsProtocolTest harness
is needed for verifying font selection, after discussion in
https://chromium-review.googlesource.com/c/chromium/src/+/1174540

Address banned and deprecated function warnings in the process: Using a
OnceClosure for closing the specific RunLoop to replace QuitCurrent()
and remove usage of RunMessageLoop(), mark NotificationMatcher as
RepeatingCallback.

Bug:  874059 
Change-Id: Id63a73e4ca7d2cb3bef888eac91bb3cc7cf8fb1a
Reviewed-on: https://chromium-review.googlesource.com/1183239
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585060}
[modify] https://crrev.com/ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a/content/browser/devtools/DEPS
[modify] https://crrev.com/ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[add] https://crrev.com/ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a/content/browser/devtools/protocol/devtools_protocol_test_support.cc
[add] https://crrev.com/ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a/content/browser/devtools/protocol/devtools_protocol_test_support.h
[modify] https://crrev.com/ad61e6de3ab0c0b2fc912bfc316c1d1b13da747a/content/test/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bedc36ac9b37703dde0646017740ecd31c485e76

commit bedc36ac9b37703dde0646017740ecd31c485e76
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Aug 24 18:37:51 2018

Add a BrowserTest comparing matched fonts using DevTools protocol

For issue 828317 we need an end to test for checking whether the correct
fonts have been selected for @font-face { src: local(<fontname>) }
rules. Since this cannot be reliable verified with web platform API, I
am using DevTools to connect to the content instance and retrieve
information about the selected fonts, just like in the style panel of
DevTools. The DevTools protocol communication is modeled after
content/browser/devtools/protocol/devtools_protocol_browsertest.cc

I appreciate feedback on whether I should duplicate this DevTools
communication code here, whether there is an easier way to achieve this,
or whether we should factor out the relevant parts of
content/browser/devtools/protocol/devtools_protocol_browsertest.cc into
a separate file that I can reuse here for the FontUniqueNameBrowserTest.

Bug:  874059 
Change-Id: I4a2beeb81a3b5e4cec68cf196fcf0ebf29287d38
Reviewed-on: https://chromium-review.googlesource.com/1174540
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585916}
[add] https://crrev.com/bedc36ac9b37703dde0646017740ecd31c485e76/content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc
[modify] https://crrev.com/bedc36ac9b37703dde0646017740ecd31c485e76/content/test/BUILD.gn
[add] https://crrev.com/bedc36ac9b37703dde0646017740ecd31c485e76/content/test/data/font_src_local_matching.html

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95

commit b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Jan 10 16:46:12 2019

Fix a couple of test cases to correctly reference local() fonts

Bug:  874059 
Tbr: thomasanderson
Change-Id: I9c617458612393a37aecd785b860da73a359c8eb
Reviewed-on: https://chromium-review.googlesource.com/c/1405049
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621607}
[modify] https://crrev.com/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95/third_party/blink/web_tests/fast/css/font-face-default-font-expected.html
[modify] https://crrev.com/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95/third_party/blink/web_tests/fast/css/font-face-default-font.html
[modify] https://crrev.com/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95/third_party/blink/web_tests/fast/css/font-face-synthetic-bold-italic-for-locally-installed.html
[modify] https://crrev.com/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95/third_party/blink/web_tests/fast/css/fontfaceset-load.html
[modify] https://crrev.com/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95/third_party/blink/web_tests/fast/css/fontfaceset-multiple-families.html
[modify] https://crrev.com/b588dc8fa15f48fd4ac6e0dd3a5e6237c65d8d95/third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js

Sign in to add a comment