Accessibility isn't very clear for RecentTabs |
||||||||
Issue descriptionWith VoiceOver enabled. What steps will reproduce the problem? (1) Open Recent Tabs (2) Navigate through the page What is the expected result? VoiceOver should say something on the headers to let the user know that it is a button (or something you can interact with) and that tapping it would expand/collapse the section. What happens instead? Voice Over just read the label. It is better on M68, so I think we can use the same string if needed (to avoid cherry-picking string too late).
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9753fedbda50a7e0ee8d4b7baa43d2f3bc9e24b8 commit 9753fedbda50a7e0ee8d4b7baa43d2f3bc9e24b8 Author: sczs <sczs@chromium.org> Date: Wed Aug 15 15:53:30 2018 [ios] Fixes DisclosureHeader Accessibility. Bug: 874047 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I627e2d5d51716d715699792946e8537f5d21ed09 Reviewed-on: https://chromium-review.googlesource.com/1174917 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#583261} [modify] https://crrev.com/9753fedbda50a7e0ee8d4b7baa43d2f3bc9e24b8/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm
,
Aug 15
,
Aug 15
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 15
Waiting for next canary for verification.
,
Aug 16
Verified in latest canary. Kariah, PTAL.
,
Aug 16
This bug requires manual review: Less than 15 days to go before AppStore submit on M69 Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16
How confident are you in this fix? Why should this be merged?
,
Aug 16
Is extremely safe as it only involves a11y changes. Without this collapsing/expanding headers in RecentTabs would be really hard for people using voice-over.
,
Aug 16
Approved.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04d33bda55f65917ae3519be9b41d2b6b8842015 commit 04d33bda55f65917ae3519be9b41d2b6b8842015 Author: sczs <sczs@chromium.org> Date: Fri Aug 17 01:03:07 2018 [ios] Fixes DisclosureHeader Accessibility. TBR=sczs@chromium.org (cherry picked from commit 9753fedbda50a7e0ee8d4b7baa43d2f3bc9e24b8) Bug: 874047 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I627e2d5d51716d715699792946e8537f5d21ed09 Reviewed-on: https://chromium-review.googlesource.com/1174917 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583261} Reviewed-on: https://chromium-review.googlesource.com/1179306 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#681} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/04d33bda55f65917ae3519be9b41d2b6b8842015/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm
,
Aug 22
VoiceOver reads the headers and says its a button in Recent Tabs .Verified on iPad Pro 12 9 iOS 11.4.1 on 69.0.3497.53 Beta |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sczs@chromium.org
, Aug 14