LGTM, thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44204c926e1e256be081868a9eba4ccf7cd70c90

commit 44204c926e1e256be081868a9eba4ccf7cd70c90
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Aug 22 16:26:36 2018

Render 'No username' as a secondary text in the password drop-down.

TBR=tedchoc@chromium.org

Bug:  874039 
Change-Id: I183677ed1399b8dcd6b94b87e9ae88851fa4441c
Reviewed-on: https://chromium-review.googlesource.com/1181423
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585044}
[modify] https://crrev.com/44204c926e1e256be081868a9eba4ccf7cd70c90/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
[modify] https://crrev.com/44204c926e1e256be081868a9eba4ccf7cd70c90/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/44204c926e1e256be081868a9eba4ccf7cd70c90/components/autofill/core/browser/suggestion.cc
[modify] https://crrev.com/44204c926e1e256be081868a9eba4ccf7cd70c90/components/autofill/core/browser/suggestion.h
[modify] https://crrev.com/44204c926e1e256be081868a9eba4ccf7cd70c90/components/password_manager/core/browser/password_autofill_manager.cc

I'd like to merge r585044 to M69. That's a polish of the new password dropdown for MD2.

This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Pls update bug with canary result tomorrow. Also how safe is the change to merge to M69? Is this feature behind finch?

This is very late in M69 release cycle, only one beta left and plan is to promote same beta to stable. So change has to be super safe and truly critical for M69 in order to take it in.

The new UI look is controlled by Finch, yes. It's the same flag the autofill drop down uses for their MD2 style.
The fix is simple and safe to merge.

Ok, pls update the bug with canary result tomorrow.

Tried checking the issue with the help of attached screenshots in c#0 & 1, as we are not very sure about the test steps and expected/actual behaviour, Could some one help us by providing the test steps along with actual/expected behaviour which helps us to verify the fix.
Note: Couldn't access the URL given in c#0

Thanks!

Sure!

1. Go to https://rsolomakhin.github.io/autofill/
2. Enter a password (with empty username field)
3. Click the password icon in the omnibox to save the password (with empty username field)
4. Reload the page and click password field

Just checked in Canary, LGTM!

The fix works on Canary.

The NextAction date has arrived: 2018-08-24

Approving merge to M69 branch 3497 based on comments #4, #8, #12 and #13. Please merge ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17e3efa95453677175c72127a7dc9c1730aee1f4

commit 17e3efa95453677175c72127a7dc9c1730aee1f4
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 27 09:26:57 2018

Render 'No username' as a secondary text in the password drop-down.

TBR=tedchoc@chromium.org, vasilii@chromium.org

(cherry picked from commit 44204c926e1e256be081868a9eba4ccf7cd70c90)

Bug:  874039 
Change-Id: I183677ed1399b8dcd6b94b87e9ae88851fa4441c
Reviewed-on: https://chromium-review.googlesource.com/1181423
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#585044}
Reviewed-on: https://chromium-review.googlesource.com/1189883
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#806}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/17e3efa95453677175c72127a7dc9c1730aee1f4/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
[modify] https://crrev.com/17e3efa95453677175c72127a7dc9c1730aee1f4/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/17e3efa95453677175c72127a7dc9c1730aee1f4/components/autofill/core/browser/suggestion.cc
[modify] https://crrev.com/17e3efa95453677175c72127a7dc9c1730aee1f4/components/autofill/core/browser/suggestion.h
[modify] https://crrev.com/17e3efa95453677175c72127a7dc9c1730aee1f4/components/password_manager/core/browser/password_autofill_manager.cc

Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #69.0.3497.72 as per the comment #11.
Attaching screenshot for reference.
Observed that 'No username' is rendered as expected.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!

Deleted: 874039 CL Verification.png 27.8 KB

	874039 CL Verification.png 27.8 KB View Download