New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874021 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Unable to view the notification number clearly in ubertray of OOBE

Project Member Reported by rkalavakuntla@chromium.org, Aug 14

Issue description

Chrome Version:70.0.3519.3/10967.0.0 dev-channel Candy,Blaze,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover Build >> In OOBE screen >>Rotate the display to get a notification and observe at ubertray

Actual: Unable to view the notification number clearly in Ubertray shelf
Expected: Should be able to see the notification number clearly in Ubertray shelf

Raising this as a Non-Regression issue seen from 70.0.3519.3

Note: Issue is working fine in Sign in screen

Attached the screenshots for reference..

 
actual.jpg
3.4 MB View Download
Expected.jpg
5.5 MB View Download
Cc: -ajha@chromium.org yoshiki@chromium.org
Owner: yamaguchi@chromium.org
+yamaguchi@ who implemented this counter
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bea348ed76666585492aa85d4490e150d1e3aa20

commit bea348ed76666585492aa85d4490e150d1e3aa20
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Aug 15 06:30:22 2018

Adjust colors of notification icons based on session status.

This will prevent notification counter icon shown in white while
in the OOBE screen, when the background of the icons are also
bright color.

Test: manual test
Bug:  874021 
Change-Id: I91cbbd1111b33d1a030b1d5aae2bdd884a1d487a
Reviewed-on: https://chromium-review.googlesource.com/1175517
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583179}
[modify] https://crrev.com/bea348ed76666585492aa85d4490e150d1e3aa20/ash/system/unified/notification_counter_view.cc

Status: Fixed (was: Started)
Changed to use the dark color in case of the bright background, just like other icons.

Sign in to add a comment