Issue metadata
Sign in to add a comment
|
Regression: Unnecessary shelf is seen while resuming the device in Sign out screen |
||||||||||||||||||||||
Issue descriptionChrome Version:70.0.3519.3/10967.0.0 dev-channel Candy,Blaze,Peppy OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >>Sign out (2)Suspend the device >>resume it and observe while Sign out screen comes Actual: Unnecessary shelf is seen while resuming the device Expected:No such unnecessary shelf should be seen while screen resumes This is a Regression issue as same is working fine in 70.0.3511.0/10952.0.0 dev Note: Same issue is also seen when we restart the device Attached the screencast for reference..
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ebe3764ca550a1ab6f00a28264be324a2fe17f commit 16ebe3764ca550a1ab6f00a28264be324a2fe17f Author: Wenzhao Zang <wzang@chromium.org> Date: Wed Sep 26 22:41:15 2018 cros: Fix unnecessary black shelf background issue when device boot This CL is more lightweight solution compared with the previous attempts: https://crrev.com/c/1229695 (An overkill. "no wallpaper" is not a valid UI state we'll support.) https://crrev.com/c/1187547 (A risky change. Large number of tests failed.) https://crrev.com/c/1173433 (Doesn't quite handle the "no wallpaper" case.) Bug: 874015 Change-Id: I7656856d1b631b7f6d2555f932116ea08e7d23ec Reviewed-on: https://chromium-review.googlesource.com/1237149 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594504} [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/shelf/shelf_background_animator_unittest.cc [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/wallpaper/wallpaper_controller_observer.h [modify] https://crrev.com/16ebe3764ca550a1ab6f00a28264be324a2fe17f/ash/wallpaper/wallpaper_controller_unittest.cc
,
Sep 26
,
Sep 27
,
Sep 27
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f21674144c21712b7288299c36eb7dab1057263 commit 1f21674144c21712b7288299c36eb7dab1057263 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Sep 28 21:17:17 2018 cros: Fix unnecessary black shelf background issue when device boot This CL is more lightweight solution compared with the previous attempts: https://crrev.com/c/1229695 (An overkill. "no wallpaper" is not a valid UI state we'll support.) https://crrev.com/c/1187547 (A risky change. Large number of tests failed.) https://crrev.com/c/1173433 (Doesn't quite handle the "no wallpaper" case.) Bug: 874015 Change-Id: I7656856d1b631b7f6d2555f932116ea08e7d23ec Reviewed-on: https://chromium-review.googlesource.com/1237149 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594504}(cherry picked from commit 16ebe3764ca550a1ab6f00a28264be324a2fe17f) Reviewed-on: https://chromium-review.googlesource.com/1252537 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#752} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/shelf/shelf_background_animator_unittest.cc [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/wallpaper/wallpaper_controller_observer.h [modify] https://crrev.com/1f21674144c21712b7288299c36eb7dab1057263/ash/wallpaper/wallpaper_controller_unittest.cc
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f21674144c21712b7288299c36eb7dab1057263 Commit: 1f21674144c21712b7288299c36eb7dab1057263 Author: wzang@chromium.org Commiter: wzang@chromium.org Date: 2018-09-28 21:17:17 +0000 UTC cros: Fix unnecessary black shelf background issue when device boot This CL is more lightweight solution compared with the previous attempts: https://crrev.com/c/1229695 (An overkill. "no wallpaper" is not a valid UI state we'll support.) https://crrev.com/c/1187547 (A risky change. Large number of tests failed.) https://crrev.com/c/1173433 (Doesn't quite handle the "no wallpaper" case.) Bug: 874015 Change-Id: I7656856d1b631b7f6d2555f932116ea08e7d23ec Reviewed-on: https://chromium-review.googlesource.com/1237149 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594504}(cherry picked from commit 16ebe3764ca550a1ab6f00a28264be324a2fe17f) Reviewed-on: https://chromium-review.googlesource.com/1252537 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#752} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 2
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jdufault@chromium.org
, Aug 14Status: Assigned (was: Untriaged)