Issue metadata
Sign in to add a comment
|
Regression: Unnecessary lock icon is seen beside WiFi icon in OOBE screen but not in Signed in screen. |
||||||||||||||||||||||
Issue descriptionChrome Version:70.0.3519.3/10967.0.0 dev-channel Candy,Blaze,Peppy OS:Chrome OS What steps will reproduce the problem? (1)Recover build>> Connect to a WiFi Network and observe in ubertray unnecessary lock icon beside WiFi icon and after signing in the WiFi icon is seen greyed out for 1-2 secs and then only WiFi icon is seen and lock icon is not seen ( Please refer video) Actual: Unnecessary lock icon is seen with WiFi icon in ubertray and after signing in, WiFi icon is seen greyed out and after 1-2 secs, only WiFi icon is seen and lock icon is not seen. ( Refer video) Expected: If lock icon seen with WiFi icon in OOBE is intended, same behaviour should be seen in signed in screen also and no greying out of WiFI icon should be seen when signed in. This is a Regression issue as same is working fine in 70.0.3511.0/10952.0.0 dev @tetsui: Please confirm the issue
,
Aug 15
I confirmed the lock badge appears when connecting to a secure network but not when connecting to non-secured one. After signing in, the badge was not shown regardless of the wifi network type. I think the right behavior is the one seen in OOBE screen as long unless the network is open (no password).
,
Aug 15
,
Aug 15
Based on Issue 874165, the right behavior is to show the badge (the lock icon beside WiFi icon) if the wireless network is encrypted. The behavior on OOBE is correct, and the one after signed in is wrong. To sgabriel@: please confirm if this is correct. The badge (lock icon) has been shown only when the icon is in the dark color since more than 7 years ago. So my guess is that this become visible after we've changed the OOBE screen to bright color theme.
,
Aug 15
I believe that historically the "light" icons were used in the status area where we intentionally did not want to clutter the display with badge icons, and the "dark" icons were used in the system menu itself. We probably need to update that logic to explicitly specify where/when we want to badge the icons (which will be easier to do now that we are generating them as vector icons).
,
Aug 16
Thanks, that is good to know. After discussion we decided not to change the existing UI appearance. So we'd just make the icons on OOBE status tray same as in user session except for the color.
,
Aug 16
I wrote #7 to a wrong thread. Sorry.
,
Aug 22
According to Issue 874165 it seems the plan is to also show badges in tray icons. stevenjb@, sgabriel@: WDYT?
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0062d38517b1eb6316fcee094fb4bf75163b0e39 commit 0062d38517b1eb6316fcee094fb4bf75163b0e39 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Aug 22 13:23:19 2018 Hide lock icon in OOBE status tray wifi icon. We have hidden the lock icon badge in the status tray to avoid visual clutter, but the logic was not applied on dark color icons in OOBE. Test: manual test by connecting to an encrypted wifi access point at OOBE Bug: 874012 Change-Id: I529591faeba8febfce918dd400cc3d230da58658 Reviewed-on: https://chromium-review.googlesource.com/1177081 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584995} [modify] https://crrev.com/0062d38517b1eb6316fcee094fb4bf75163b0e39/ash/system/network/network_icon.cc
,
Aug 22
,
Aug 22
re #9 as discussed during last week meeting, let's not display the lock on wifi in status tray.
,
Aug 23
#12: So the spec in Issue 874165 is changed, right?
,
Aug 23
Yes, I've updated the spec accordingly. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Aug 15Owner: yamaguchi@chromium.org