New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874001 link

Starred by 1 user
Status: Duplicate
Merged: issue 881289
Owner:
feuunk@chromium.org
Closed: Sep 26
Cc:
█ tschumann@chromium.org
se...@chromium.org
jkrcal@chromium.org
ma...@chromium.org
mastiz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Wallet Data uses client_tag_based_model_type_processor, but doesn't have client_tags.

Project Member Reported by feuunk@google.com, Aug 14 
The default client_tag_based_model_type_processor requires incoming data to have client tag hash field set on each entity.

Wallet data does not have this field set, because the data comes from the Wallet server, as opposed to from other clients. This makes the processor drop all incoming updates on the ground (this code introduced here), which means there's no data for the user.

A quick workaround on the client would be to ask the bridge to create client_tags for Wallet items that don't have the tag set yet.

Longer term solutions would be to either make the server set the client tags, or to use a different processor for wallet data.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/167b2a167c50b574657d6c095da0ac4ea49d0841

commit 167b2a167c50b574657d6c095da0ac4ea49d0841
Author: Florian Uunk <feuunk@chromium.org>
Date: Tue Aug 21 16:10:30 2018

Create client tags for Wallet data in the processor

The client_tag_based_model_type_processor requires incoming data to
have client tag hash field set on each entity. Wallet data does not
have this field set, because the data comes from the Wallet server, as
opposed to from other clients. This makes the processor drop all
incoming updates on the ground (this code introduced here), which means
there's no data for the user.

This CL makes the bridge to create client_tags for Wallet items that
don't have the tag set yet.

A future, longer term solutions would be to either make the server set
the client tags, or to use a different processor for wallet data.

BUG= 874001 

Change-Id: Ie4331c3bd601a43c59fc35ea94d271db2db66ec8
Reviewed-on: https://chromium-review.googlesource.com/1174435
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584766}
[modify] https://crrev.com/167b2a167c50b574657d6c095da0ac4ea49d0841/components/sync/model/entity_data.cc
[modify] https://crrev.com/167b2a167c50b574657d6c095da0ac4ea49d0841/components/sync/model/entity_data.h
[modify] https://crrev.com/167b2a167c50b574657d6c095da0ac4ea49d0841/components/sync/model/entity_data_unittest.cc
[modify] https://crrev.com/167b2a167c50b574657d6c095da0ac4ea49d0841/components/sync/model_impl/client_tag_based_model_type_processor.cc
[modify] https://crrev.com/167b2a167c50b574657d6c095da0ac4ea49d0841/components/sync/model_impl/client_tag_based_model_type_processor.h
[modify] https://crrev.com/167b2a167c50b574657d6c095da0ac4ea49d0841/components/sync/model_impl/client_tag_based_model_type_processor_unittest.cc

Comment 2 by melandory@chromium.org, Aug 24

Labels: Sync-Triaged
Status: Assigned (was: Untriaged)

Comment 3 by melandory@chromium.org, Sep 9 

sync-triage ping

Comment 4 by jkrcal@chromium.org, Sep 17 

triage ping: feuunk@, any updates? (after you come from vacation)

Comment 5 by mamir@chromium.org, Sep 26 

triage ping: feuunk@, any updates? (since you are back from vacation)

Comment 6 by feuunk@google.com, Sep 26

Mergedinto: 881289
Status: Duplicate (was: Assigned)
We now have crbug.com/881289 to track generating the IDs on the server.
►

Sign in to add a comment