Findit has detected flake occurrences for the test SaveType/SavePageOriginalVsSavedComparisonTest.Style/1 Culprit (82.9% confidence): https://chromium-review.googlesource.com/q/I990160f973b29d7620214d7d58a16ece033adf3f Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKHAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzExOTAzL3Zpel9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SaveType/SavePageOriginalVsSavedComparisonTest.Style/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKHAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzExOTAzL3Zpel9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
Findit identified the culprit r582841 with confidence 82.9% in the config "chromium.chromiumos / linux-chromeos-rel" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKHAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzExOTAzL3Zpel9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SaveType/SavePageOriginalVsSavedComparisonTest.Style/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKHAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzExOTAzL3Zpel9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Issue 873967 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc0e1eac05c54aa7897be6763229cee418ed4557 commit fc0e1eac05c54aa7897be6763229cee418ed4557 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Aug 14 08:12:52 2018 Revert "Mojoify FindInPage::Find" This reverts commit fef811c5128c4c69d5cb45ba64ce33320d4067b0. Reason for revert: SaveType/SavePageOriginalVsSavedComparisonTest.Style becomes flaky and findit suggested this is the culprit. Let me revert this speculatively and see if it'll be fixed. Original change's description: > Mojoify FindInPage::Find > > We are mojoifying browser<->renderer communication of Find-in-page. > In this CL, we are converting the Find function to mojo. Find replies > are now separated into two functions, one to update the number of > found matches (SetNumberOfMatches) and the other is to update which > match is active right now (SetActiveMatch). > > This is the final function to be mojoified for FindInPage. > Mojoifying doc: https://goo.gl/JenyGm > > Bug: 819919 > Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f > Reviewed-on: https://chromium-review.googlesource.com/1086950 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582841} TBR=dcheng@chromium.org,yosin@chromium.org,alexmos@chromium.org,rakina@chromium.org Change-Id: I0c48b0aed588049147f8cc49addaf1686fa67621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819919, 873965 Reviewed-on: https://chromium-review.googlesource.com/1173892 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582862} [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_in_page_client.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_in_page_client.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_request_manager.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_request_manager.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/common/frame_messages.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/mojom/frame/find_in_page.mojom [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/find_in_page.cc [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/find_in_page.h [modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/web_local_frame_impl.h
Findit identified the culprit r582841 with confidence 70.0% in the config "chromium.win / Win 7 Tests x64 (1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQxODc2L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SaveType/SavePageOriginalVsSavedComparisonTest.Style/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQxODc2L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Findit identified the culprit r582841 with confidence 83.8% in the config "chromium.linux / Linux Tests" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKHAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzLzcxNzgzL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SaveType/SavePageOriginalVsSavedComparisonTest.Style/1&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKHAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzLzcxNzgzL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVlI1Y0dVdlUyRjJaVkJoWjJWUGNtbG5hVzVoYkZaelUyRjJaV1JEYjIxd1lYSnBjMjl1VkdWemRDNVRkSGxzWlM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
I'm not really sure why this would become flaky with the find-in-page changes, but I'm pretty sure this change was already reverted.
Comment 1 by Findit
, Aug 14