New issue
Advanced search Search tips

Issue 873965 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: SaveType/SavePageOriginalVsSavedComparisonTest.Style/1


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

SaveType/SavePageOriginalVsSavedComparisonTest.Style/1 is Flaky

Project Member Reported by Findit, Aug 14

Issue description

Cc: qin...@chromium.org
 Issue 873967  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc0e1eac05c54aa7897be6763229cee418ed4557

commit fc0e1eac05c54aa7897be6763229cee418ed4557
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Aug 14 08:12:52 2018

Revert "Mojoify FindInPage::Find"

This reverts commit fef811c5128c4c69d5cb45ba64ce33320d4067b0.

Reason for revert: SaveType/SavePageOriginalVsSavedComparisonTest.Style becomes flaky and findit suggested this is the culprit.
Let me revert this speculatively and see if it'll be fixed.

Original change's description:
> Mojoify FindInPage::Find
> 
> We are mojoifying browser<->renderer communication of Find-in-page.
> In this CL, we are converting the Find function to mojo. Find replies
> are now separated into two functions, one to update the number of
> found matches (SetNumberOfMatches) and the other is to update which
> match is active right now (SetActiveMatch).
> 
> This is the final function to be mojoified for FindInPage.
> Mojoifying doc: https://goo.gl/JenyGm
> 
> Bug: 819919
> Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f
> Reviewed-on: https://chromium-review.googlesource.com/1086950
> Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582841}

TBR=dcheng@chromium.org,yosin@chromium.org,alexmos@chromium.org,rakina@chromium.org

Change-Id: I0c48b0aed588049147f8cc49addaf1686fa67621
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819919,  873965 
Reviewed-on: https://chromium-review.googlesource.com/1173892
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582862}
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_in_page_client.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_in_page_client.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_request_manager.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/find_request_manager.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/common/frame_messages.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/mojom/frame/find_in_page.mojom
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/find_in_page.cc
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/find_in_page.h
[modify] https://crrev.com/fc0e1eac05c54aa7897be6763229cee418ed4557/third_party/blink/renderer/core/frame/web_local_frame_impl.h

Components: Tests>Flaky
Owner: dcheng@chromium.org
Cc: lukasza@chromium.org
Owner: rakina@chromium.org
Status: WontFix (was: Available)
I'm not really sure why this would become flaky with the find-in-page changes, but I'm pretty sure this change was already reverted.

Sign in to add a comment