New issue
Advanced search Search tips

Issue 873953 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression : 'Sorry your password..." Error message is misplaced for second time in Sign out screen

Project Member Reported by mmanchala@chromium.org, Aug 14

Issue description

Chrome Version: 70.0.3519.3/10967.0.0 dev-channel Candy,Peppy and Blaze 
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> now at Uber Tray click on 'Sign out' option
(2)In Sign out screen -> enter Wrong password and observe 'Sorry your password..."  Error message is seen 
(3)Again enter wrong password and observe 'Sorry your password..."  Error message is misplaced
(Please refer Video and Screenshot)

Expected: 'Sorry your password..."  Error message should not be misplaced 
Actual: Instead 'Sorry your password..."  Error message is misplaced for second time

Note : Issue is also seen in Lock screen

This is Regression Issue as same is working fine in 70.0.3511.0/10952.0.0 dev-channel Peppy

 
Actual_MisplacedErrorMessage.mp4
7.9 MB View Download
Actual_MisplacedErrorMessage.jpg
761 KB View Download
Expected_ErrorMessage.jpg
852 KB View Download
Expected_ErrorMessage.mp4
8.5 MB View Download
Owner: qnnguyen@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/873ea7a659e4e1d38a71470bdf8d2e8d92cc5a60

commit 873ea7a659e4e1d38a71470bdf8d2e8d92cc5a60
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Aug 14 23:37:49 2018

cros: Don't shift login bubble right if it covers part of the anchor.

This is a bit closer to webui-login's behavior (although currently it doesn't
gracefully handle bubbles extending past the bottom of the screen). This also
prevents the auth error bubble from suddenly jumping to the right if it extends
into the shelf a bit.  This Cl also changes the error bubble bounds calculation
to include all of the black box, rather than just the internal content.

Bug:  873953 
Change-Id: I13d670a208418f77232c59b756fb7854e1c88cc2
Reviewed-on: https://chromium-review.googlesource.com/1175196
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583081}
[modify] https://crrev.com/873ea7a659e4e1d38a71470bdf8d2e8d92cc5a60/ash/login/ui/login_bubble.cc

Status: Fixed (was: Assigned)

Sign in to add a comment