Controlled-setting indicator text for Demo Mode |
||
Issue descriptionDemo Mode uses Public Sessions. We set user policy for the cros-demo-mode.com domain to force certain settings, e.g. Safe Browsing. The normal text for these indicators is "This setting is enforced by your administrator." But demo devices don't have an "administrator" per se; they're just retail devices that have some restrictions for demo purposes. So we should use a different string for these indicators. I'd suggest something like "This setting can't be changed in demo sessions."
,
Aug 17
'This setting can't be changed in demo session'. (not sessions).
,
Aug 18
'This setting can't be changed in a demo session.' is grammatical. I think we were mishearing each other in our meeting today :-)
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eee2dc38e3d1eaec6ce1edf356df3b941ed8ec3 commit 3eee2dc38e3d1eaec6ce1edf356df3b941ed8ec3 Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Aug 20 04:53:52 2018 cros: Update controlled-setting indicator text for Demo Mode There are three places that use |IDS_CONTROLLED_SETTING_POLICY|, but AFAIK there's no need to change the other two places (arc_support_host.cc and extensions_ui.cc). Bug: 873946 Change-Id: I34e9fb0a20139b0aaca6380e949248745f50ed58 Reviewed-on: https://chromium-review.googlesource.com/1180526 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584361} [modify] https://crrev.com/3eee2dc38e3d1eaec6ce1edf356df3b941ed8ec3/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/3eee2dc38e3d1eaec6ce1edf356df3b941ed8ec3/chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc
,
Aug 20
|
||
►
Sign in to add a comment |
||
Comment 1 by wzang@chromium.org
, Aug 16Status: Started (was: Assigned)