Team drives with non-path like names can hit DCHECK failures when converting to a FilePath |
|||||||
Issue descriptionIt seems team drives can have all kinds of wonderful names with "/", "\" and null characters in them. We need to normalize the names to avoid hitting DCHECKS and further crazy results.
,
Aug 15
,
Aug 15
,
Aug 16
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 17
Merge approved, M69.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7189d752ac23cecf1e0dbc15a93abc279e09fa1a commit 7189d752ac23cecf1e0dbc15a93abc279e09fa1a Author: Stuart Langley <slangley@google.com> Date: Fri Aug 17 03:39:39 2018 Normalize team drive names when saving them. Team drives can have no ascii and path like characters in the name. Normalize the names to remove these. This will lead to a delta between what you see in the web app and what you see in the file manager for team drives with these names. Bug: 873920 Change-Id: I24fd8664cc64a62b9a1d5e72d0138c0792c449d9 Reviewed-on: https://chromium-review.googlesource.com/1174134 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583185}(cherry picked from commit a412fb197170aeffe2c267efe4a4b970f0569c0c) Reviewed-on: https://chromium-review.googlesource.com/1179401 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#683} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/7189d752ac23cecf1e0dbc15a93abc279e09fa1a/components/drive/chromeos/team_drive_list_loader.cc [modify] https://crrev.com/7189d752ac23cecf1e0dbc15a93abc279e09fa1a/components/drive/team_drive_list_loader_unittest.cc
,
Aug 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 15