Speed-up keyboardDeleteDrive tests on Mash |
|||
Issue descriptionSee Mash browser tests https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=mash_browser_tests&tests=KeyboardOperations%2FFilesAppBrowser All test looking good, _except_ the delete on Drive tests KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDrive KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDrive_DriveFs Note: normally Drive tests are a bit faster than Downloads tests, but not in this case it seems. Anyho, we can apply the usual test assay and speed-up story here: - only load the volume/files we need for a test - test do 2 delete tests - how about we delete one file - clean-up code, add-docs as needed etc
,
Aug 14
,
Aug 15
,
Aug 15
Issue 871684 has been merged into this issue.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9973a074d1e4e4db5ad9f3e4af1c4e884a197688 commit 9973a074d1e4e4db5ad9f3e4af1c4e884a197688 Author: Noel Gordon <noel@chromium.org> Date: Wed Aug 15 01:35:19 2018 Speed-up keyboard_operations.js delete file tests Bug 873915 notes flakey time-outs on the Mash bots for keyboard delete on Drive tests. Speed-up the delete file tests by loading the one file needed for the test (photos). Make the test delete one file (not two). Minor: fix comments, group the keyboard delete test cases together. Test: browser_tests --gtest_filter="*/FilesApp*keyboardDelete*" Bug: 873915 Change-Id: I2af501ef6b10cbad323991fcdec2f500260ad0d3 Reviewed-on: https://chromium-review.googlesource.com/1174336 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583119} [modify] https://crrev.com/9973a074d1e4e4db5ad9f3e4af1c4e884a197688/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03ea533a82e8c63c1bba8ec374efb8e5880993d7 commit 03ea533a82e8c63c1bba8ec374efb8e5880993d7 Author: Noel Gordon <noel@chromium.org> Date: Wed Aug 15 01:46:39 2018 Speed-up keyboard_operations.js copy file tests Speed-up these copy tests by loading the one file needed for the test, and adjust test comments. Test: browser_tests --gtest_filter="*/FilesApp*keyboardCopy*" Bug: 873915 Change-Id: Icbac3f7dd25dfae5b1119f021e5b336a4406ff7a Reviewed-on: https://chromium-review.googlesource.com/1174337 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583121} [modify] https://crrev.com/03ea533a82e8c63c1bba8ec374efb8e5880993d7/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
,
Aug 15
TODO: above does a directory delete. We should add a separate delete test case for a file, as lucmult@ mentioned, the Files.app JS code branches on "flle vs directory" [1]. [1] https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/common/js/util.js?l=192-196&rcl=8711d1bf063edb0ea021b23089b4dbd52c26f017
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f795f24dc859e264d6a4fb8146277a7a3a315439 commit f795f24dc859e264d6a4fb8146277a7a3a315439 Author: Noel Gordon <noel@chromium.org> Date: Wed Aug 15 05:21:41 2018 Add keyboard_operations.js delete file test case Deleting a file or folder exercise different code paths in Files app. There is a test case for a folder (aka, a directory). Add a test case for deleting a file. Test: browser_tests --gtest_filter="*FilesApp*keyboardDelete*" Bug: 873915 Change-Id: I618f7808be3eab4f73a97068cd8298f05f464ed8 Reviewed-on: https://chromium-review.googlesource.com/1174588 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583172} [modify] https://crrev.com/f795f24dc859e264d6a4fb8146277a7a3a315439/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/f795f24dc859e264d6a4fb8146277a7a3a315439/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1ba1c3a62a0c3465e4c5a9f1ffd3c62e978ad30 commit a1ba1c3a62a0c3465e4c5a9f1ffd3c62e978ad30 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Aug 16 06:29:27 2018 Remove unnecessary style recalculation from tests Change extractElementInfo function to only extract the properties that causes style recalculation if needed. This speeds up most of the tests since they don't require style information. Add waitForElementStyle to wait for element and also extract its style properties and used where it is needed. Manually tested locally and it improved the performance in a debug build running all 262 integrations from 5m44s to 5m13s, an improvement of ~10%. Bug: 873915 Change-Id: I4f5d66c2c730ec89c3c09482b1fd8cb493c5379e Reviewed-on: https://chromium-review.googlesource.com/1174087 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#583564} [modify] https://crrev.com/a1ba1c3a62a0c3465e4c5a9f1ffd3c62e978ad30/ui/file_manager/file_manager/background/js/test_util_base.js [modify] https://crrev.com/a1ba1c3a62a0c3465e4c5a9f1ffd3c62e978ad30/ui/file_manager/integration_tests/gallery/open_image_files.js [modify] https://crrev.com/a1ba1c3a62a0c3465e4c5a9f1ffd3c62e978ad30/ui/file_manager/integration_tests/remote_call.js
,
Aug 16
^^^ Icing on cake, the link to watch for his issue: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=mash_browser_tests&tests=KeyboardOperations%2FFilesApps*
,
Aug 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 14