New issue
Advanced search Search tips

Issue 873914 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to blink::ImageBitmap from base class subobject at offset 80 in blink::WebGLRenderingContextBase::TexImageByGPU

Project Member Reported by ClusterFuzz, Aug 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5679703856513024

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x0ec806996e80
Crash State:
  Bad-cast to blink::ImageBitmap from base class subobject at offset 80
  blink::WebGLRenderingContextBase::TexImageByGPU
  blink::WebGLRenderingContextBase::TexImageHelperCanvasRenderingContextHost
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=582595:582596

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5679703856513024

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 14

Components: Blink>WebGL
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 14

Labels: Test-Predator-Auto-Owner
Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/3882b0e88bf80436a45068651d3b4277612e33a0 (Make OffscreenCanvas usable as a source for texImage*).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 14

Labels: Target-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 14

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 14

Labels: Pri-1
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1548e78606431c60ad243b1a78847e41753cdf14

commit 1548e78606431c60ad243b1a78847e41753cdf14
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue Aug 14 22:08:31 2018

Unite Canvas and OffscreenCanvas snapshot for webgl texImage

TBR=kbr@chromium.org

Bug:  753483 ,  873914 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I958694f9db571b66c40baf144025d87acf824dc2
Reviewed-on: https://chromium-review.googlesource.com/1173169
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583050}
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/canvas_resource_host.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/static_bitmap_image.h
[modify] https://crrev.com/1548e78606431c60ad243b1a78847e41753cdf14/third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h

Project Member

Comment 8 by ClusterFuzz, Aug 15

ClusterFuzz has detected this issue as fixed in range 583048:583050.

Detailed report: https://clusterfuzz.com/testcase?key=5679703856513024

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x0ec806996e80
Crash State:
  Bad-cast to blink::ImageBitmap from base class subobject at offset 80
  blink::WebGLRenderingContextBase::TexImageByGPU
  blink::WebGLRenderingContextBase::TexImageHelperCanvasRenderingContextHost
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=582595:582596
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=583048:583050

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5679703856513024

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Aug 15

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5679703856513024 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 15

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 21

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment